From: Joe Perches <joe@perches.com>
To: Fatih ALTINPINAR <fatihaltinpinar@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hariprasad Kelam <hariprasad.kelam@gmail.com>,
Himadri Pandya <himadri18.07@gmail.com>,
Josenivaldo Benito Jr <jrbenito@benito.qsl.br>,
Larry Finger <Larry.Finger@lwfinger.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: hal: rtl8723bs_recv.c: Fix code style
Date: Wed, 10 Jul 2019 15:30:32 -0700 [thread overview]
Message-ID: <bc0f21dd8753190c6fbba0d3f7469a2d8c87b341.camel@perches.com> (raw)
In-Reply-To: <20190708095652.18174-1-fatihaltinpinar@gmail.com>
On Mon, 2019-07-08 at 12:56 +0300, Fatih ALTINPINAR wrote:
> Fixed a coding stlye issue. Removed braces from a single statement if
> block.
>
> Signed-off-by: Fatih ALTINPINAR <fatihaltinpinar@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> index e23b39ab16c5..71a4bcbeada9 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> @@ -449,9 +449,8 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
> skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
> }
>
> - if (!precvbuf->pskb) {
> + if (!precvbuf->pskb)
> DBG_871X("%s: alloc_skb fail!\n", __func__);
> - }
You could delete the block instead.
alloc_skb failures already do a dump_stack()
prev parent reply other threads:[~2019-07-10 22:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 9:56 Fatih ALTINPINAR
2019-07-10 22:30 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc0f21dd8753190c6fbba0d3f7469a2d8c87b341.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=fatihaltinpinar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hariprasad.kelam@gmail.com \
--cc=himadri18.07@gmail.com \
--cc=jrbenito@benito.qsl.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®