* [PATCH] Staging: rtl8723bs: hal: rtl8723bs_recv.c: Fix code style
@ 2019-07-08 9:56 Fatih ALTINPINAR
2019-07-10 22:30 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Fatih ALTINPINAR @ 2019-07-08 9:56 UTC (permalink / raw)
Cc: Fatih ALTINPINAR, Greg Kroah-Hartman, Hariprasad Kelam,
Himadri Pandya, Josenivaldo Benito Jr, Larry Finger, devel,
linux-kernel
Fixed a coding stlye issue. Removed braces from a single statement if
block.
Signed-off-by: Fatih ALTINPINAR <fatihaltinpinar@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
index e23b39ab16c5..71a4bcbeada9 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
@@ -449,9 +449,8 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
}
- if (!precvbuf->pskb) {
+ if (!precvbuf->pskb)
DBG_871X("%s: alloc_skb fail!\n", __func__);
- }
}
list_add_tail(&precvbuf->list, &precvpriv->free_recv_buf_queue.queue);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Staging: rtl8723bs: hal: rtl8723bs_recv.c: Fix code style
2019-07-08 9:56 [PATCH] Staging: rtl8723bs: hal: rtl8723bs_recv.c: Fix code style Fatih ALTINPINAR
@ 2019-07-10 22:30 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2019-07-10 22:30 UTC (permalink / raw)
To: Fatih ALTINPINAR
Cc: Greg Kroah-Hartman, Hariprasad Kelam, Himadri Pandya,
Josenivaldo Benito Jr, Larry Finger, devel, linux-kernel
On Mon, 2019-07-08 at 12:56 +0300, Fatih ALTINPINAR wrote:
> Fixed a coding stlye issue. Removed braces from a single statement if
> block.
>
> Signed-off-by: Fatih ALTINPINAR <fatihaltinpinar@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> index e23b39ab16c5..71a4bcbeada9 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> @@ -449,9 +449,8 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
> skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
> }
>
> - if (!precvbuf->pskb) {
> + if (!precvbuf->pskb)
> DBG_871X("%s: alloc_skb fail!\n", __func__);
> - }
You could delete the block instead.
alloc_skb failures already do a dump_stack()
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-10 22:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 9:56 [PATCH] Staging: rtl8723bs: hal: rtl8723bs_recv.c: Fix code style Fatih ALTINPINAR
2019-07-10 22:30 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®