From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Ariel Elior <aelior@marvell.com>,
Manish Chopra <manishc@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@collabora.com, kernel-janitors@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qede: remove linux/version.h
Date: Fri, 3 Mar 2023 23:51:37 +0500 [thread overview]
Message-ID: <bc11e5ca-b259-8bfd-6d20-65eab089fbd0@collabora.com> (raw)
In-Reply-To: <f29ae960-dea1-6754-3957-412e3c4d095c@intel.com>
On 3/3/23 8:35 PM, Alexander Lobakin wrote:
> From: Muhammad Usama Anjum <usama.anjum@collabora.com>
> Date: Fri, 3 Mar 2023 17:58:44 +0500
>
>> make versioncheck reports the following:
>> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
>> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
>>
>> So remove linux/version.h from both of these files.
>>
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>> ---
>> drivers/net/ethernet/qlogic/qede/qede.h | 1 -
>> drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
>> 2 files changed, 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
>> index f90dcfe9ee68..6ff1bd48d2aa 100644
>> --- a/drivers/net/ethernet/qlogic/qede/qede.h
>> +++ b/drivers/net/ethernet/qlogic/qede/qede.h
>> @@ -7,7 +7,6 @@
>> #ifndef _QEDE_H_
>> #define _QEDE_H_
>> #include <linux/compiler.h>
>
> I think compiler.h is also unused, maybe this one too, while at it?'
Just checked, it is also not being used. I'll send v2.
>
>> -#include <linux/version.h>
>> #include <linux/workqueue.h>
>> #include <linux/netdevice.h>
>> #include <linux/interrupt.h>
>> diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> index 8034d812d5a0..374a86b875a3 100644
>> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> @@ -4,7 +4,6 @@
>> * Copyright (c) 2019-2020 Marvell International Ltd.
>> */
>>
>> -#include <linux/version.h>
>> #include <linux/types.h>
>> #include <linux/netdevice.h>
>> #include <linux/etherdevice.h>
>
> Thanks,
> Olek
--
BR,
Muhammad Usama Anjum
prev parent reply other threads:[~2023-03-03 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 12:58 Muhammad Usama Anjum
2023-03-03 15:35 ` Alexander Lobakin
2023-03-03 18:51 ` Muhammad Usama Anjum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc11e5ca-b259-8bfd-6d20-65eab089fbd0@collabora.com \
--to=usama.anjum@collabora.com \
--cc=aelior@marvell.com \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®