mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] qede: remove linux/version.h
@ 2023-03-03 12:58 Muhammad Usama Anjum
  2023-03-03 15:35 ` Alexander Lobakin
  0 siblings, 1 reply; 3+ messages in thread
From: Muhammad Usama Anjum @ 2023-03-03 12:58 UTC (permalink / raw)
  To: Ariel Elior, Manish Chopra, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni
  Cc: Muhammad Usama Anjum, kernel, kernel-janitors, netdev, linux-kernel

make versioncheck reports the following:
./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.

So remove linux/version.h from both of these files.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 drivers/net/ethernet/qlogic/qede/qede.h         | 1 -
 drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
index f90dcfe9ee68..6ff1bd48d2aa 100644
--- a/drivers/net/ethernet/qlogic/qede/qede.h
+++ b/drivers/net/ethernet/qlogic/qede/qede.h
@@ -7,7 +7,6 @@
 #ifndef _QEDE_H_
 #define _QEDE_H_
 #include <linux/compiler.h>
-#include <linux/version.h>
 #include <linux/workqueue.h>
 #include <linux/netdevice.h>
 #include <linux/interrupt.h>
diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
index 8034d812d5a0..374a86b875a3 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
@@ -4,7 +4,6 @@
  * Copyright (c) 2019-2020 Marvell International Ltd.
  */
 
-#include <linux/version.h>
 #include <linux/types.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
-- 
2.39.2


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] qede: remove linux/version.h
  2023-03-03 12:58 [PATCH] qede: remove linux/version.h Muhammad Usama Anjum
@ 2023-03-03 15:35 ` Alexander Lobakin
  2023-03-03 18:51   ` Muhammad Usama Anjum
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Lobakin @ 2023-03-03 15:35 UTC (permalink / raw)
  To: Muhammad Usama Anjum
  Cc: Ariel Elior, Manish Chopra, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, kernel, kernel-janitors, netdev,
	linux-kernel

From: Muhammad Usama Anjum <usama.anjum@collabora.com>
Date: Fri,  3 Mar 2023 17:58:44 +0500

> make versioncheck reports the following:
> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
> 
> So remove linux/version.h from both of these files.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>  drivers/net/ethernet/qlogic/qede/qede.h         | 1 -
>  drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
> index f90dcfe9ee68..6ff1bd48d2aa 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede.h
> +++ b/drivers/net/ethernet/qlogic/qede/qede.h
> @@ -7,7 +7,6 @@
>  #ifndef _QEDE_H_
>  #define _QEDE_H_
>  #include <linux/compiler.h>

I think compiler.h is also unused, maybe this one too, while at it?

> -#include <linux/version.h>
>  #include <linux/workqueue.h>
>  #include <linux/netdevice.h>
>  #include <linux/interrupt.h>
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> index 8034d812d5a0..374a86b875a3 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> @@ -4,7 +4,6 @@
>   * Copyright (c) 2019-2020 Marvell International Ltd.
>   */
>  
> -#include <linux/version.h>
>  #include <linux/types.h>
>  #include <linux/netdevice.h>
>  #include <linux/etherdevice.h>

Thanks,
Olek

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] qede: remove linux/version.h
  2023-03-03 15:35 ` Alexander Lobakin
@ 2023-03-03 18:51   ` Muhammad Usama Anjum
  0 siblings, 0 replies; 3+ messages in thread
From: Muhammad Usama Anjum @ 2023-03-03 18:51 UTC (permalink / raw)
  To: Alexander Lobakin
  Cc: Muhammad Usama Anjum, Ariel Elior, Manish Chopra,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	kernel, kernel-janitors, netdev, linux-kernel

On 3/3/23 8:35 PM, Alexander Lobakin wrote:
> From: Muhammad Usama Anjum <usama.anjum@collabora.com>
> Date: Fri,  3 Mar 2023 17:58:44 +0500
> 
>> make versioncheck reports the following:
>> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
>> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
>>
>> So remove linux/version.h from both of these files.
>>
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>> ---
>>  drivers/net/ethernet/qlogic/qede/qede.h         | 1 -
>>  drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
>>  2 files changed, 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
>> index f90dcfe9ee68..6ff1bd48d2aa 100644
>> --- a/drivers/net/ethernet/qlogic/qede/qede.h
>> +++ b/drivers/net/ethernet/qlogic/qede/qede.h
>> @@ -7,7 +7,6 @@
>>  #ifndef _QEDE_H_
>>  #define _QEDE_H_
>>  #include <linux/compiler.h>
> 
> I think compiler.h is also unused, maybe this one too, while at it?'
Just checked, it is also not being used. I'll send v2.

> 
>> -#include <linux/version.h>
>>  #include <linux/workqueue.h>
>>  #include <linux/netdevice.h>
>>  #include <linux/interrupt.h>
>> diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> index 8034d812d5a0..374a86b875a3 100644
>> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> @@ -4,7 +4,6 @@
>>   * Copyright (c) 2019-2020 Marvell International Ltd.
>>   */
>>  
>> -#include <linux/version.h>
>>  #include <linux/types.h>
>>  #include <linux/netdevice.h>
>>  #include <linux/etherdevice.h>
> 
> Thanks,
> Olek

-- 
BR,
Muhammad Usama Anjum

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-03 18:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-03 12:58 [PATCH] qede: remove linux/version.h Muhammad Usama Anjum
2023-03-03 15:35 ` Alexander Lobakin
2023-03-03 18:51   ` Muhammad Usama Anjum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®