mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH v3] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
       [not found] <20241006205737.8829-1-zichenxie0106@gmail.com>
@ 2024-10-07 13:16 ` Markus Elfring
  2024-10-07 13:47   ` Mark Brown
  2024-10-07 13:40 ` [v3?] " Markus Elfring
  1 sibling, 1 reply; 4+ messages in thread
From: Markus Elfring @ 2024-10-07 13:16 UTC (permalink / raw)
  To: Zichen Xie, alsa-devel, linux-sound, linux-arm-msm,
	Dmitry Baryshkov, Greg Kroah-Hartman, Jaroslav Kysela,
	Liam Girdwood, Mark Brown, Rohit kumar, Srinivas Kandagatla,
	Takashi Iwai
  Cc: stable, LKML, Chenyuan Yang, Zijie Zhao

> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could

                   call?


> possibly return NULL pointer. NULL Pointer Dereference may be

Can the term “null pointer dereference” be applied for
the final commit message (including the summary phrase)?


> triggerred without addtional check.

  triggered?         additional?


Regards,
Markus

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [v3?] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
       [not found] <20241006205737.8829-1-zichenxie0106@gmail.com>
  2024-10-07 13:16 ` [PATCH v3] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe() Markus Elfring
@ 2024-10-07 13:40 ` Markus Elfring
  2024-10-07 14:14   ` Mark Brown
  1 sibling, 1 reply; 4+ messages in thread
From: Markus Elfring @ 2024-10-07 13:40 UTC (permalink / raw)
  To: Zichen Xie, alsa-devel, linux-sound, linux-arm-msm,
	Dmitry Baryshkov, Greg Kroah-Hartman, Jaroslav Kysela,
	Liam Girdwood, Mark Brown, Rohit kumar, Srinivas Kandagatla,
	Takashi Iwai
  Cc: stable, LKML, Chenyuan Yang, Zijie Zhao

…
> ---
> v2: Fix "From" tag.
> v3: Format tags to Fixes/Cc/Signed-off-by.
> ---
…

* How do you think about to reconsider the version numbers
  a bit more?

* Would you like to mention the repeated adjustment of
  the patch subject?

* Can a duplicate marker line be replaced by a blank line?


See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n231

Is the email address “linux-kernel@vger.kernel.org” still relevant here?

Regards,
Markus

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
  2024-10-07 13:16 ` [PATCH v3] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe() Markus Elfring
@ 2024-10-07 13:47   ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2024-10-07 13:47 UTC (permalink / raw)
  To: Markus Elfring
  Cc: Zichen Xie, alsa-devel, linux-sound, linux-arm-msm,
	Dmitry Baryshkov, Greg Kroah-Hartman, Jaroslav Kysela,
	Liam Girdwood, Rohit kumar, Srinivas Kandagatla, Takashi Iwai,
	stable, LKML, Chenyuan Yang, Zijie Zhao

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

On Mon, Oct 07, 2024 at 03:16:27PM +0200, Markus Elfring wrote:
> > A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could
> 
>                    call?
> 
> 
> > possibly return NULL pointer. NULL Pointer Dereference may be
> 
> Can the term “null pointer dereference” be applied for
> the final commit message (including the summary phrase)?
> 
> 
> > triggerred without addtional check.
> 
>   triggered?         additional?

Feel free to ignore Markus, he has a long history of sending
unhelpful review comments and continues to ignore repeated requests
to stop.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [v3?] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
  2024-10-07 13:40 ` [v3?] " Markus Elfring
@ 2024-10-07 14:14   ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2024-10-07 14:14 UTC (permalink / raw)
  To: Markus Elfring
  Cc: Zichen Xie, alsa-devel, linux-sound, linux-arm-msm,
	Dmitry Baryshkov, Greg Kroah-Hartman, Jaroslav Kysela,
	Liam Girdwood, Rohit kumar, Srinivas Kandagatla, Takashi Iwai,
	stable, LKML, Chenyuan Yang, Zijie Zhao

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

On Mon, Oct 07, 2024 at 03:40:21PM +0200, Markus Elfring wrote:

> * How do you think about to reconsider the version numbers
>   a bit more?
> 
> * Would you like to mention the repeated adjustment of
>   the patch subject?
> 
> * Can a duplicate marker line be replaced by a blank line?

Feel free to ignore Markus, he has a long history of sending
unhelpful review comments and continues to ignore repeated requests
to stop.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-07 14:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20241006205737.8829-1-zichenxie0106@gmail.com>
2024-10-07 13:16 ` [PATCH v3] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe() Markus Elfring
2024-10-07 13:47   ` Mark Brown
2024-10-07 13:40 ` [v3?] " Markus Elfring
2024-10-07 14:14   ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome