From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: Liao Yuanhong <liaoyuanhong@vivo.com>,
"open list:JFS FILESYSTEM" <jfs-discussion@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] JFS: Remove unnecessary parentheses
Date: Wed, 17 Sep 2025 13:37:07 -0500 [thread overview]
Message-ID: <bc564654-451c-46ae-84f3-21c8e4259c1f@oracle.com> (raw)
In-Reply-To: <20250825133651.337691-1-liaoyuanhong@vivo.com>
On 8/25/25 8:36AM, Liao Yuanhong wrote:
> When using &, it's unnecessary to have parentheses afterward. Remove
> redundant parentheses to enhance readability.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Applying.
Thanks,
Shaggy
> ---
> fs/jfs/jfs_mount.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/jfs/jfs_mount.c b/fs/jfs/jfs_mount.c
> index 98f9a432c336..52e6b58c5dbd 100644
> --- a/fs/jfs/jfs_mount.c
> +++ b/fs/jfs/jfs_mount.c
> @@ -325,13 +325,13 @@ static int chkSuper(struct super_block *sb)
> if ((j_sb->s_flag & cpu_to_le32(JFS_BAD_SAIT)) !=
> cpu_to_le32(JFS_BAD_SAIT)) {
> expected_AIM_bytesize = 2 * PSIZE;
> - AIM_bytesize = lengthPXD(&(j_sb->s_aim2)) * bsize;
> + AIM_bytesize = lengthPXD(&j_sb->s_aim2) * bsize;
> expected_AIT_bytesize = 4 * PSIZE;
> - AIT_bytesize = lengthPXD(&(j_sb->s_ait2)) * bsize;
> - AIM_byte_addr = addressPXD(&(j_sb->s_aim2)) * bsize;
> - AIT_byte_addr = addressPXD(&(j_sb->s_ait2)) * bsize;
> + AIT_bytesize = lengthPXD(&j_sb->s_ait2) * bsize;
> + AIM_byte_addr = addressPXD(&j_sb->s_aim2) * bsize;
> + AIT_byte_addr = addressPXD(&j_sb->s_ait2) * bsize;
> byte_addr_diff0 = AIT_byte_addr - AIM_byte_addr;
> - fsckwsp_addr = addressPXD(&(j_sb->s_fsckpxd)) * bsize;
> + fsckwsp_addr = addressPXD(&j_sb->s_fsckpxd) * bsize;
> byte_addr_diff1 = fsckwsp_addr - AIT_byte_addr;
> if ((AIM_bytesize != expected_AIM_bytesize) ||
> (AIT_bytesize != expected_AIT_bytesize) ||
prev parent reply other threads:[~2025-09-17 18:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 13:36 Liao Yuanhong
2025-09-17 18:37 ` Dave Kleikamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc564654-451c-46ae-84f3-21c8e4259c1f@oracle.com \
--to=dave.kleikamp@oracle.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=liaoyuanhong@vivo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®