* [PATCH] JFS: Remove unnecessary parentheses
@ 2025-08-25 13:36 Liao Yuanhong
2025-09-17 18:37 ` Dave Kleikamp
0 siblings, 1 reply; 2+ messages in thread
From: Liao Yuanhong @ 2025-08-25 13:36 UTC (permalink / raw)
To: Dave Kleikamp, open list:JFS FILESYSTEM, open list; +Cc: Liao Yuanhong
When using &, it's unnecessary to have parentheses afterward. Remove
redundant parentheses to enhance readability.
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
fs/jfs/jfs_mount.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/jfs/jfs_mount.c b/fs/jfs/jfs_mount.c
index 98f9a432c336..52e6b58c5dbd 100644
--- a/fs/jfs/jfs_mount.c
+++ b/fs/jfs/jfs_mount.c
@@ -325,13 +325,13 @@ static int chkSuper(struct super_block *sb)
if ((j_sb->s_flag & cpu_to_le32(JFS_BAD_SAIT)) !=
cpu_to_le32(JFS_BAD_SAIT)) {
expected_AIM_bytesize = 2 * PSIZE;
- AIM_bytesize = lengthPXD(&(j_sb->s_aim2)) * bsize;
+ AIM_bytesize = lengthPXD(&j_sb->s_aim2) * bsize;
expected_AIT_bytesize = 4 * PSIZE;
- AIT_bytesize = lengthPXD(&(j_sb->s_ait2)) * bsize;
- AIM_byte_addr = addressPXD(&(j_sb->s_aim2)) * bsize;
- AIT_byte_addr = addressPXD(&(j_sb->s_ait2)) * bsize;
+ AIT_bytesize = lengthPXD(&j_sb->s_ait2) * bsize;
+ AIM_byte_addr = addressPXD(&j_sb->s_aim2) * bsize;
+ AIT_byte_addr = addressPXD(&j_sb->s_ait2) * bsize;
byte_addr_diff0 = AIT_byte_addr - AIM_byte_addr;
- fsckwsp_addr = addressPXD(&(j_sb->s_fsckpxd)) * bsize;
+ fsckwsp_addr = addressPXD(&j_sb->s_fsckpxd) * bsize;
byte_addr_diff1 = fsckwsp_addr - AIT_byte_addr;
if ((AIM_bytesize != expected_AIM_bytesize) ||
(AIT_bytesize != expected_AIT_bytesize) ||
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] JFS: Remove unnecessary parentheses
2025-08-25 13:36 [PATCH] JFS: Remove unnecessary parentheses Liao Yuanhong
@ 2025-09-17 18:37 ` Dave Kleikamp
0 siblings, 0 replies; 2+ messages in thread
From: Dave Kleikamp @ 2025-09-17 18:37 UTC (permalink / raw)
To: Liao Yuanhong, open list:JFS FILESYSTEM, open list
On 8/25/25 8:36AM, Liao Yuanhong wrote:
> When using &, it's unnecessary to have parentheses afterward. Remove
> redundant parentheses to enhance readability.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Applying.
Thanks,
Shaggy
> ---
> fs/jfs/jfs_mount.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/jfs/jfs_mount.c b/fs/jfs/jfs_mount.c
> index 98f9a432c336..52e6b58c5dbd 100644
> --- a/fs/jfs/jfs_mount.c
> +++ b/fs/jfs/jfs_mount.c
> @@ -325,13 +325,13 @@ static int chkSuper(struct super_block *sb)
> if ((j_sb->s_flag & cpu_to_le32(JFS_BAD_SAIT)) !=
> cpu_to_le32(JFS_BAD_SAIT)) {
> expected_AIM_bytesize = 2 * PSIZE;
> - AIM_bytesize = lengthPXD(&(j_sb->s_aim2)) * bsize;
> + AIM_bytesize = lengthPXD(&j_sb->s_aim2) * bsize;
> expected_AIT_bytesize = 4 * PSIZE;
> - AIT_bytesize = lengthPXD(&(j_sb->s_ait2)) * bsize;
> - AIM_byte_addr = addressPXD(&(j_sb->s_aim2)) * bsize;
> - AIT_byte_addr = addressPXD(&(j_sb->s_ait2)) * bsize;
> + AIT_bytesize = lengthPXD(&j_sb->s_ait2) * bsize;
> + AIM_byte_addr = addressPXD(&j_sb->s_aim2) * bsize;
> + AIT_byte_addr = addressPXD(&j_sb->s_ait2) * bsize;
> byte_addr_diff0 = AIT_byte_addr - AIM_byte_addr;
> - fsckwsp_addr = addressPXD(&(j_sb->s_fsckpxd)) * bsize;
> + fsckwsp_addr = addressPXD(&j_sb->s_fsckpxd) * bsize;
> byte_addr_diff1 = fsckwsp_addr - AIT_byte_addr;
> if ((AIM_bytesize != expected_AIM_bytesize) ||
> (AIT_bytesize != expected_AIT_bytesize) ||
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-17 18:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-25 13:36 [PATCH] JFS: Remove unnecessary parentheses Liao Yuanhong
2025-09-17 18:37 ` Dave Kleikamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®