mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: <cros-qcom-dts-watchers@chromium.org>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kernel@oss.qualcomm.com>,
	Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Subject: Re: [PATCH v1 8/8] arm64: dts: qcom: qcm6490-idp: Add sound card
Date: Tue, 22 Apr 2025 22:51:29 +0530	[thread overview]
Message-ID: <bc69172d-1e7d-4aff-8c85-baeee587a771@quicinc.com> (raw)
In-Reply-To: <2a9df021-72f7-4bcd-8c93-634c2b77dfe1@linaro.org>



On 3/27/2025 4:42 AM, Bryan O'Donoghue wrote:
> On 17/03/2025 05:41, Prasad Kumpatla wrote:
>> Add the sound card node with tested playback over WSA8835 speakers,
>> msm mic along with wcd9370 headset playabck and record.
> 
> I think as a reviewer I'd like a better description.
> 
> "msm mic" doesn't mean much - please specify the number of MICs and 
> their type - "four digital mics"
> 
> MSM Mics are not a meaningful description.

ACK,
Will provide proper description in next patchset version.

Thanks,
Prasad>
> ---
> bod


      reply	other threads:[~2025-04-22 17:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17  5:41 [PATCH v1 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Prasad Kumpatla
2025-03-17  5:41 ` [PATCH v1 1/8] arm64: dts: qcom: sc7280: Add gpr node Prasad Kumpatla
2025-03-26 22:51   ` Bryan O'Donoghue
2025-04-22 16:19     ` Prasad Kumpatla
2025-03-17  5:41 ` [PATCH v1 2/8] arm64: dts: qcom: sc7280: Add WSA SoundWire and LPASS support Prasad Kumpatla
2025-03-26 23:02   ` Bryan O'Donoghue
2025-04-22 16:22     ` Prasad Kumpatla
2025-03-27 14:12   ` Dmitry Baryshkov
2025-04-22 16:24     ` Prasad Kumpatla
2025-03-17  5:41 ` [PATCH v1 3/8] arm64: dts: qcom: qcs6490-rb3gen2: Modify WSA and VA macro clock nodes for audioreach solution Prasad Kumpatla
2025-04-01 16:05   ` Konrad Dybcio
2025-04-04  7:12     ` Luca Weiss
2025-04-22 16:59       ` Prasad Kumpatla
2025-03-17  5:41 ` [PATCH v1 4/8] arm64: dts: qcom: qcs6490-rb3gen2: add WSA8830 speakers amplifier Prasad Kumpatla
2025-03-26 17:28   ` Jorge Ramirez
2025-04-22 17:08     ` Prasad Kumpatla
2025-03-17  5:41 ` [PATCH v1 5/8] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card Prasad Kumpatla
2025-04-01 21:32   ` Konrad Dybcio
2025-04-22 17:19     ` Prasad Kumpatla
2025-03-17  5:41 ` [PATCH v1 6/8] arm64: dts: qcom: qcm6490-idp: Modify WSA/VA/RX/TX macro clock nodes for audioreach solution Prasad Kumpatla
2025-03-17  5:41 ` [PATCH v1 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers amplifier and WCD9370 headset codec Prasad Kumpatla
2025-03-17  5:41 ` [PATCH v1 8/8] arm64: dts: qcom: qcm6490-idp: Add sound card Prasad Kumpatla
2025-03-26 23:12   ` Bryan O'Donoghue
2025-04-22 17:21     ` Prasad Kumpatla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc69172d-1e7d-4aff-8c85-baeee587a771@quicinc.com \
    --to=quic_pkumpatl@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_mohs@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®