mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sia Jee Heng <jeeheng.sia@starfivetech.com>,
	kernel@esmil.dk, conor@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu,
	mturquette@baylibre.com, sboyd@kernel.org,
	p.zabel@pengutronix.de, emil.renner.berthing@canonical.com,
	hal.feng@starfivetech.com, xingyu.wu@starfivetech.com
Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	leyfoon.tan@starfivetech.com
Subject: Re: [RFC 16/16] riscv: dts: starfive: jh8100: Add clocks and resets nodes
Date: Tue, 26 Dec 2023 14:38:44 +0100	[thread overview]
Message-ID: <bc6b5c5e-9396-4740-af99-1eda4275526b@linaro.org> (raw)
In-Reply-To: <20231226053848.25089-17-jeeheng.sia@starfivetech.com>

On 26/12/2023 06:38, Sia Jee Heng wrote:
> Add SYSCRG/SYSCRG-NE/SYSCRG-NW/SYSCRG-SW/AONCRG clock and reset
> nodes for JH8100 RISC-V SoC.
> 
> Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com>
> Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> ---

...

>  		compatible = "simple-bus";
>  		interrupt-parent = <&plic>;
> @@ -357,6 +563,99 @@ uart4: serial@121a0000  {
>  			status = "disabled";
>  		};
>  
> +		necrg: necrg@12320000 {

This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.

Best regards,
Krzysztof


  reply	other threads:[~2023-12-26 13:38 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-26  5:38 [RFC 00/16] Basic clock and reset support for StarFive JH8100 RISC-V SoC Sia Jee Heng
2023-12-26  5:38 ` [RFC 01/16] reset: starfive: Rename file name "jh71x0" to "common" Sia Jee Heng
2023-12-26  5:38 ` [RFC 02/16] reset: starfive: Convert the word "jh71x0" to "starfive" Sia Jee Heng
2023-12-26  5:38 ` [RFC 03/16] clk: starfive: Rename file name "jh71x0" to "common" Sia Jee Heng
2023-12-26  5:38 ` [RFC 04/16] clk: starfive: Convert the word "jh71x0" to "starfive" Sia Jee Heng
2023-12-26  5:38 ` [RFC 05/16] dt-bindings: clock: Add StarFive JH8100 System clock and reset generator Sia Jee Heng
2023-12-26 13:34   ` Krzysztof Kozlowski
2023-12-26  5:38 ` [RFC 06/16] clk: starfive: Add JH8100 System clock generator driver Sia Jee Heng
2023-12-26  5:38 ` [RFC 07/16] dt-bindings: clock: Add StarFive JH8100 North-West clock and reset generator Sia Jee Heng
2023-12-26 13:35   ` Krzysztof Kozlowski
2023-12-26 18:07   ` Samuel Holland
2023-12-27 10:51     ` JeeHeng Sia
2023-12-26  5:38 ` [RFC 08/16] clk: starfive: Add JH8100 North-West clock generator driver Sia Jee Heng
2023-12-26  5:38 ` [RFC 09/16] dt-bindings: clock: Add StarFive JH8100 North-East clock and reset generator Sia Jee Heng
2023-12-26 13:36   ` Krzysztof Kozlowski
2023-12-26  5:38 ` [RFC 10/16] clk: starfive: Add JH8100 North-East clock generator driver Sia Jee Heng
2023-12-26  5:38 ` [RFC 11/16] dt-bindings: clock: Add StarFive JH8100 South-West clock and reset generator Sia Jee Heng
2023-12-26 13:36   ` Krzysztof Kozlowski
2023-12-26  5:38 ` [RFC 12/16] clk: starfive: Add JH8100 South-West clock generator driver Sia Jee Heng
2023-12-26  5:38 ` [RFC 13/16] dt-bindings: clock: Add StarFive JH8100 Always-On clock and reset generator Sia Jee Heng
2023-12-26 13:37   ` Krzysztof Kozlowski
2023-12-26  5:38 ` [RFC 14/16] clk: starfive: Add JH8100 Always-On clock generator driver Sia Jee Heng
2023-12-26  5:38 ` [RFC 15/16] reset: starfive: Add StarFive JH8100 reset driver Sia Jee Heng
2023-12-26  5:38 ` [RFC 16/16] riscv: dts: starfive: jh8100: Add clocks and resets nodes Sia Jee Heng
2023-12-26 13:38   ` Krzysztof Kozlowski [this message]
2023-12-27 11:02     ` JeeHeng Sia
2023-12-26 13:33 ` [RFC 00/16] Basic clock and reset support for StarFive JH8100 RISC-V SoC Krzysztof Kozlowski
2023-12-27 11:03   ` JeeHeng Sia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc6b5c5e-9396-4740-af99-1eda4275526b@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=emil.renner.berthing@canonical.com \
    --cc=hal.feng@starfivetech.com \
    --cc=jeeheng.sia@starfivetech.com \
    --cc=kernel@esmil.dk \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leyfoon.tan@starfivetech.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=xingyu.wu@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®