mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>,
	Rob Clark <robin.clark@oss.qualcomm.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Kuogee Hsieh <quic_khsieh@quicinc.com>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	dmitry.baryshkov@oss.qualcomm.com,
	konrad.dybcio@oss.qualcomm.com, fange.zhang@oss.qualcomm.com,
	quic_lliu6@quicinc.com, quic_yongmou@quicinc.com
Subject: Re: [PATCH v2 12/13] drm/msm/dp: Add DisplayPort support for QCS615
Date: Tue, 22 Jul 2025 11:21:39 +0200	[thread overview]
Message-ID: <bca68e7a-cb36-4903-bde9-15cb1945c71e@kernel.org> (raw)
In-Reply-To: <20250722-add-displayport-support-for-qcs615-platform-v2-12-42b4037171f8@oss.qualcomm.com>

On 22/07/2025 09:22, Xiangxu Yin wrote:
> The Qualcomm QCS615 platform comes with a DisplayPort controller use the
> same base offset as sc7180. add support for this in DP driver.
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
> ---
>  drivers/gpu/drm/msm/dp/dp_display.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> index d87d47cc7ec3eb757ac192c411000bc50b824c59..ddb22b50490035779904d4cab20e2fee7e0f9657 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -196,6 +196,7 @@ static const struct of_device_id msm_dp_dt_match[] = {
>  	{ .compatible = "qcom,sc8280xp-dp", .data = &msm_dp_desc_sc8280xp },
>  	{ .compatible = "qcom,sc8280xp-edp", .data = &msm_dp_desc_sc8280xp },
>  	{ .compatible = "qcom,sdm845-dp", .data = &msm_dp_desc_sdm845 },
> +	{ .compatible = "qcom,sm6150-dp", .data = &msm_dp_desc_sc7180 },


So devices are compatible? Why are you adding this entry instead of
expressing compatibility?

Best regards,
Krzysztof

  reply	other threads:[~2025-07-22  9:21 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22  7:22 [PATCH v2 00/13] Add DisplayPort support for QCS615 platform Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 01/13] dt-bindings: display/msm: Document DP on QCS615 Xiangxu Yin
2025-07-22  9:13   ` Krzysztof Kozlowski
2025-07-22  9:16     ` Dmitry Baryshkov
2025-07-22  9:23       ` Krzysztof Kozlowski
2025-07-22  9:39         ` Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 02/13] dt-bindings: phy: Add binding for QCS615 standalone QMP DP PHY Xiangxu Yin
2025-07-22  8:38   ` Dmitry Baryshkov
2025-07-22 12:05     ` Xiangxu Yin
2025-07-22 12:41       ` Dmitry Baryshkov
2025-07-30  8:53         ` Xiangxu Yin
2025-07-30 18:35           ` Dmitry Baryshkov
2025-07-31  5:06             ` Xiangxu Yin
2025-07-31 17:13               ` Dmitry Baryshkov
2025-08-01  3:57                 ` Xiangxu Yin
2025-08-01  7:30                   ` Dmitry Baryshkov
2025-08-01  7:38                     ` Xiangxu Yin
2025-07-22  9:18   ` Krzysztof Kozlowski
2025-08-15  8:25     ` Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 03/13] dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: support dual TCSR registers Xiangxu Yin
2025-07-22  9:19   ` Krzysztof Kozlowski
2025-08-15  8:30     ` Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 04/13] phy: qcom: qmp-usbc: Rename USB structs and reorganize layout Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 05/13] phy: qcom: qmp-usbc: Introduce PHY type enum for USB/DP support Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 06/13] phy: qcom: qmp-usbc: Add DP PHY struct definitions Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 07/13] phy: qcom: qmp-usbc: Add QCS615 DP PHY configuration and init data Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 08/13] phy: qcom: qmp-usbc: Implement DP PHY bring-up flow for QCS615 Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 09/13] phy: qcom: qmp-usbc: Wire up DP PHY ops and " Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 10/13] phy: qcom: qmp-usbc: Track PHYs for standalone DP/USB3.0 handling Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 11/13] phy: qcom: qmp-usbc: Add QCS615 DP PHY compatible Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 12/13] drm/msm/dp: Add DisplayPort support for QCS615 Xiangxu Yin
2025-07-22  9:21   ` Krzysztof Kozlowski [this message]
2025-07-28  8:19     ` Xiangxu Yin
2025-07-22  7:22 ` [PATCH v2 13/13] drm/msm/dp: Add support for lane mapping configuration Xiangxu Yin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bca68e7a-cb36-4903-bde9-15cb1945c71e@kernel.org \
    --to=krzk@kernel.org \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fange.zhang@oss.qualcomm.com \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jessica.zhang@oss.qualcomm.com \
    --cc=kishon@kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=quic_khsieh@quicinc.com \
    --cc=quic_lliu6@quicinc.com \
    --cc=quic_yongmou@quicinc.com \
    --cc=robh@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=vkoul@kernel.org \
    --cc=xiangxu.yin@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®