From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
dmitry.baryshkov@oss.qualcomm.com,
konrad.dybcio@oss.qualcomm.com, fange.zhang@oss.qualcomm.com,
quic_lliu6@quicinc.com, quic_yongmou@quicinc.com
Subject: Re: [PATCH v2 02/13] dt-bindings: phy: Add binding for QCS615 standalone QMP DP PHY
Date: Fri, 15 Aug 2025 16:25:43 +0800 [thread overview]
Message-ID: <661789d6-5fbe-4915-b70a-5ff2466c7a26@oss.qualcomm.com> (raw)
In-Reply-To: <0c94206c-f70f-4bed-81ec-bb2870748121@kernel.org>
On 7/22/2025 5:18 PM, Krzysztof Kozlowski wrote:
> On 22/07/2025 09:22, Xiangxu Yin wrote:
>> Introduce device tree binding documentation for the Qualcomm QMP DP PHY
>> on QCS615 SoCs. This PHY supports DisplayPort functionality and is
>> designed to operate independently from the USB3 PHY.
> A nit, subject: drop second/last, redundant "binding for". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Ok, will update subject in next patch.
>> Unlike combo PHYs found on other platforms, the QCS615 DP PHY is
>> standalone and does not support USB/DP multiplexing. The binding
>> describes the required clocks, resets, TCSR configuration, and clock/PHY
>> cells for proper integration.
>>
>> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
>> ---
>> .../bindings/phy/qcom,qcs615-qmp-dp-phy.yaml | 111 +++++++++++++++++++++
>> 1 file changed, 111 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-dp-phy.yaml
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..17e37c1df7b61dc2f7aa35ee106fd94ee2829c5f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-dp-phy.yaml
>> @@ -0,0 +1,111 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/phy/qcom,qcs615-qmp-dp-phy.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm QMP PHY controller (DP, QCS615)
> That's too vague title. You are not adding here Qualcomm QMP PHY
> controllers.
Will update to 'Qualcomm QMP USB3-DP PHY controller (DP, QCS615)' in next patch.
>
>> +
>> +maintainers:
>> + - Vinod Koul <vkoul@kernel.org>
> Hm? Why?
I referred to the definitions in qcom,msm8998-qmp-usb3-phy.yaml and qcom,sc8280xp-qmp-usb43dp-phy.yaml.
I also found that Vinod Koul is listed as the maintainer of the GENERIC PHY FRAMEWORK in linux-next/MAINTAINERS.
Did I misunderstand anything here?
>> +
>> +description:
>> + The QMP DP PHY controller supports DisplayPort physical layer functionality
>> + on Qualcomm QCS615 SoCs. This PHY is independent from USB3 PHY and does not
>> + support combo mode.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - qcom,qcs615-qmp-dp-phy
>> +
>> + reg:
>> + maxItems: 4
> I don't understand what you are doing here. Why previous patch evolved
> into this? Where is any reasoning for that in the changelog? You said:
>
> "- Add new binding qcom,qcs615-qmp-dp-phy.yaml for QCS615 standalone DP
> [Krzysztof]"
>
> but you must say WHY you are doing things...
>
> Anyway, missing constraints. Look at other Qualcomm bindings.
I misunderstood your earlier comment in '20241129-add-displayport-support-for-qcs615-platform-v1-2-09a4338d93ef@quicinc.com' and mistakenly included "[Krzysztof]" in the commit message as if it were a quote.
Apologies for the confusion and will drop this part in cover letter in next patch.
In next patch, the address regions will be consolidated into a single range, similar to other QMP PHYs, and |maxItems| will be updated to |1|.
>
>> +
>> + clocks:
>> + maxItems: 2
>> +
>> + clock-names:
>> + items:
>> + - const: cfg_ahb
>> + - const: ref
>> +
>> + clock-output-names:
>> + maxItems: 2
>> + description:
>> + Names of the clocks provided by the PHY.
> Drop description, redundant. It cannot be anything else.
Ok, will drop it.
>
>> +
>> + qcom,tcsr-reg:
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> + items:
>> + - items:
>> + - description: phandle to TCSR hardware block
>> + - description: offset of the DP PHY moode register
>> + description:
>> + DP PHY moode register present in the TCSR
>> +
>> + resets:
>> + maxItems: 1
>> +
>> + reset-names:
>> + items:
>> + - const: phy
> Drop reset-names, useless.
In next patch, this config will be updated to USB or DP PHY binding with two resets: 'phy_phy' for USB and 'dp_phy' for DP.
Shall I keep 'reset-names' prop here?
>
>> +
>> + vdda-phy-supply: true
>> +
>> + vdda-pll-supply: true
>> +
>> + "#clock-cells":
>> + const: 1
>> + description:
>> + See include/dt-bindings/phy/phy-qcom-qmp.h
>> +
>> + "#phy-cells":
>> + const: 1
>> + description:
>> + See include/dt-bindings/phy/phy-qcom-qmp.h
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> + - clock-names
>> + - clock-output-names
>> + - qcom,tcsr-reg
>> + - resets
>> + - reset-names
>> + - vdda-phy-supply
>> + - vdda-pll-supply
>> + - "#clock-cells"
>> + - "#phy-cells"
>> +
> Why introducing completely different order? See existing binding and DTS
> coding style.
>
> Best regards,
> Krzysztof
Ok, will update to follow the existing order.
compatible
reg
clocks
clock-names
resets
reset-names
vdda-phy-supply
vdda-pll-supply
#clock-cells
#phy-cells
qcom,tcsr-reg
next prev parent reply other threads:[~2025-08-15 8:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 7:22 [PATCH v2 00/13] Add DisplayPort support for QCS615 platform Xiangxu Yin
2025-07-22 7:22 ` [PATCH v2 01/13] dt-bindings: display/msm: Document DP on QCS615 Xiangxu Yin
2025-07-22 9:13 ` Krzysztof Kozlowski
2025-07-22 9:16 ` Dmitry Baryshkov
2025-07-22 9:23 ` Krzysztof Kozlowski
2025-07-22 9:39 ` Xiangxu Yin
2025-07-22 7:22 ` [PATCH v2 02/13] dt-bindings: phy: Add binding for QCS615 standalone QMP DP PHY Xiangxu Yin
2025-07-22 8:38 ` Dmitry Baryshkov
2025-07-22 12:05 ` Xiangxu Yin
2025-07-22 12:41 ` Dmitry Baryshkov
2025-07-30 8:53 ` Xiangxu Yin
2025-07-30 18:35 ` Dmitry Baryshkov
2025-07-31 5:06 ` Xiangxu Yin
2025-07-31 17:13 ` Dmitry Baryshkov
2025-08-01 3:57 ` Xiangxu Yin
2025-08-01 7:30 ` Dmitry Baryshkov
2025-08-01 7:38 ` Xiangxu Yin
2025-07-22 9:18 ` Krzysztof Kozlowski
2025-08-15 8:25 ` Xiangxu Yin [this message]
2025-07-22 7:22 ` [PATCH v2 03/13] dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: support dual TCSR registers Xiangxu Yin
2025-07-22 9:19 ` Krzysztof Kozlowski
2025-08-15 8:30 ` Xiangxu Yin
2025-07-22 7:22 ` [PATCH v2 04/13] phy: qcom: qmp-usbc: Rename USB structs and reorganize layout Xiangxu Yin
2025-07-22 7:22 ` [PATCH v2 05/13] phy: qcom: qmp-usbc: Introduce PHY type enum for USB/DP support Xiangxu Yin
2025-07-22 7:22 ` [PATCH v2 06/13] phy: qcom: qmp-usbc: Add DP PHY struct definitions Xiangxu Yin
2025-07-22 7:22 ` [PATCH v2 07/13] phy: qcom: qmp-usbc: Add QCS615 DP PHY configuration and init data Xiangxu Yin
2025-07-22 7:22 ` [PATCH v2 08/13] phy: qcom: qmp-usbc: Implement DP PHY bring-up flow for QCS615 Xiangxu Yin
2025-07-22 7:22 ` [PATCH v2 09/13] phy: qcom: qmp-usbc: Wire up DP PHY ops and " Xiangxu Yin
2025-07-22 7:22 ` [PATCH v2 10/13] phy: qcom: qmp-usbc: Track PHYs for standalone DP/USB3.0 handling Xiangxu Yin
2025-07-22 7:22 ` [PATCH v2 11/13] phy: qcom: qmp-usbc: Add QCS615 DP PHY compatible Xiangxu Yin
2025-07-22 7:22 ` [PATCH v2 12/13] drm/msm/dp: Add DisplayPort support for QCS615 Xiangxu Yin
2025-07-22 9:21 ` Krzysztof Kozlowski
2025-07-28 8:19 ` Xiangxu Yin
2025-07-22 7:22 ` [PATCH v2 13/13] drm/msm/dp: Add support for lane mapping configuration Xiangxu Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=661789d6-5fbe-4915-b70a-5ff2466c7a26@oss.qualcomm.com \
--to=xiangxu.yin@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fange.zhang@oss.qualcomm.com \
--cc=freedreno@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_khsieh@quicinc.com \
--cc=quic_lliu6@quicinc.com \
--cc=quic_yongmou@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®