mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Babu Moger <bmoger@amd.com>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: tony.luck@intel.com, reinette.chatre@intel.com,
	Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/resctrl: Add io_alloc_min_cbm_all interface for CBM reset
Date: Mon, 10 Nov 2025 10:34:48 -0600	[thread overview]
Message-ID: <bcc8e6d2-8e91-4e91-9dab-f1c00f99c408@amd.com> (raw)
In-Reply-To: <4whfbgq336xfuov4i4nwwrn35ywwlwizuvpdlstmdqzkhvwrq6@eits26xbwyz6>

Hi Aaron,

On 11/7/25 18:19, Aaron Tomlin wrote:
> On Fri, Nov 07, 2025 at 05:08:03PM -0600, Moger, Babu wrote:
>> No, I don’t agree with introducing this new interface.
>>
>> These settings are intended to be modified only by system administrators,
>> not general users.
>>
>> Administrators are already expected to have complete knowledge of the
>> hardware and corresponding configuration details. They also typically rely
>> on benchmark data to determine appropriate settings.
>>
>> Additionally, this approach is not consistent with our existing CBM setting
>> model.
> Hi Babu,
>
> I fully appreciate your point that system administrators are expected to
> have complete knowledge of the hardware configuration. I believe my initial
> motivation may have been unclear, so let me clarify the intention behind
> "io_alloc_min_cbm_all".
>
> The intention of this new interface is not to hide lower-level details from
> the administrator, but rather to simplify a specific, high-overhead
> administration task and prevent human error, which I encountered during
> testing of your series.
>
>
>
> By default, it is my understanding that when I/O allocation CBM is enabled,
> all applicable shared L3 resources typically have their CBM bits set (e.g.,
> ffff). If an administrator wishes to revert to a clean baseline before
> applying a subset of dedicated bits, the manual process requires them to
> not only have knowledge of every single Domain ID
> applicable to the shared L3 resource but manually construct a long,
> error-prone input string.
>
> The objective of "io_alloc_min_cbm_all" is to provide a quick and accurate
> medium to revert this topology-dependent default configuration to the
> minimal supported state, thereby avoiding possible miscalculation or
> omission of a Domain ID in the CBM string. As shown in the usage flow
> below, the new interface drastically reduces the complexity of setting up a
> specific configuration:
>
> # cat /sys/fs/resctrl/info/L3/io_alloc_cbm
> 0=ffff;2=ffff;4=ffff;6=ffff;8=ffff;10=ffff;12=ffff;14=ffff;16=ffff;18=ffff;20=ffff;22=ffff;24=ffff;26=ffff;28=ffff;30=ffff;32=ffff;34=ffff;36=ffff;38=ffff;40=ffff;42=ffff;44=ffff;46=ffff;48=ffff;50=ffff;52=ffff
>
> # echo 0=0;2=0;4=0;6=4;8=4;10=0;12=0;14=0;16=ffff;18=ffff;20=0;22=0;24=0;26=0;28=0;30=0;32=0;34=4;36=0;38=0;40=0;42=0;44=0;46=0;48=0;50=0;52=0 > /sys/fs/resctrl/info/L3/io_alloc_cbm


Does the following option work for you?

# echo "*=0" > /sys/fs/resctrl/info/L3/io_alloc_cbm


Here,|*| represents all domains.


This functionality was introduced when adding support for the*"mbm_event" assign mode* (see [1]).
[1]https://lore.kernel.org/lkml/b894ad853e6757d40da1469bf9fca4c64684df65.1757108044.git.babu.moger@amd.com/ <https://lore.kernel.org/lkml/b894ad853e6757d40da1469bf9fca4c64684df65.1757108044.git.babu.moger@amd.com/> <https://lore.kernel.org/lkml/b894ad853e6757d40da1469bf9fca4c64684df65.1757108044.git.babu.moger@amd.com/>
Also, this needs to be done for all the settings like L3, MBA also SMBA.

# echo "L3:*=f" > /sys/fs/resctrl/schemata

# echo "MB:*=128" > /sys/fs/resctrl/schemata

I’d like to hear from Reinette and Tony if this seems like an acceptable 
approach.

Thanks

Babu


  parent reply	other threads:[~2025-11-10 16:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07  1:23 [PATCH 0/2] " Aaron Tomlin
2025-11-07  1:24 ` [PATCH 1/2] " Aaron Tomlin
2025-11-07 22:02   ` Moger, Babu
2025-11-07 22:25     ` Aaron Tomlin
2025-11-07 23:08       ` Moger, Babu
2025-11-08  0:19         ` Aaron Tomlin
2025-11-08  0:42           ` Luck, Tony
2025-11-10 16:34           ` Babu Moger [this message]
2025-11-10 17:50             ` Luck, Tony
2025-11-10 19:42               ` Babu Moger
2025-11-10 19:56                 ` Luck, Tony
2025-11-10 21:40                   ` Reinette Chatre
2025-11-11  0:41             ` Aaron Tomlin
2025-11-11  0:51               ` Luck, Tony
2025-11-11  1:00                 ` Reinette Chatre
2025-11-11  1:40                   ` Luck, Tony
2025-11-11  2:37                     ` Reinette Chatre
2025-11-11  2:44                     ` Aaron Tomlin
2025-11-11 15:29                       ` Babu Moger
2025-11-11 21:04                         ` Babu Moger
2025-11-11 22:34                           ` Aaron Tomlin
2025-11-11 23:21                             ` Moger, Babu
2025-11-07  1:24 ` [PATCH 2/2] fs/resctrl: resctrl: Return -EINVAL for a missing seq_show implementation Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bcc8e6d2-8e91-4e91-9dab-f1c00f99c408@amd.com \
    --to=bmoger@amd.com \
    --cc=Dave.Martin@arm.com \
    --cc=atomlin@atomlin.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®