mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>, Babu Moger <bmoger@amd.com>,
	"Aaron Tomlin" <atomlin@atomlin.com>
Cc: "Dave.Martin@arm.com" <Dave.Martin@arm.com>,
	"james.morse@arm.com" <james.morse@arm.com>,
	"babu.moger@amd.com" <babu.moger@amd.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86/resctrl: Add io_alloc_min_cbm_all interface for CBM reset
Date: Mon, 10 Nov 2025 13:40:32 -0800	[thread overview]
Message-ID: <f5ac9fea-1c57-419a-befd-1caf946d6005@intel.com> (raw)
In-Reply-To: <SJ1PR11MB60836AB4270419338FBB4D1EFCCEA@SJ1PR11MB6083.namprd11.prod.outlook.com>

Hi Tony,

On 11/10/25 11:56 AM, Luck, Tony wrote:
>>> # echo "L2:*=fff" > schemata
>>>
>>> would work,. But
>>>
>>> # echo "L2:*=ffff" > schemata
>>>
>>> would try to set unimplemented bits on some cores and would fail.
>>
>>
>> I would consider this a user error, as the user is expected to know the
>> supported value for the domain.
>> This situation can occur even now — we simply report the error and exit.
> 
> Babu
> 
> Maybe it was a poor explanation on my part.
> 
> On a hybrid P-core/E-core system with different L2 cache topology schemata
> may look like this (8 L2 domains of one type, 4 L2 domains of other type.
> 
> $ cat schemata
> L2:0=ffff;1=ffff;2=ffff;3=ffff;4=ffff;5=ffff;6=ffff;7=ffff;8=7f;9=7f;10=7f;11=7f
> 
> The proposed wildcard syntax is only useful to set all domains to a value
> that is legal for all domains. It cannot be used for the "reset back to defaults"
> case because different domains have different defaults.

Disabling and re-enabling of io_alloc may be substitute for "reset back to defaults".

The '*' syntax would be useful to initialize domains to minimal allocations ...
assuming all cache instances support the same minimum. 

Would it be an issue if user attempts to assign a value that is not supported to
all domains? resctrl could fail on first invalid bitmask and the last_cmd_status can
then be expected to indicate the details of error.

Reinette

  reply	other threads:[~2025-11-10 21:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07  1:23 [PATCH 0/2] " Aaron Tomlin
2025-11-07  1:24 ` [PATCH 1/2] " Aaron Tomlin
2025-11-07 22:02   ` Moger, Babu
2025-11-07 22:25     ` Aaron Tomlin
2025-11-07 23:08       ` Moger, Babu
2025-11-08  0:19         ` Aaron Tomlin
2025-11-08  0:42           ` Luck, Tony
2025-11-10 16:34           ` Babu Moger
2025-11-10 17:50             ` Luck, Tony
2025-11-10 19:42               ` Babu Moger
2025-11-10 19:56                 ` Luck, Tony
2025-11-10 21:40                   ` Reinette Chatre [this message]
2025-11-11  0:41             ` Aaron Tomlin
2025-11-11  0:51               ` Luck, Tony
2025-11-11  1:00                 ` Reinette Chatre
2025-11-11  1:40                   ` Luck, Tony
2025-11-11  2:37                     ` Reinette Chatre
2025-11-11  2:44                     ` Aaron Tomlin
2025-11-11 15:29                       ` Babu Moger
2025-11-11 21:04                         ` Babu Moger
2025-11-11 22:34                           ` Aaron Tomlin
2025-11-11 23:21                             ` Moger, Babu
2025-11-07  1:24 ` [PATCH 2/2] fs/resctrl: resctrl: Return -EINVAL for a missing seq_show implementation Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5ac9fea-1c57-419a-befd-1caf946d6005@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=atomlin@atomlin.com \
    --cc=babu.moger@amd.com \
    --cc=bmoger@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®