From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: mahua-lenovo-thinkpad-t14s-gen7: Fix LDO voltages
Date: Mon, 9 Nov 2026 14:38:10 +0100 [thread overview]
Message-ID: <bcea16ba-019f-4fbe-bc70-9f9a29461a30@oss.qualcomm.com> (raw)
In-Reply-To: <20261108-t14s-gen7-ldo-voltages-v1-1-e0ad0d528767@oss.qualcomm.com>
On 11/8/26 10:01 PM, Abel Vesa wrote:
> Several LDO voltages do not match what the firmware votes for the
> consumers of these rails (the PMICVREGVOTE entries in the ACPI tables)
> nor the schematics:
>
> L1C E1: 0.832V -> 0.912V (PCIe4/PCIe6 PHYs)
> L2C E1: 1.144V -> 1.2V
> L4C E1: 0.72V -> 0.912V (eUSB2 PHY of the third USB controller)
> L1F E1: 0.88V -> 0.904V
> L2F E1: 0.904V -> 0.88V (the L1F and L2F E1 values were swapped)
> L2H E0: 0.832V -> 0.88V (HS and multiport USB PHYs)
> L7B E0: 2.79V -> 3.072V (eUSB2 repeaters)
>
> Fix them and rename the labels to match.
>
> Fixes: 300f5c59beb2 ("arm64: dts: qcom: Add Lenovo ThinkPad T14s Gen 7")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
Merging the power grid consolidation will fix these too and I'm
hoping Bjorn is eyeing that one, as I would really hate having to
rebase it..
Konrad
prev parent reply other threads:[~2026-11-09 13:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 21:01 Abel Vesa
2026-11-09 13:38 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcea16ba-019f-4fbe-bc70-9f9a29461a30@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®