* [PATCH] arm64: dts: qcom: mahua-lenovo-thinkpad-t14s-gen7: Fix LDO voltages
@ 2026-11-08 21:01 Abel Vesa
2026-11-09 13:38 ` Konrad Dybcio
0 siblings, 1 reply; 2+ messages in thread
From: Abel Vesa @ 2026-11-08 21:01 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel, Abel Vesa
Several LDO voltages do not match what the firmware votes for the
consumers of these rails (the PMICVREGVOTE entries in the ACPI tables)
nor the schematics:
L1C E1: 0.832V -> 0.912V (PCIe4/PCIe6 PHYs)
L2C E1: 1.144V -> 1.2V
L4C E1: 0.72V -> 0.912V (eUSB2 PHY of the third USB controller)
L1F E1: 0.88V -> 0.904V
L2F E1: 0.904V -> 0.88V (the L1F and L2F E1 values were swapped)
L2H E0: 0.832V -> 0.88V (HS and multiport USB PHYs)
L7B E0: 2.79V -> 3.072V (eUSB2 repeaters)
Fix them and rename the labels to match.
Fixes: 300f5c59beb2 ("arm64: dts: qcom: Add Lenovo ThinkPad T14s Gen 7")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
.../qcom/mahua-lenovo-thinkpad-t14s-gen7-lcd.dts | 106 ++++++++++-----------
1 file changed, 53 insertions(+), 53 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7-lcd.dts b/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7-lcd.dts
index 26d6d8285e04..a9204e99b0fb 100644
--- a/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7-lcd.dts
+++ b/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7-lcd.dts
@@ -421,10 +421,10 @@ vreg_l2b_e0_2p9: ldo2 {
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
- vreg_l7b_e0_2p79: ldo7 {
- regulator-name = "vreg_l7b_e0_2p79";
- regulator-min-microvolt = <2790000>;
- regulator-max-microvolt = <2792000>;
+ vreg_l7b_e0_3p07: ldo7 {
+ regulator-name = "vreg_l7b_e0_3p07";
+ regulator-min-microvolt = <3072000>;
+ regulator-max-microvolt = <3072000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
@@ -491,17 +491,17 @@ regulators-1 {
compatible = "qcom,pmcx0102-rpmh-regulators";
qcom,pmic-id = "C_E1";
- vreg_l1c_e1_0p82: ldo1 {
- regulator-name = "vreg_l1c_e1_0p82";
- regulator-min-microvolt = <832000>;
- regulator-max-microvolt = <832000>;
+ vreg_l1c_e1_0p91: ldo1 {
+ regulator-name = "vreg_l1c_e1_0p91";
+ regulator-min-microvolt = <912000>;
+ regulator-max-microvolt = <912000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
- vreg_l2c_e1_1p14: ldo2 {
- regulator-name = "vreg_l2c_e1_1p14";
- regulator-min-microvolt = <1144000>;
- regulator-max-microvolt = <1144000>;
+ vreg_l2c_e1_1p2: ldo2 {
+ regulator-name = "vreg_l2c_e1_1p2";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
@@ -512,10 +512,10 @@ vreg_l3c_e1_0p89: ldo3 {
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
- vreg_l4c_e1_0p72: ldo4 {
- regulator-name = "vreg_l4c_e1_0p72";
- regulator-min-microvolt = <720000>;
- regulator-max-microvolt = <720000>;
+ vreg_l4c_e1_0p91: ldo4 {
+ regulator-name = "vreg_l4c_e1_0p91";
+ regulator-min-microvolt = <912000>;
+ regulator-max-microvolt = <912000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
};
@@ -578,20 +578,20 @@ vreg_s7f_e1_0p3: smps7 {
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
- vreg_l1f_e1_0p88: ldo1 {
- regulator-name = "vreg_l1f_e1_0p88";
- regulator-min-microvolt = <880000>;
- regulator-max-microvolt = <880000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- };
-
- vreg_l2f_e1_0p9: ldo2 {
- regulator-name = "vreg_l2f_e1_0p9";
+ vreg_l1f_e1_0p9: ldo1 {
+ regulator-name = "vreg_l1f_e1_0p9";
regulator-min-microvolt = <904000>;
regulator-max-microvolt = <904000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
+ vreg_l2f_e1_0p88: ldo2 {
+ regulator-name = "vreg_l2f_e1_0p88";
+ regulator-min-microvolt = <880000>;
+ regulator-max-microvolt = <880000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
vreg_l4f_e1_1p2: ldo4 {
regulator-name = "vreg_l4f_e1_1p2";
regulator-min-microvolt = <1200000>;
@@ -611,10 +611,10 @@ vreg_l1h_e0_0p94: ldo1 {
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
- vreg_l2h_e0_0p72: ldo2 {
- regulator-name = "vreg_l2h_e0_0p72";
- regulator-min-microvolt = <832000>;
- regulator-max-microvolt = <832000>;
+ vreg_l2h_e0_0p88: ldo2 {
+ regulator-name = "vreg_l2h_e0_0p88";
+ regulator-min-microvolt = <880000>;
+ regulator-max-microvolt = <880000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
@@ -796,7 +796,7 @@ &mdss_dp3_out {
};
&mdss_dp3_phy {
- vdda-phy-supply = <&vreg_l2f_e1_0p9>;
+ vdda-phy-supply = <&vreg_l2f_e1_0p88>;
vdda-pll-supply = <&vreg_l4f_e1_1p2>;
status = "okay";
@@ -811,7 +811,7 @@ &pcie4 {
};
&pcie4_phy {
- vdda-phy-supply = <&vreg_l1c_e1_0p82>;
+ vdda-phy-supply = <&vreg_l1c_e1_0p91>;
vdda-pll-supply = <&vreg_l4f_e1_1p2>;
status = "okay";
@@ -870,7 +870,7 @@ &pcie6 {
};
&pcie6_phy {
- vdda-phy-supply = <&vreg_l1c_e1_0p82>;
+ vdda-phy-supply = <&vreg_l1c_e1_0p91>;
vdda-pll-supply = <&vreg_l4f_e1_1p2>;
status = "okay";
@@ -950,33 +950,33 @@ right_spkr: speaker@0,1 {
&smb2370_j_e2_eusb2_repeater {
vdd18-supply = <&vreg_l15b_e0_1p8>;
- vdd3-supply = <&vreg_l7b_e0_2p79>;
+ vdd3-supply = <&vreg_l7b_e0_3p07>;
};
&smb2370_k_e2_eusb2_repeater {
vdd18-supply = <&vreg_l15b_e0_1p8>;
- vdd3-supply = <&vreg_l7b_e0_2p79>;
+ vdd3-supply = <&vreg_l7b_e0_3p07>;
};
&tcsr {
- vdda-qrefrpt0-0p9-supply = <&vreg_l2f_e1_0p9>;
- vdda-qrefrpt1-0p9-supply = <&vreg_l2f_e1_0p9>;
- vdda-qrefrpt2-0p9-supply = <&vreg_l2f_e1_0p9>;
- vdda-qrefrpt3-0p9-supply = <&vreg_l2h_e0_0p72>;
- vdda-qrefrpt4-0p9-supply = <&vreg_l2h_e0_0p72>;
- vdda-qrefrpt5-0p9-supply = <&vreg_l2h_e0_0p72>;
- vdda-qrefrx0-0p9-supply = <&vreg_l2f_e1_0p9>;
- vdda-qrefrx1-0p9-supply = <&vreg_l2f_e1_0p9>;
- vdda-qrefrx2-0p9-supply = <&vreg_l2f_e1_0p9>;
- vdda-qrefrx3-0p9-supply = <&vreg_l2h_e0_0p72>;
- vdda-qrefrx4-0p9-supply = <&vreg_l2h_e0_0p72>;
+ vdda-qrefrpt0-0p9-supply = <&vreg_l2f_e1_0p88>;
+ vdda-qrefrpt1-0p9-supply = <&vreg_l2f_e1_0p88>;
+ vdda-qrefrpt2-0p9-supply = <&vreg_l2f_e1_0p88>;
+ vdda-qrefrpt3-0p9-supply = <&vreg_l2h_e0_0p88>;
+ vdda-qrefrpt4-0p9-supply = <&vreg_l2h_e0_0p88>;
+ vdda-qrefrpt5-0p9-supply = <&vreg_l2h_e0_0p88>;
+ vdda-qrefrx0-0p9-supply = <&vreg_l2f_e1_0p88>;
+ vdda-qrefrx1-0p9-supply = <&vreg_l2f_e1_0p88>;
+ vdda-qrefrx2-0p9-supply = <&vreg_l2f_e1_0p88>;
+ vdda-qrefrx3-0p9-supply = <&vreg_l2h_e0_0p88>;
+ vdda-qrefrx4-0p9-supply = <&vreg_l2h_e0_0p88>;
vdda-qrefrx5-0p9-supply = <&vreg_l3f_e0_0p91>;
vdda-qreftx0-0p9-supply = <&vreg_l3f_e0_0p91>;
vdda-qreftx0-1p2-supply = <&vreg_l4h_e0_1p2>;
- vdda-qreftx1-0p9-supply = <&vreg_l1f_e1_0p88>;
+ vdda-qreftx1-0p9-supply = <&vreg_l1f_e1_0p9>;
vdda-refgen3-0p9-supply = <&vreg_l2f_e0_0p94>;
vdda-refgen3-1p2-supply = <&vreg_l4h_e0_1p2>;
- vdda-refgen4-0p9-supply = <&vreg_l1f_e1_0p88>;
+ vdda-refgen4-0p9-supply = <&vreg_l1f_e1_0p9>;
vdda-refgen4-1p2-supply = <&vreg_l4f_e1_1p2>;
};
@@ -1203,7 +1203,7 @@ &usb_mp {
};
&usb_mp_hsphy0 {
- vdd-supply = <&vreg_l2h_e0_0p72>;
+ vdd-supply = <&vreg_l2h_e0_0p88>;
vdda12-supply = <&vreg_l4h_e0_1p2>;
phys = <&ptn3222_0>;
@@ -1212,7 +1212,7 @@ &usb_mp_hsphy0 {
};
&usb_mp_hsphy1 {
- vdd-supply = <&vreg_l2h_e0_0p72>;
+ vdd-supply = <&vreg_l2h_e0_0p88>;
vdda12-supply = <&vreg_l4h_e0_1p2>;
phys = <&ptn3222_1>;
@@ -1221,7 +1221,7 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l2h_e0_0p72>;
+ vdda-phy-supply = <&vreg_l2h_e0_0p88>;
vdda-pll-supply = <&vreg_l4h_e0_1p2>;
refgen-supply = <&vreg_l4f_e1_1p2>;
@@ -1229,7 +1229,7 @@ &usb_mp_qmpphy0 {
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l2h_e0_0p72>;
+ vdda-phy-supply = <&vreg_l2h_e0_0p88>;
vdda-pll-supply = <&vreg_l4h_e0_1p2>;
refgen-supply = <&vreg_l4f_e1_1p2>;
@@ -1243,7 +1243,7 @@ &usb_hs {
};
&usb_hs_phy {
- vdd-supply = <&vreg_l2h_e0_0p72>;
+ vdd-supply = <&vreg_l2h_e0_0p88>;
vdda12-supply = <&vreg_l4h_e0_1p2>;
phys = <&ptn3222_cam>;
@@ -1263,7 +1263,7 @@ &usb_2 {
};
&usb_2_hsphy {
- vdd-supply = <&vreg_l4c_e1_0p72>;
+ vdd-supply = <&vreg_l4c_e1_0p91>;
vdda12-supply = <&vreg_l4f_e1_1p2>;
phys = <&ptn3222_fpr>;
---
base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b
change-id: 20261108-t14s-gen7-ldo-voltages-d57453f9d754
Best regards,
--
Abel
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: qcom: mahua-lenovo-thinkpad-t14s-gen7: Fix LDO voltages
2026-11-08 21:01 [PATCH] arm64: dts: qcom: mahua-lenovo-thinkpad-t14s-gen7: Fix LDO voltages Abel Vesa
@ 2026-11-09 13:38 ` Konrad Dybcio
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2026-11-09 13:38 UTC (permalink / raw)
To: Abel Vesa, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla
Cc: linux-arm-msm, devicetree, linux-kernel
On 11/8/26 10:01 PM, Abel Vesa wrote:
> Several LDO voltages do not match what the firmware votes for the
> consumers of these rails (the PMICVREGVOTE entries in the ACPI tables)
> nor the schematics:
>
> L1C E1: 0.832V -> 0.912V (PCIe4/PCIe6 PHYs)
> L2C E1: 1.144V -> 1.2V
> L4C E1: 0.72V -> 0.912V (eUSB2 PHY of the third USB controller)
> L1F E1: 0.88V -> 0.904V
> L2F E1: 0.904V -> 0.88V (the L1F and L2F E1 values were swapped)
> L2H E0: 0.832V -> 0.88V (HS and multiport USB PHYs)
> L7B E0: 2.79V -> 3.072V (eUSB2 repeaters)
>
> Fix them and rename the labels to match.
>
> Fixes: 300f5c59beb2 ("arm64: dts: qcom: Add Lenovo ThinkPad T14s Gen 7")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
Merging the power grid consolidation will fix these too and I'm
hoping Bjorn is eyeing that one, as I would really hate having to
rebase it..
Konrad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-09 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-08 21:01 [PATCH] arm64: dts: qcom: mahua-lenovo-thinkpad-t14s-gen7: Fix LDO voltages Abel Vesa
2026-11-09 13:38 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®