From: Markus Elfring <Markus.Elfring@web.de>
To: kunyu@nfschina.com, Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Li zeming <zeming@nfschina.com>
Subject: Re: [PATCH] sched: core: Remove unnecessary ‘NULL’ values from pending
Date: Tue, 28 May 2024 16:09:39 +0200 [thread overview]
Message-ID: <bcf08289-58a2-47d1-8080-6105dafb7929@web.de> (raw)
In-Reply-To: <20240528064532.42532-1-kunyu@nfschina.com>
> pending is assigned first, so it does not need to initialize the
> assignment.
Would a wording approach (like the following) be a bit nicer?
The variable “pending” will eventually be set to an appropriate pointer
a bit later. Thus omit the explicit initialisation at the beginning.
> Signed-off-by: kunyu <kunyu@nfschina.com>
Can the Developer's Certificate of Origin become clearer another bit?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc1#n438
How do you think about to use the summary phrase
“Delete an unnecessary initialisation in affine_move_task()”?
Regards,
Markus
next prev parent reply other threads:[~2024-05-28 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 6:45 kunyu
2024-05-28 14:09 ` Markus Elfring [this message]
2024-05-29 5:39 ` K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcf08289-58a2-47d1-8080-6105dafb7929@web.de \
--to=markus.elfring@web.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kunyu@nfschina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®