From: Andrew Lunn <andrew@lunn.ch>
To: Qingfang Deng <dqfext@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Felix Fietkau <nbd@nbd.name>
Subject: Re: [RFC PATCH net-next] ppp: enable TX scatter-gather
Date: Thu, 4 Sep 2025 14:51:24 +0200 [thread overview]
Message-ID: <bcf9c1c9-996a-4fd4-902c-3bf797ca688d@lunn.ch> (raw)
In-Reply-To: <20250904021328.24329-1-dqfext@gmail.com>
> diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
> index f9f0f16c41d1..3bf37871a1aa 100644
> --- a/drivers/net/ppp/ppp_generic.c
> +++ b/drivers/net/ppp/ppp_generic.c
> @@ -1710,6 +1710,12 @@ pad_compress_skb(struct ppp *ppp, struct sk_buff *skb)
> ppp->xcomp->comp_extra + ppp->dev->hard_header_len;
> int compressor_skb_size = ppp->dev->mtu +
> ppp->xcomp->comp_extra + PPP_HDRLEN;
> + /* Until we fix the compressor need to make sure data portion is
> + * linear.
> + */
> + if (skb_linearize(skb))
> + return NULL;
The word 'fix' suggest something is broken. I don't think that is
true, its just a limitation of the compressor. Please avoid 'fix'.
Andrew
prev parent reply other threads:[~2025-09-04 12:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 2:13 Qingfang Deng
2025-09-04 12:51 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcf9c1c9-996a-4fd4-902c-3bf797ca688d@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®