mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: gcc: ipq5332: Use floor ops for SDCC clocks
@ 2023-05-08 16:31 Kathiravan T
  2023-05-08 16:40 ` Konrad Dybcio
  2023-05-25  4:54 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Kathiravan T @ 2023-05-08 16:31 UTC (permalink / raw)
  To: andersson, agross, konrad.dybcio, mturquette, sboyd,
	quic_kathirav, linux-arm-msm, linux-clk, linux-kernel

SDCC clocks must be rounded down to avoid overclocking the controller.

Fixes: 3d89d52970fd ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5332 SoC")
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
 drivers/clk/qcom/gcc-ipq5332.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
index bdb4a0a11d07..1ad23aa8aa5a 100644
--- a/drivers/clk/qcom/gcc-ipq5332.c
+++ b/drivers/clk/qcom/gcc-ipq5332.c
@@ -963,7 +963,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = {
 		.name = "gcc_sdcc1_apps_clk_src",
 		.parent_data = gcc_parent_data_9,
 		.num_parents = ARRAY_SIZE(gcc_parent_data_9),
-		.ops = &clk_rcg2_ops,
+		.ops = &clk_rcg2_floor_ops,
 	},
 };
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: gcc: ipq5332: Use floor ops for SDCC clocks
  2023-05-08 16:31 [PATCH] clk: qcom: gcc: ipq5332: Use floor ops for SDCC clocks Kathiravan T
@ 2023-05-08 16:40 ` Konrad Dybcio
  2023-05-25  4:54 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-05-08 16:40 UTC (permalink / raw)
  To: Kathiravan T, andersson, agross, mturquette, sboyd,
	linux-arm-msm, linux-clk, linux-kernel



On 8.05.2023 18:31, Kathiravan T wrote:
> SDCC clocks must be rounded down to avoid overclocking the controller.
> 
> Fixes: 3d89d52970fd ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5332 SoC")
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  drivers/clk/qcom/gcc-ipq5332.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
> index bdb4a0a11d07..1ad23aa8aa5a 100644
> --- a/drivers/clk/qcom/gcc-ipq5332.c
> +++ b/drivers/clk/qcom/gcc-ipq5332.c
> @@ -963,7 +963,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = {
>  		.name = "gcc_sdcc1_apps_clk_src",
>  		.parent_data = gcc_parent_data_9,
>  		.num_parents = ARRAY_SIZE(gcc_parent_data_9),
> -		.ops = &clk_rcg2_ops,
> +		.ops = &clk_rcg2_floor_ops,
>  	},
>  };
>  

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: gcc: ipq5332: Use floor ops for SDCC clocks
  2023-05-08 16:31 [PATCH] clk: qcom: gcc: ipq5332: Use floor ops for SDCC clocks Kathiravan T
  2023-05-08 16:40 ` Konrad Dybcio
@ 2023-05-25  4:54 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-05-25  4:54 UTC (permalink / raw)
  To: Kathiravan T, linux-kernel, agross, linux-arm-msm, linux-clk,
	mturquette, konrad.dybcio, sboyd

On Mon, 8 May 2023 22:01:45 +0530, Kathiravan T wrote:
> SDCC clocks must be rounded down to avoid overclocking the controller.
> 
> 

Applied, thanks!

[1/1] clk: qcom: gcc: ipq5332: Use floor ops for SDCC clocks
      commit: a30e62bf6bf4d3230fa9164c7e174e32b9be7ba5

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-25  4:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-08 16:31 [PATCH] clk: qcom: gcc: ipq5332: Use floor ops for SDCC clocks Kathiravan T
2023-05-08 16:40 ` Konrad Dybcio
2023-05-25  4:54 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®