* [PATCH] drm/amd/display: fix NULL dereference
@ 2023-11-14 6:36 José Pekkarinen
2023-11-14 14:21 ` Hamza Mahfooz
0 siblings, 1 reply; 2+ messages in thread
From: José Pekkarinen @ 2023-11-14 6:36 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, skhan
Cc: José Pekkarinen, airlied, daniel, Wayne.Lin, qingqing.zhuo,
lyude, aurabindo.pillai, sungjoon.kim, srinivasan.shanmugam,
hamza.mahfooz, mikita.lipski, amd-gfx, dri-devel, linux-kernel,
linux-kernel-mentees
The following patch will fix a minor issue where a debug message is
referencing an struct that has just being checked whether is null or
not. This has been noticed by using coccinelle, in the following output:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c:540:25-29: ERROR: aconnector is NULL but dereferenced.
Fixes: 5d72e247e58c9 ("drm/amd/display: switch DC over to the new DRM logging macros")
Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
index ed784cf27d39..7048dab5e356 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
@@ -537,8 +537,7 @@ bool dm_helpers_dp_read_dpcd(
struct amdgpu_dm_connector *aconnector = link->priv;
if (!aconnector) {
- drm_dbg_dp(aconnector->base.dev,
- "Failed to find connector for link!\n");
+ DRM_ERROR("Failed to find connector for link!");
return false;
}
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: fix NULL dereference
2023-11-14 6:36 [PATCH] drm/amd/display: fix NULL dereference José Pekkarinen
@ 2023-11-14 14:21 ` Hamza Mahfooz
0 siblings, 0 replies; 2+ messages in thread
From: Hamza Mahfooz @ 2023-11-14 14:21 UTC (permalink / raw)
To: José Pekkarinen, harry.wentland, sunpeng.li,
Rodrigo.Siqueira, alexander.deucher, christian.koenig,
Xinhui.Pan, skhan
Cc: airlied, daniel, Wayne.Lin, qingqing.zhuo, lyude,
aurabindo.pillai, sungjoon.kim, srinivasan.shanmugam,
mikita.lipski, amd-gfx, dri-devel, linux-kernel,
linux-kernel-mentees
On 11/14/23 01:36, José Pekkarinen wrote:
> The following patch will fix a minor issue where a debug message is
> referencing an struct that has just being checked whether is null or
> not. This has been noticed by using coccinelle, in the following output:
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c:540:25-29: ERROR: aconnector is NULL but dereferenced.
>
> Fixes: 5d72e247e58c9 ("drm/amd/display: switch DC over to the new DRM logging macros")
> Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index ed784cf27d39..7048dab5e356 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -537,8 +537,7 @@ bool dm_helpers_dp_read_dpcd(
> struct amdgpu_dm_connector *aconnector = link->priv;
>
> if (!aconnector) {
> - drm_dbg_dp(aconnector->base.dev,
> - "Failed to find connector for link!\n");
> + DRM_ERROR("Failed to find connector for link!");
I would prefer a patch that drops this error message entirely since
it's not particularly useful. As, it's only possible before hw init
(and at that point it's expected).
> return false;
> }
>
--
Hamza
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-14 14:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-14 6:36 [PATCH] drm/amd/display: fix NULL dereference José Pekkarinen
2023-11-14 14:21 ` Hamza Mahfooz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®