From: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
To: Hungyu Lin <dennylin0707@gmail.com>,
vikash.garodia@oss.qualcomm.com, bod@kernel.org,
mchehab@kernel.org
Cc: abhinav.kumar@linux.dev, stefan.schmidt@linaro.org,
hverkuil@kernel.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: qcom: iris: cancel sys error work on driver removal
Date: Mon, 8 Jun 2026 11:53:19 +0530 [thread overview]
Message-ID: <bd701f9d-d54a-2898-3c7c-e2287a1be4d0@oss.qualcomm.com> (raw)
In-Reply-To: <20260604054708.42426-1-dennylin0707@gmail.com>
On 6/4/2026 11:17 AM, Hungyu Lin wrote:
> Cancel sys_error_handler before tearing down the driver.
>
> The delayed work may still be pending when iris_remove()
> runs. Since iris_core is allocated with devm_kzalloc(),
> allowing the work to execute after driver removal could
> result in accessing freed memory.
>
> Fixes: fb583a214337 ("media: iris: introduce host firmware interface with necessary hooks")
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> drivers/media/platform/qcom/iris/iris_probe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c
> index ddaacda523ec..1a740542bc81 100644
> --- a/drivers/media/platform/qcom/iris/iris_probe.c
> +++ b/drivers/media/platform/qcom/iris/iris_probe.c
> @@ -192,6 +192,8 @@ static void iris_remove(struct platform_device *pdev)
> if (!core)
> return;
>
> + cancel_delayed_work_sync(&core->sys_error_handler);
> +
> iris_core_deinit(core);
>
> video_unregister_device(core->vdev_dec);
Reviewed-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
prev parent reply other threads:[~2026-06-08 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 5:47 Hungyu Lin
2026-06-07 20:44 ` Dmitry Baryshkov
2026-06-08 6:23 ` Vishnu Reddy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd701f9d-d54a-2898-3c7c-e2287a1be4d0@oss.qualcomm.com \
--to=busanna.reddy@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=dennylin0707@gmail.com \
--cc=hverkuil@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stefan.schmidt@linaro.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®