From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Inochi Amaoto <inochiama@outlook.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Chen Wang <unicorn_wang@outlook.com>,
Jisheng Zhang <jszhang@kernel.org>,
qiujingbao.dlmu@gmail.com, dlan@gentoo.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: clock: sophgo: Add CV1800 bindings
Date: Tue, 5 Dec 2023 12:46:13 +0100 [thread overview]
Message-ID: <bd878b2a-0704-49dc-a991-e9660940cf08@linaro.org> (raw)
In-Reply-To: <IA1PR20MB4953F0086FB77F8DC46C8095BB85A@IA1PR20MB4953.namprd20.prod.outlook.com>
On 05/12/2023 12:24, Inochi Amaoto wrote:
>>
>> On 05/12/2023 10:43, Inochi Amaoto wrote:
>>> Add definition for the clock controller of the CV1800 series SoC.
>>>
>>
>> If there is going to be resend:
>>
>> A nit, subject: drop second/last, redundant "bindings". The
>> "dt-bindings" prefix is already stating that these are bindings.
>>
>
> OK, thanks.
>
>>> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
>>> Link: https://github.com/milkv-duo/duo-files/blob/main/hardware/CV1800B/CV1800B-CV1801B-Preliminary-Datasheet-full-en.pdf
>>> ---
>>
>>
>>> diff --git a/include/dt-bindings/clock/sophgo,cv1800.h b/include/dt-bindings/clock/sophgo,cv1800.h
>>> new file mode 100644
>>> index 000000000000..6a9897b34978
>>> --- /dev/null
>>> +++ b/include/dt-bindings/clock/sophgo,cv1800.h
>>> @@ -0,0 +1,174 @@
>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>
>> Why not dual-license? Checkpatch complains about this, so are you sure
>> you run it?
>>
>
> Yes, I have run it. It seems I misunderstood the warning message.
> It only tells me it should be (GPL-2.0-only OR .*). And I think
> GPL-2.0 is ok. Thanks for your explanation, I will fix this soon.
GPL-2.0 still does not have OR.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-05 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 9:42 [PATCH 0/4] riscv: sophgo: add clock support for Sophgo CV1800 SoCs Inochi Amaoto
2023-12-05 9:43 ` [PATCH 1/4] dt-bindings: clock: sophgo: Add CV1800 bindings Inochi Amaoto
2023-12-05 11:17 ` Krzysztof Kozlowski
2023-12-05 11:24 ` Inochi Amaoto
2023-12-05 11:46 ` Krzysztof Kozlowski [this message]
2023-12-05 9:43 ` [PATCH 2/4] clk: sophgo: Add CV1800 series clock controller driver Inochi Amaoto
2023-12-06 15:39 ` kernel test robot
2023-12-05 9:43 ` [PATCH 3/4] riscv: dts: sophgo: add clock generator for Sophgo CV1800 series SoC Inochi Amaoto
2023-12-05 9:43 ` [PATCH 4/4] riscv: dts: sophgo: add uart clock " Inochi Amaoto
2023-12-05 11:02 ` [PATCH 0/4] riscv: sophgo: add clock support for Sophgo CV1800 SoCs Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd878b2a-0704-49dc-a991-e9660940cf08@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=qiujingbao.dlmu@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®