From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Jason-JH Lin <jason-jh.lin@mediatek.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Nicolas Dufresne <nicolas@ndufresne.ca>,
Nancy Lin <nancy.lin@mediatek.com>,
Singo Chang <singo.chang@mediatek.com>,
Paul-PL Chen <paul-pl.chen@mediatek.com>,
Moudy Ho <moudy.ho@mediatek.com>,
Xiandong Wang <xiandong.wang@mediatek.com>,
Sirius Wang <sirius.wang@mediatek.com>,
Fei Shao <fshao@chromium.org>, Chen-yu Tsai <wenst@chromium.org>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v8 02/20] mailbox: mtk-cmdq: Refine DMA address handling for the command buffer
Date: Mon, 20 Oct 2025 12:04:44 +0200 [thread overview]
Message-ID: <bd9a2670-008a-4e0a-9ad2-90bdad22778d@collabora.com> (raw)
In-Reply-To: <20251017065028.1676930-3-jason-jh.lin@mediatek.com>
Il 17/10/25 08:44, Jason-JH Lin ha scritto:
> GCE can only fetch the command buffer address from a 32-bit register.
> Some SoCs support a 35-bit command buffer address for GCE, which
> requires a right shift of 3 bits before setting the address into
> the 32-bit register. A comment has been added to the header of
> cmdq_get_shift_pa() to explain this requirement.
>
> To prevent the GCE command buffer address from being DMA mapped beyond
> its supported bit range, the DMA bit mask for the device is set during
> initialization.
>
> Additionally, to ensure the correct shift is applied when setting or
> reading the register that stores the GCE command buffer address,
> new APIs, cmdq_convert_gce_addr() and cmdq_revert_gce_addr(), have
> been introduced for consistent operations on this register.
>
> The variable type for the command buffer address has been standardized
> to dma_addr_t to prevent handling issues caused by type mismatches.
>
> Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")
> Signed-off-by: Jason-JH Lin <jason-jh.lin@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2025-10-20 10:04 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 6:44 [PATCH v8 00/20] Add GCE support for MT8196 Jason-JH Lin
2025-10-17 6:44 ` [PATCH v8 01/20] arm64: dts: mediatek: Add GCE header " Jason-JH Lin
2025-10-20 9:46 ` AngeloGioacchino Del Regno
2025-10-17 6:44 ` [PATCH v8 02/20] mailbox: mtk-cmdq: Refine DMA address handling for the command buffer Jason-JH Lin
2025-10-20 10:04 ` AngeloGioacchino Del Regno [this message]
2025-10-17 6:44 ` [PATCH v8 03/20] mailbox: mtk-cmdq: Add cmdq private data to cmdq_pkt for generating instruction Jason-JH Lin
2025-10-20 10:04 ` AngeloGioacchino Del Regno
2025-10-17 6:44 ` [PATCH v8 04/20] soc: mediatek: mtk-cmdq: Add cmdq_get_mbox_priv() in cmdq_pkt_create() Jason-JH Lin
2025-10-17 6:44 ` [PATCH v8 05/20] soc: mediatek: mtk-cmdq: Add cmdq_pkt_jump_rel_temp() for removing shift_pa Jason-JH Lin
2025-10-17 6:44 ` [PATCH v8 06/20] mailbox: mtk-cmdq: Add GCE hardware virtualization configuration Jason-JH Lin
2025-10-17 6:44 ` [PATCH v8 07/20] mailbox: mtk-cmdq: Add mminfra_offset configuration for DRAM transaction Jason-JH Lin
2025-10-20 10:04 ` AngeloGioacchino Del Regno
2025-10-17 6:44 ` [PATCH v8 08/20] mailbox: mtk-cmdq: Add driver data to support for MT8196 Jason-JH Lin
2025-10-17 6:44 ` [PATCH v8 09/20] soc: mediatek: mtk-cmdq: Add pa_base parsing for hardware without subsys ID support Jason-JH Lin
2025-10-17 6:44 ` [PATCH v8 10/20] soc: mediatek: mtk-cmdq: Extend cmdq_pkt_write API for SoCs without subsys ID Jason-JH Lin
2025-10-20 10:04 ` AngeloGioacchino Del Regno
2025-10-23 4:03 ` Jason-JH Lin (林睿祥)
2025-10-29 11:00 ` AngeloGioacchino Del Regno
2025-10-17 6:44 ` [PATCH v8 11/20] soc: mediatek: mtk-cmdq: Add mminfra_offset adjustment for DRAM addresses Jason-JH Lin
2025-10-17 6:44 ` [PATCH v8 12/20] soc: mediatek: Use reg_write function pointer for subsys ID compatibility Jason-JH Lin
2025-10-17 6:44 ` [PATCH v8 13/20] drm/mediatek:Use " Jason-JH Lin
2025-10-20 10:04 ` AngeloGioacchino Del Regno
2025-10-28 5:47 ` CK Hu (胡俊光)
2025-10-17 6:44 ` [PATCH v8 14/20] media: platform: mtk-mdp3: Refactor CMDQ writes for CMDQ API change Jason-JH Lin
2025-10-20 10:04 ` AngeloGioacchino Del Regno
2025-10-17 6:44 ` [PATCH v8 15/20] media: platform: mtk-mdp3: Change cmdq_pkt_jump_rel() to cmdq_pkt_jump_rel_temp() Jason-JH Lin
2025-10-20 10:04 ` AngeloGioacchino Del Regno
2025-10-17 6:44 ` [PATCH v8 16/20] soc: mediatek: mtk-cmdq: Remove shift_pa parameter from cmdq_pkt_jump() Jason-JH Lin
2025-10-20 10:04 ` AngeloGioacchino Del Regno
2025-10-17 6:44 ` [PATCH v8 17/20] media: platform: mtk-mdp3: Use cmdq_pkt_jump_rel() without shift_pa Jason-JH Lin
2025-10-20 10:04 ` AngeloGioacchino Del Regno
2025-10-17 6:44 ` [PATCH v8 18/20] soc: mediatek: mtk-cmdq: Remove cmdq_pkt_jump() and cmdq_pkt_jump_rel_temp() Jason-JH Lin
2025-10-20 10:04 ` AngeloGioacchino Del Regno
2025-10-17 6:44 ` [PATCH v8 19/20] soc: mediatek: mtk-cmdq: Remove cmdq_pkt_write() and cmdq_pkt_write_mask() Jason-JH Lin
2025-10-20 10:04 ` AngeloGioacchino Del Regno
2025-10-17 6:44 ` [PATCH v8 20/20] mailbox: mtk-cmdq: Remove unsued cmdq_get_shift_pa() Jason-JH Lin
2025-10-20 10:04 ` AngeloGioacchino Del Regno
2025-10-20 10:04 ` [PATCH v8 00/20] Add GCE support for MT8196 AngeloGioacchino Del Regno
2025-10-21 15:32 ` Jason-JH Lin (林睿祥)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd9a2670-008a-4e0a-9ad2-90bdad22778d@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fshao@chromium.org \
--cc=jason-jh.lin@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=moudy.ho@mediatek.com \
--cc=nancy.lin@mediatek.com \
--cc=nicolas@ndufresne.ca \
--cc=paul-pl.chen@mediatek.com \
--cc=robh@kernel.org \
--cc=singo.chang@mediatek.com \
--cc=sirius.wang@mediatek.com \
--cc=wenst@chromium.org \
--cc=xiandong.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®