* [PATCH v2] clk: tegra: probe deferral error reporting
@ 2018-08-14 9:18 Marcel Ziswiler
2018-08-18 12:45 ` Stefan Agner
2018-10-16 22:30 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Marcel Ziswiler @ 2018-08-14 9:18 UTC (permalink / raw)
To: linux-tegra, linux-kernel
Cc: Stephen Boyd, Stefan Agner, Peter Geis, Marcel Ziswiler,
Thierry Reding, Prashant Gaikwad, Peter De Schrijver,
Jonathan Hunter, Michael Turquette, linux-clk
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Actually report the error code from devm_regulator_get() which may as
well just be a probe deferral.
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
Changes in v2:
- Silence probe deferral as discussed between Peter, Stefan and Stephen.
- Fix line over 80 characters as reported by checkpatch.
drivers/clk/tegra/clk-dfll.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c
index 48ee43734e05..ebb0e1b6bf01 100644
--- a/drivers/clk/tegra/clk-dfll.c
+++ b/drivers/clk/tegra/clk-dfll.c
@@ -1609,8 +1609,12 @@ int tegra_dfll_register(struct platform_device *pdev,
td->vdd_reg = devm_regulator_get(td->dev, "vdd-cpu");
if (IS_ERR(td->vdd_reg)) {
- dev_err(td->dev, "couldn't get vdd_cpu regulator\n");
- return PTR_ERR(td->vdd_reg);
+ ret = PTR_ERR(td->vdd_reg);
+ if (ret != -EPROBE_DEFER)
+ dev_err(td->dev, "couldn't get vdd_cpu regulator: %d\n",
+ ret);
+
+ return ret;
}
td->dvco_rst = devm_reset_control_get(td->dev, "dvco");
--
2.14.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] clk: tegra: probe deferral error reporting
2018-08-14 9:18 [PATCH v2] clk: tegra: probe deferral error reporting Marcel Ziswiler
@ 2018-08-18 12:45 ` Stefan Agner
2018-10-16 22:30 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Agner @ 2018-08-18 12:45 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: linux-tegra, linux-kernel, Stephen Boyd, Peter Geis,
Marcel Ziswiler, Thierry Reding, Prashant Gaikwad,
Peter De Schrijver, Jonathan Hunter, Michael Turquette,
linux-clk
On 14.08.2018 11:18, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Actually report the error code from devm_regulator_get() which may as
> well just be a probe deferral.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Reviewed-by: Stefan Agner <stefan@agner.ch>
>
> ---
>
> Changes in v2:
> - Silence probe deferral as discussed between Peter, Stefan and Stephen.
> - Fix line over 80 characters as reported by checkpatch.
>
> drivers/clk/tegra/clk-dfll.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c
> index 48ee43734e05..ebb0e1b6bf01 100644
> --- a/drivers/clk/tegra/clk-dfll.c
> +++ b/drivers/clk/tegra/clk-dfll.c
> @@ -1609,8 +1609,12 @@ int tegra_dfll_register(struct platform_device *pdev,
>
> td->vdd_reg = devm_regulator_get(td->dev, "vdd-cpu");
> if (IS_ERR(td->vdd_reg)) {
> - dev_err(td->dev, "couldn't get vdd_cpu regulator\n");
> - return PTR_ERR(td->vdd_reg);
> + ret = PTR_ERR(td->vdd_reg);
> + if (ret != -EPROBE_DEFER)
> + dev_err(td->dev, "couldn't get vdd_cpu regulator: %d\n",
> + ret);
> +
> + return ret;
> }
>
> td->dvco_rst = devm_reset_control_get(td->dev, "dvco");
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] clk: tegra: probe deferral error reporting
2018-08-14 9:18 [PATCH v2] clk: tegra: probe deferral error reporting Marcel Ziswiler
2018-08-18 12:45 ` Stefan Agner
@ 2018-10-16 22:30 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2018-10-16 22:30 UTC (permalink / raw)
To: Marcel Ziswiler, linux-kernel, linux-tegra
Cc: Stefan Agner, Peter Geis, Marcel Ziswiler, Thierry Reding,
Prashant Gaikwad, Peter De Schrijver, Jonathan Hunter,
Michael Turquette, linux-clk
Quoting Marcel Ziswiler (2018-08-14 02:18:05)
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Actually report the error code from devm_regulator_get() which may as
> well just be a probe deferral.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-16 22:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-14 9:18 [PATCH v2] clk: tegra: probe deferral error reporting Marcel Ziswiler
2018-08-18 12:45 ` Stefan Agner
2018-10-16 22:30 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®