From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Ryan Lee <ryan.lee.analog@gmail.com>,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, steve@sk2.org, ryans.lee@analog.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: max98373: Removing 0x203E from the volatile reg
Date: Mon, 25 Jul 2022 10:03:23 -0500 [thread overview]
Message-ID: <bdaec1b0-1385-b376-7640-61d363c9b009@linux.intel.com> (raw)
In-Reply-To: <20220723015220.4169-1-ryans.lee@analog.com>
On 7/22/22 20:52, Ryan Lee wrote:
> The 0x203E speaker gain register should be non-volatile.
> This register value was not able to be synced because it was marked as
> volatile.
>
> Signed-off-by: Ryan Lee <ryans.lee@analog.com>
> ---
> sound/soc/codecs/max98373-i2c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/codecs/max98373-i2c.c b/sound/soc/codecs/max98373-i2c.c
> index 4fe065ece17c..3e04c7f0cce4 100644
> --- a/sound/soc/codecs/max98373-i2c.c
> +++ b/sound/soc/codecs/max98373-i2c.c
> @@ -442,7 +442,6 @@ static bool max98373_volatile_reg(struct device *dev, unsigned int reg)
> {
> switch (reg) {
> case MAX98373_R2000_SW_RESET ... MAX98373_R2009_INT_FLAG3:
> - case MAX98373_R203E_AMP_PATH_GAIN:
That register isn't declared as volatile for the SoundWire case so that
sounds like a good fix
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> case MAX98373_R2054_MEAS_ADC_PVDD_CH_READBACK:
> case MAX98373_R2055_MEAS_ADC_THERM_CH_READBACK:
> case MAX98373_R20B6_BDE_CUR_STATE_READBACK:
next prev parent reply other threads:[~2022-07-25 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 1:52 Ryan Lee
2022-07-25 15:03 ` Pierre-Louis Bossart [this message]
2022-07-26 10:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdaec1b0-1385-b376-7640-61d363c9b009@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ryan.lee.analog@gmail.com \
--cc=ryans.lee@analog.com \
--cc=steve@sk2.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®