[PATCH] ASoC: max98373: Removing 0x203E from the volatile reg

[PATCH] ASoC: max98373: Removing 0x203E from the volatile reg

[Ryan Lee]

The 0x203E speaker gain register should be non-volatile.
This register value was not able to be synced because it was marked as
volatile.

Signed-off-by: Ryan Lee <ryans.lee@analog.com>
---
 sound/soc/codecs/max98373-i2c.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/max98373-i2c.c b/sound/soc/codecs/max98373-i2c.c
index 4fe065ece17c..3e04c7f0cce4 100644
--- a/sound/soc/codecs/max98373-i2c.c
+++ b/sound/soc/codecs/max98373-i2c.c
@@ -442,7 +442,6 @@ static bool max98373_volatile_reg(struct device *dev, unsigned int reg)
 {
 	switch (reg) {
 	case MAX98373_R2000_SW_RESET ... MAX98373_R2009_INT_FLAG3:
-	case MAX98373_R203E_AMP_PATH_GAIN:
 	case MAX98373_R2054_MEAS_ADC_PVDD_CH_READBACK:
 	case MAX98373_R2055_MEAS_ADC_THERM_CH_READBACK:
 	case MAX98373_R20B6_BDE_CUR_STATE_READBACK:
-- 
2.37.0

Re: [PATCH] ASoC: max98373: Removing 0x203E from the volatile reg

[Pierre-Louis Bossart]

On 7/22/22 20:52, Ryan Lee wrote:
> The 0x203E speaker gain register should be non-volatile.
> This register value was not able to be synced because it was marked as
> volatile.
> 
> Signed-off-by: Ryan Lee <ryans.lee@analog.com>
> ---
>  sound/soc/codecs/max98373-i2c.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/max98373-i2c.c b/sound/soc/codecs/max98373-i2c.c
> index 4fe065ece17c..3e04c7f0cce4 100644
> --- a/sound/soc/codecs/max98373-i2c.c
> +++ b/sound/soc/codecs/max98373-i2c.c
> @@ -442,7 +442,6 @@ static bool max98373_volatile_reg(struct device *dev, unsigned int reg)
>  {
>  	switch (reg) {
>  	case MAX98373_R2000_SW_RESET ... MAX98373_R2009_INT_FLAG3:
> -	case MAX98373_R203E_AMP_PATH_GAIN:

That register isn't declared as volatile for the SoundWire case so that
sounds like a good fix

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

>  	case MAX98373_R2054_MEAS_ADC_PVDD_CH_READBACK:
>  	case MAX98373_R2055_MEAS_ADC_THERM_CH_READBACK:
>  	case MAX98373_R20B6_BDE_CUR_STATE_READBACK:

Re: [PATCH] ASoC: max98373: Removing 0x203E from the volatile reg

[Mark Brown]

On Fri, 22 Jul 2022 18:52:20 -0700, Ryan Lee wrote:
> The 0x203E speaker gain register should be non-volatile.
> This register value was not able to be synced because it was marked as
> volatile.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: max98373: Removing 0x203E from the volatile reg
      commit: bd1963d837a082e1083cd396803d3d263a9ef68b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark