* [PATCH 0271/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 10:55 Baole Ni
2016-08-02 14:54 ` Sagi Grimberg
0 siblings, 1 reply; 2+ messages in thread
From: Baole Ni @ 2016-08-02 10:55 UTC (permalink / raw)
To: sagi, dledford, sean.hefty, hal.rosenstock, bp
Cc: linux-rdma, target-devel, linux-kernel, chuansheng.liu,
baolex.ni, jgunthorpe, erezsh, matanb, alex.estrin
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/infiniband/ulp/isert/ib_isert.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index a990c04..e2d11ac 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -39,7 +39,7 @@
ISERT_MAX_CONN)
static int isert_debug_level;
-module_param_named(debug_level, isert_debug_level, int, 0644);
+module_param_named(debug_level, isert_debug_level, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(debug_level, "Enable debug tracing if > 0 (default:0)");
static DEFINE_MUTEX(device_list_mutex);
--
2.9.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0271/1285] Replace numeric parameter like 0444 with macro
2016-08-02 10:55 [PATCH 0271/1285] Replace numeric parameter like 0444 with macro Baole Ni
@ 2016-08-02 14:54 ` Sagi Grimberg
0 siblings, 0 replies; 2+ messages in thread
From: Sagi Grimberg @ 2016-08-02 14:54 UTC (permalink / raw)
To: Baole Ni, dledford, sean.hefty, hal.rosenstock, bp
Cc: linux-rdma, target-devel, linux-kernel, chuansheng.liu,
jgunthorpe, erezsh, matanb, alex.estrin
Acked-by: Sagi Grimberg <sagi@grmberg.me>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-02 14:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 10:55 [PATCH 0271/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 14:54 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®