Re: [PATCH 00/23] Subject: [PATCH net-next 00/23] net/hpe: add HPE Slingshot NIC drivers

[Doug Ledford <doug.ledford@hpe.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2512 bytes --]

On 10/31/26 1:17 PM, Andrew Lunn wrote:
> On Fri, Oct 30, 2026 at 03:11:21PM -0700, Jakub Kicinski wrote:
>> On Fri, 30 Oct 2026 13:58:56 -0700 Doug Ledford wrote:
>>>  416 files changed, 185137 insertions(+)
>>
>> 🤣️
> 
> Yes, this patchset is going nowhere.
> 
> Please throw out everything except the absolute bare minimum.
> Ethtool, is not needed in the first patchset. All the UAPI stuff is
> not needed. All the sysfs stuff is gone. One PF, no VF. All the custom
> debug macros can go, etc.

I'll see how fast I can get that done.  But "the bare minimum" is going
to be more than you are accustomed to.  This hardware does not receive
Ethernet packets using MAC address like normal Ethernet hardware.  It
uses a special portal table entry that filters in the Ethernet packets.
It has the ability to have different filters that receive different
Ethernet packets and so sorts them before the driver ever sees them.
And all the infrastructure to handle the portal table entries is
required just to receive any Ethernet packets.

> If you manage to get that absolute minimum base driver merged, you can
> then start adding patchsets to flesh out the driver. Eventually you
> can get to the controversial stuff, like sysfs, uapi, etc, and you can
> argue your case why your driver is special and needs this.
> 
> And as a bit of an aside, how much has an LLM been chewing on the code
> and spitting out issues? 

We ran sashiko, but I think our prompts might have been the RDMA
communities prompts (two different people on the team ran it and we
merged reports, but I wasn't either one so I don't want to make any
claims about things I don't know for sure).

Regardless of that though, the AI engine that you guys are using is
clearly superior to the only one we have access to inside HPE.

> The prompts used by netdev are available, you
> can run it yourself. So you might want to address as many as you can
> before posting code to the list. That will avoid you reaching v42 of
> the absolute bare minimum patchset.

We did.  We fixed right around 200 sashiko findings already.  But, your
prompts would help here.  I know that HPE is looking at adding Claude to
the allowed AI engines, and if I can get early access to that for
running sashiko it would help greatly.  I'll lobby for that internally.


-- 
Doug Ledford <doug.ledford@hpe.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]