mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Ard Biesheuvel" <ardb+git@google.com>, linux-kernel@vger.kernel.org
Cc: x86@kernel.org, "Borislav Petkov" <bp@alien8.de>,
	"Tom Lendacky" <thomas.lendacky@amd.com>,
	"Eric Biggers" <ebiggers@kernel.org>
Subject: Re: [PATCH] x86/sev: Remove bogus virtual address check
Date: Tue, 31 Mar 2026 09:10:50 +0200	[thread overview]
Message-ID: <be0b8d3b-8f48-4b41-869d-29b7d225c7e6@app.fastmail.com> (raw)
In-Reply-To: <20251010151036.42241-2-ardb+git@google.com>

(cc Eric)

On Fri, 10 Oct 2025, at 17:10, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> The AES-GCM crypto library operates strictly on virtual addresses, and
> never performs any H/W offload, and so calling virt_addr_valid() is not
> needed.
>
> Cc: Borislav Petkov (AMD) <bp@alien8.de>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>  arch/x86/coco/sev/core.c | 9 ---------
>  1 file changed, 9 deletions(-)
>

Ping?

> diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
> index 9ae3b11754e6..c4e2de3687a9 100644
> --- a/arch/x86/coco/sev/core.c
> +++ b/arch/x86/coco/sev/core.c
> @@ -2249,15 +2249,6 @@ int snp_send_guest_request(struct snp_msg_desc 
> *mdesc, struct snp_guest_req *req
>  	u64 seqno;
>  	int rc;
> 
> -	/*
> -	 * enc_payload() calls aesgcm_encrypt(), which can potentially offload to HW.
> -	 * The offload's DMA SG list of data to encrypt has to be in linear mapping.
> -	 */
> -	if (!virt_addr_valid(req->req_buf) || !virt_addr_valid(req->resp_buf)) {
> -		pr_warn("AES-GSM buffers must be in linear mapping");
> -		return -EINVAL;
> -	}
> -
>  	guard(mutex)(&snp_cmd_mutex);
> 
>  	/* Check if the VMPCK is not empty */
> -- 
> 2.51.0.740.g6adb054d12-goog

  reply	other threads:[~2026-03-31  7:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-10 15:10 Ard Biesheuvel
2026-03-31  7:10 ` Ard Biesheuvel [this message]
2026-03-31 13:16 ` Borislav Petkov
2026-03-31 13:18   ` Ard Biesheuvel
2026-03-31 13:21     ` Ard Biesheuvel
2026-03-31 21:30       ` Alexey Kardashevskiy
2026-04-01  7:29         ` Ard Biesheuvel
2026-04-01  8:03           ` Alexey Kardashevskiy
2026-04-01  8:12             ` Ard Biesheuvel
2026-04-01 12:16               ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be0b8d3b-8f48-4b41-869d-29b7d225c7e6@app.fastmail.com \
    --to=ardb@kernel.org \
    --cc=ardb+git@google.com \
    --cc=bp@alien8.de \
    --cc=ebiggers@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®