From: John Crispin <john@phrozen.org>
To: NeilBrown <neil@brown.name>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1
Date: Thu, 15 Mar 2018 12:07:26 +0100 [thread overview]
Message-ID: <be0d1e2d-67c5-bac1-63d4-72568dbf9d23@phrozen.org> (raw)
In-Reply-To: <20180315104853.bthffdd4hzklzo6d@mwanda>
On 15/03/18 11:48, Dan Carpenter wrote:
> This all seems fine. Generally the requirements for staging are that it
> has a TODO, someone to work on it, and it doesn't break the build. But
> some of the patches don't have commit message and those are required and
> some of the commit messages are just the changes you have made not don't
> describe the actual code...
>
> John Crispin's email is john@phrozen.org.
>
> regards,
> dan carpenter
>
Hi All,
looks like i was CC'ed on the openwrt addr, which no longer exists. This
series makes no sense. None of the stuff posted is anywhere near ready
to be upstreamed.
* we dont need a dedicated pinctrl driver, pinctrl-single will work fine
on these SoCs
* the DMA/sdhci driver is a hacked up version of the SDK driver.
* drivers/net/ethernet/mediatek/* works on mt7623 and is easily portable
to mt7621, same goes for the gsw driver.
John
next prev parent reply other threads:[~2018-03-15 11:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 20:22 NeilBrown
2018-03-14 20:22 ` [PATCH 02/13] staging: mt7621-pinctrl: ralink: add pinctrl driver NeilBrown
2018-03-14 20:22 ` [PATCH 01/13] staging: mt7621-pci: MIPS/ralink: add MT7621 pcie driver NeilBrown
2018-03-15 10:43 ` Dan Carpenter
2018-03-14 20:22 ` [PATCH 03/13] staging: mt7621-gpio: ralink: add mt7621 gpio controller NeilBrown
2018-03-14 20:22 ` [PATCH 06/13] staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC NeilBrown
2018-03-14 20:22 ` [PATCH 05/13] staging: mt7621-dma: ralink: add rt2880 dma engine NeilBrown
2018-03-14 20:22 ` [PATCH 04/13] staging: mt7621-spi: add mt7621 support NeilBrown
2018-03-14 20:22 ` [PATCH 11/13] staging: mt7621-eth: add support for mt7621 NeilBrown
2018-03-14 20:22 ` [PATCH 13/13] staging: mt7621-dts: add dts files NeilBrown
2018-03-14 20:22 ` [PATCH 12/13] staging: mt7621-eth: mediatek: add Kconfig and Makefile NeilBrown
2018-03-14 20:22 ` [PATCH 09/13] staging: mt7621-eth: add gigabit switch driver (GSW) NeilBrown
2018-03-14 20:22 ` [PATCH 07/13] staging: mt7621-eth: Document ralink/mediatek SoC ethernet binding NeilBrown
2018-03-14 20:22 ` [PATCH 08/13] staging: mt7621-eth: add the drivers core files NeilBrown
2018-03-14 20:22 ` [PATCH 10/13] staging: mt7621-eth: add mdio support for mt762X family NeilBrown
2018-03-14 23:45 ` [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1 NeilBrown
2018-03-15 10:48 ` Dan Carpenter
2018-03-15 11:04 ` NeilBrown
2018-03-15 11:24 ` Dan Carpenter
2018-03-15 20:02 ` NeilBrown
2018-03-16 7:42 ` Dan Carpenter
2018-03-15 11:07 ` John Crispin [this message]
2018-03-15 11:29 ` Dan Carpenter
2018-03-15 20:12 ` NeilBrown
2018-03-15 20:21 ` John Crispin
2018-03-15 22:58 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be0d1e2d-67c5-bac1-63d4-72568dbf9d23@phrozen.org \
--to=john@phrozen.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil@brown.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®