* Re: [tip:irq/core] gpio: mb86s7x: Enable ACPI support [not found] <tip-f3d705d506a2afa6c21c2c728783967e80863b31@git.kernel.org> @ 2019-07-03 12:26 ` Linus Walleij 2019-07-03 13:50 ` Marc Zyngier 0 siblings, 1 reply; 6+ messages in thread From: Linus Walleij @ 2019-07-03 12:26 UTC (permalink / raw) To: Ard Biesheuvel, H. Peter Anvin, Thomas Gleixner, Marc Zyngier, Mika Westerberg, Linus Walleij, linux-kernel, Ingo Molnar Cc: linux-tip-commits On Wed, Jul 3, 2019 at 11:24 AM tip-bot for Ard Biesheuvel <tipbot@zytor.com> wrote: > Committer: Marc Zyngier <marc.zyngier@arm.com> > CommitDate: Wed, 29 May 2019 10:42:19 +0100 > > gpio: mb86s7x: Enable ACPI support > > Make the mb86s7x GPIO block discoverable via ACPI. In addition, add > support for ACPI GPIO interrupts routed via platform interrupts, by > wiring the two together via the to_irq() gpiochip callback. > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> OK! > +#include "gpiolib.h" > + But this isn't needed anymore, is it? I can try to remember to remove it later though. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [tip:irq/core] gpio: mb86s7x: Enable ACPI support 2019-07-03 12:26 ` [tip:irq/core] gpio: mb86s7x: Enable ACPI support Linus Walleij @ 2019-07-03 13:50 ` Marc Zyngier 2019-07-04 7:52 ` Linus Walleij 0 siblings, 1 reply; 6+ messages in thread From: Marc Zyngier @ 2019-07-03 13:50 UTC (permalink / raw) To: Linus Walleij, Ard Biesheuvel, H. Peter Anvin, Thomas Gleixner, Mika Westerberg, linux-kernel, Ingo Molnar Cc: linux-tip-commits On 03/07/2019 13:26, Linus Walleij wrote: > On Wed, Jul 3, 2019 at 11:24 AM tip-bot for Ard Biesheuvel > <tipbot@zytor.com> wrote: > >> Committer: Marc Zyngier <marc.zyngier@arm.com> >> CommitDate: Wed, 29 May 2019 10:42:19 +0100 >> >> gpio: mb86s7x: Enable ACPI support >> >> Make the mb86s7x GPIO block discoverable via ACPI. In addition, add >> support for ACPI GPIO interrupts routed via platform interrupts, by >> wiring the two together via the to_irq() gpiochip callback. >> >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > > OK! > >> +#include "gpiolib.h" >> + > > But this isn't needed anymore, is it? You tell me! ;-) > I can try to remember to remove it later though. Yeah, please send a separate patch. tip is stable, and we can't roll this back. Thanks, M. -- Jazz is not dead. It just smells funny... ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [tip:irq/core] gpio: mb86s7x: Enable ACPI support 2019-07-03 13:50 ` Marc Zyngier @ 2019-07-04 7:52 ` Linus Walleij 2019-07-04 18:18 ` Ard Biesheuvel 0 siblings, 1 reply; 6+ messages in thread From: Linus Walleij @ 2019-07-04 7:52 UTC (permalink / raw) To: Marc Zyngier Cc: Ard Biesheuvel, H. Peter Anvin, Thomas Gleixner, Mika Westerberg, linux-kernel, Ingo Molnar, linux-tip-commits On Wed, Jul 3, 2019 at 3:50 PM Marc Zyngier <marc.zyngier@arm.com> wrote: > On 03/07/2019 13:26, Linus Walleij wrote: > > On Wed, Jul 3, 2019 at 11:24 AM tip-bot for Ard Biesheuvel > > <tipbot@zytor.com> wrote: > > > >> Committer: Marc Zyngier <marc.zyngier@arm.com> > >> CommitDate: Wed, 29 May 2019 10:42:19 +0100 > >> > >> gpio: mb86s7x: Enable ACPI support > >> > >> Make the mb86s7x GPIO block discoverable via ACPI. In addition, add > >> support for ACPI GPIO interrupts routed via platform interrupts, by > >> wiring the two together via the to_irq() gpiochip callback. > >> > >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > >> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > >> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > > > > OK! > > > >> +#include "gpiolib.h" > >> + > > > > But this isn't needed anymore, is it? > > You tell me! ;-) > > > I can try to remember to remove it later though. > > Yeah, please send a separate patch. tip is stable, and we can't roll > this back. I'll just fix it in the GPIO tree after -rc1. Made a personal TODO note! Yours, Linus Walleij ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [tip:irq/core] gpio: mb86s7x: Enable ACPI support 2019-07-04 7:52 ` Linus Walleij @ 2019-07-04 18:18 ` Ard Biesheuvel 2019-07-05 8:57 ` Linus Walleij 0 siblings, 1 reply; 6+ messages in thread From: Ard Biesheuvel @ 2019-07-04 18:18 UTC (permalink / raw) To: Linus Walleij Cc: Marc Zyngier, H. Peter Anvin, Thomas Gleixner, Mika Westerberg, linux-kernel, Ingo Molnar, linux-tip-commits On Thu, 4 Jul 2019 at 09:52, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Jul 3, 2019 at 3:50 PM Marc Zyngier <marc.zyngier@arm.com> wrote: > > On 03/07/2019 13:26, Linus Walleij wrote: > > > On Wed, Jul 3, 2019 at 11:24 AM tip-bot for Ard Biesheuvel > > > <tipbot@zytor.com> wrote: > > > > > >> Committer: Marc Zyngier <marc.zyngier@arm.com> > > >> CommitDate: Wed, 29 May 2019 10:42:19 +0100 > > >> > > >> gpio: mb86s7x: Enable ACPI support > > >> > > >> Make the mb86s7x GPIO block discoverable via ACPI. In addition, add > > >> support for ACPI GPIO interrupts routed via platform interrupts, by > > >> wiring the two together via the to_irq() gpiochip callback. > > >> > > >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > >> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > >> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > > > > > > OK! > > > > > >> +#include "gpiolib.h" > > >> + > > > > > > But this isn't needed anymore, is it? > > > > You tell me! ;-) > > > > > I can try to remember to remove it later though. > > > > Yeah, please send a separate patch. tip is stable, and we can't roll > > this back. > > I'll just fix it in the GPIO tree after -rc1. > Made a personal TODO note! > Why wouldn't it be needed anymore? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [tip:irq/core] gpio: mb86s7x: Enable ACPI support 2019-07-04 18:18 ` Ard Biesheuvel @ 2019-07-05 8:57 ` Linus Walleij 2019-07-05 17:53 ` Ard Biesheuvel 0 siblings, 1 reply; 6+ messages in thread From: Linus Walleij @ 2019-07-05 8:57 UTC (permalink / raw) To: Ard Biesheuvel Cc: Marc Zyngier, H. Peter Anvin, Thomas Gleixner, Mika Westerberg, linux-kernel, Ingo Molnar, linux-tip-commits On Thu, Jul 4, 2019 at 8:18 PM Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > On Thu, 4 Jul 2019 at 09:52, Linus Walleij <linus.walleij@linaro.org> wrote: > > > > On Wed, Jul 3, 2019 at 3:50 PM Marc Zyngier <marc.zyngier@arm.com> wrote: > > > On 03/07/2019 13:26, Linus Walleij wrote: > > > > On Wed, Jul 3, 2019 at 11:24 AM tip-bot for Ard Biesheuvel > > > > <tipbot@zytor.com> wrote: > > > > > > > >> Committer: Marc Zyngier <marc.zyngier@arm.com> > > > >> CommitDate: Wed, 29 May 2019 10:42:19 +0100 > > > >> > > > >> gpio: mb86s7x: Enable ACPI support > > > >> > > > >> Make the mb86s7x GPIO block discoverable via ACPI. In addition, add > > > >> support for ACPI GPIO interrupts routed via platform interrupts, by > > > >> wiring the two together via the to_irq() gpiochip callback. > > > >> > > > >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > > >> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > > >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > >> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > > > > > > > > OK! > > > > > > > >> +#include "gpiolib.h" > > > >> + > > > > > > > > But this isn't needed anymore, is it? > > > > > > You tell me! ;-) > > > > > > > I can try to remember to remove it later though. > > > > > > Yeah, please send a separate patch. tip is stable, and we can't roll > > > this back. > > > > I'll just fix it in the GPIO tree after -rc1. > > Made a personal TODO note! > > Why wouldn't it be needed anymore? I looked over the code like 5 times and I can't see it touching any gpiolib internals anymore, but maybe I'm still wrong? Normally GPIO drivers should get all symbols it needs from <linux/gpio/driver.h> and "gpiolib.h" is not something drivers should include. Anyways I will get to know from compile tests if I'm wrong. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [tip:irq/core] gpio: mb86s7x: Enable ACPI support 2019-07-05 8:57 ` Linus Walleij @ 2019-07-05 17:53 ` Ard Biesheuvel 0 siblings, 0 replies; 6+ messages in thread From: Ard Biesheuvel @ 2019-07-05 17:53 UTC (permalink / raw) To: Linus Walleij Cc: Marc Zyngier, H. Peter Anvin, Thomas Gleixner, Mika Westerberg, linux-kernel, Ingo Molnar, linux-tip-commits On Fri, 5 Jul 2019 at 10:58, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Thu, Jul 4, 2019 at 8:18 PM Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > On Thu, 4 Jul 2019 at 09:52, Linus Walleij <linus.walleij@linaro.org> wrote: > > > > > > On Wed, Jul 3, 2019 at 3:50 PM Marc Zyngier <marc.zyngier@arm.com> wrote: > > > > On 03/07/2019 13:26, Linus Walleij wrote: > > > > > On Wed, Jul 3, 2019 at 11:24 AM tip-bot for Ard Biesheuvel > > > > > <tipbot@zytor.com> wrote: > > > > > > > > > >> Committer: Marc Zyngier <marc.zyngier@arm.com> > > > > >> CommitDate: Wed, 29 May 2019 10:42:19 +0100 > > > > >> > > > > >> gpio: mb86s7x: Enable ACPI support > > > > >> > > > > >> Make the mb86s7x GPIO block discoverable via ACPI. In addition, add > > > > >> support for ACPI GPIO interrupts routed via platform interrupts, by > > > > >> wiring the two together via the to_irq() gpiochip callback. > > > > >> > > > > >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > > > >> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > > > >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > >> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > > > > > > > > > > OK! > > > > > > > > > >> +#include "gpiolib.h" > > > > >> + > > > > > > > > > > But this isn't needed anymore, is it? > > > > > > > > You tell me! ;-) > > > > > > > > > I can try to remember to remove it later though. > > > > > > > > Yeah, please send a separate patch. tip is stable, and we can't roll > > > > this back. > > > > > > I'll just fix it in the GPIO tree after -rc1. > > > Made a personal TODO note! > > > > Why wouldn't it be needed anymore? > > I looked over the code like 5 times and I can't see it touching any > gpiolib internals anymore, but maybe I'm still wrong? > > Normally GPIO drivers should get all symbols it needs from > <linux/gpio/driver.h> and "gpiolib.h" is not something drivers > should include. > > Anyways I will get to know from compile tests if I'm wrong. > IIRC it had something to do with the ACPI helpers that this driver calls directly. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-05 17:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tip-f3d705d506a2afa6c21c2c728783967e80863b31@git.kernel.org>
2019-07-03 12:26 ` [tip:irq/core] gpio: mb86s7x: Enable ACPI support Linus Walleij
2019-07-03 13:50 ` Marc Zyngier
2019-07-04 7:52 ` Linus Walleij
2019-07-04 18:18 ` Ard Biesheuvel
2019-07-05 8:57 ` Linus Walleij
2019-07-05 17:53 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®