* [PATCH] kconfig: streamline_config.pl: check defined(ENV variable) before using it
@ 2020-08-26 21:21 Randy Dunlap
2020-09-02 16:46 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2020-08-26 21:21 UTC (permalink / raw)
To: linux-kbuild, LKML, Steven Rostedt, Masahiro Yamada; +Cc: Changbin Du
From: Randy Dunlap <rdunlap@infradead.org>
A user reported:
'Use of uninitialized value $ENV{"LMC_KEEP"} in split at
./scripts/kconfig/streamline_config.pl line 596.'
so first check that $ENV{LMC_KEEP} is defined before trying
to use it.
Fixes: c027b02d89fd ("streamline_config.pl: add LMC_KEEP to preserve some kconfigs")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Changbin Du <changbin.du@gmail.com>
Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
scripts/kconfig/streamline_config.pl | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- linux-next-20200825.orig/scripts/kconfig/streamline_config.pl
+++ linux-next-20200825/scripts/kconfig/streamline_config.pl
@@ -593,7 +593,10 @@ while ($repeat) {
}
my %setconfigs;
-my @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
+my @preserved_kconfigs;
+if (defined($ENV{'LMC_KEEP'})) {
+ @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
+}
sub in_preserved_kconfigs {
my $kconfig = $config2kfile{$_[0]};
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kconfig: streamline_config.pl: check defined(ENV variable) before using it
2020-08-26 21:21 [PATCH] kconfig: streamline_config.pl: check defined(ENV variable) before using it Randy Dunlap
@ 2020-09-02 16:46 ` Masahiro Yamada
2020-09-02 18:22 ` Nathan Royce
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2020-09-02 16:46 UTC (permalink / raw)
To: Randy Dunlap, Nathan Royce
Cc: linux-kbuild, LKML, Steven Rostedt, Changbin Du
On Thu, Aug 27, 2020 at 6:21 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> A user reported:
> 'Use of uninitialized value $ENV{"LMC_KEEP"} in split at
> ./scripts/kconfig/streamline_config.pl line 596.'
>
> so first check that $ENV{LMC_KEEP} is defined before trying
> to use it.
>
> Fixes: c027b02d89fd ("streamline_config.pl: add LMC_KEEP to preserve some kconfigs")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Changbin Du <changbin.du@gmail.com>
> Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
Applied to linux-kbuild/fixes with Nathan's tag
Reported-by: Nathan Royce <nroycea+kernel@gmail.com>
Nathan,
I think adding your tag is OK to credit your contribution.
Please let me know if you do not have it in
the commit log.
> scripts/kconfig/streamline_config.pl | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> --- linux-next-20200825.orig/scripts/kconfig/streamline_config.pl
> +++ linux-next-20200825/scripts/kconfig/streamline_config.pl
> @@ -593,7 +593,10 @@ while ($repeat) {
> }
>
> my %setconfigs;
> -my @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
> +my @preserved_kconfigs;
> +if (defined($ENV{'LMC_KEEP'})) {
> + @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
> +}
>
> sub in_preserved_kconfigs {
> my $kconfig = $config2kfile{$_[0]};
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kconfig: streamline_config.pl: check defined(ENV variable) before using it
2020-09-02 16:46 ` Masahiro Yamada
@ 2020-09-02 18:22 ` Nathan Royce
2020-09-03 2:13 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Nathan Royce @ 2020-09-02 18:22 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Randy Dunlap, linux-kbuild, LKML, Steven Rostedt, Changbin Du
Thanks, but I'd just as soon not be acknowledged/credited. All I did
was submit a report.
On Wed, Sep 2, 2020 at 11:47 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Applied to linux-kbuild/fixes with Nathan's tag
>
> Reported-by: Nathan Royce <nroycea+kernel@gmail.com>
>
>
>
> Nathan,
> I think adding your tag is OK to credit your contribution.
> Please let me know if you do not have it in
> the commit log.
>
>
>
> --
> Best Regards
> Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kconfig: streamline_config.pl: check defined(ENV variable) before using it
2020-09-02 18:22 ` Nathan Royce
@ 2020-09-03 2:13 ` Masahiro Yamada
2020-09-03 2:18 ` Nathan Royce
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2020-09-03 2:13 UTC (permalink / raw)
To: Nathan Royce
Cc: Randy Dunlap, linux-kbuild, LKML, Steven Rostedt, Changbin Du
On Thu, Sep 3, 2020 at 3:22 AM Nathan Royce <nroycea+kernel@gmail.com> wrote:
>
> Thanks, but I'd just as soon not be acknowledged/credited. All I did
> was submit a report.
>
> On Wed, Sep 2, 2020 at 11:47 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > Applied to linux-kbuild/fixes with Nathan's tag
> >
> > Reported-by: Nathan Royce <nroycea+kernel@gmail.com>
> >
> >
> >
> > Nathan,
> > I think adding your tag is OK to credit your contribution.
> > Please let me know if you do not have it in
> > the commit log.
Even if you do not write the code,
reporting bugs is a great contribution,
and the Reported-by exists for that, I think.
So, I just want to add your Reported-by tag
(if you do not mind).
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kconfig: streamline_config.pl: check defined(ENV variable) before using it
2020-09-03 2:13 ` Masahiro Yamada
@ 2020-09-03 2:18 ` Nathan Royce
2020-09-03 2:42 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Nathan Royce @ 2020-09-03 2:18 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Randy Dunlap, linux-kbuild, LKML, Steven Rostedt, Changbin Du
Heard, but all the same if it isn't important (which I'm assuming),
I'd just as soon be left out of it. That's just the way I am in
general, not wanting to be seen unless I have to be seen. Thanks
though.
On Wed, Sep 2, 2020 at 9:14 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Even if you do not write the code,
> reporting bugs is a great contribution,
> and the Reported-by exists for that, I think.
>
> So, I just want to add your Reported-by tag
> (if you do not mind).
>
>
> --
> Best Regards
> Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kconfig: streamline_config.pl: check defined(ENV variable) before using it
2020-09-03 2:18 ` Nathan Royce
@ 2020-09-03 2:42 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2020-09-03 2:42 UTC (permalink / raw)
To: Nathan Royce
Cc: Randy Dunlap, linux-kbuild, LKML, Steven Rostedt, Changbin Du
On Thu, Sep 3, 2020 at 11:18 AM Nathan Royce <nroycea+kernel@gmail.com> wrote:
>
> Heard, but all the same if it isn't important (which I'm assuming),
> I'd just as soon be left out of it. That's just the way I am in
> general, not wanting to be seen unless I have to be seen. Thanks
> though.
OK, I will drop your tag.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-03 2:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 21:21 [PATCH] kconfig: streamline_config.pl: check defined(ENV variable) before using it Randy Dunlap
2020-09-02 16:46 ` Masahiro Yamada
2020-09-02 18:22 ` Nathan Royce
2020-09-03 2:13 ` Masahiro Yamada
2020-09-03 2:18 ` Nathan Royce
2020-09-03 2:42 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®