* [PATCH] ARM: make CONFIG_DEBUG_WX depend on MMU
@ 2018-02-20 15:09 Arnd Bergmann
2018-02-20 16:45 ` Laura Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-02-20 15:09 UTC (permalink / raw)
To: Russell King
Cc: Kees Cook, Laura Abbott, Jinbum Park, Arnd Bergmann,
Tony Lindgren, linux-arm-kernel, linux-kernel
Without CONFIG_MMU, this results in a build failure:
./arch/arm/include/asm/memory.h:92:23: error: initializer element is not constant
#define VECTORS_BASE vectors_base
arch/arm/mm/dump.c:32:4: note: in expansion of macro 'VECTORS_BASE'
{ VECTORS_BASE, "Vectors" },
arch/arm/mm/dump.c:71:11: error: 'L_PTE_USER' undeclared here (not in a function); did you mean 'VTIME_USER'?
.mask = L_PTE_USER,
^~~~~~~~~~
Obviously the feature only makes sense with an MMU, so let's add the
dependency here.
Fixes: a8e53c151fe7 ("ARM: 8737/1: mm: dump: add checking for writable and executable")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/Kconfig.debug | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 7b3d9c5c73bb..6db106b5b9e9 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -22,6 +22,7 @@ config ARM_PTDUMP_DEBUGFS
config DEBUG_WX
bool "Warn on W+X mappings at boot"
+ depends on MMU
select ARM_PTDUMP_CORE
---help---
Generate a warning if any W+X mappings are found at boot.
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: make CONFIG_DEBUG_WX depend on MMU
2018-02-20 15:09 [PATCH] ARM: make CONFIG_DEBUG_WX depend on MMU Arnd Bergmann
@ 2018-02-20 16:45 ` Laura Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Laura Abbott @ 2018-02-20 16:45 UTC (permalink / raw)
To: Arnd Bergmann, Russell King
Cc: Kees Cook, Jinbum Park, Tony Lindgren, linux-arm-kernel, linux-kernel
On 02/20/2018 07:09 AM, Arnd Bergmann wrote:
> Without CONFIG_MMU, this results in a build failure:
>
> ./arch/arm/include/asm/memory.h:92:23: error: initializer element is not constant
> #define VECTORS_BASE vectors_base
> arch/arm/mm/dump.c:32:4: note: in expansion of macro 'VECTORS_BASE'
> { VECTORS_BASE, "Vectors" },
>
> arch/arm/mm/dump.c:71:11: error: 'L_PTE_USER' undeclared here (not in a function); did you mean 'VTIME_USER'?
> .mask = L_PTE_USER,
> ^~~~~~~~~~
>
> Obviously the feature only makes sense with an MMU, so let's add the
> dependency here.
>
Acked-by: Laura Abbott <labbott@redhat.com>
> Fixes: a8e53c151fe7 ("ARM: 8737/1: mm: dump: add checking for writable and executable")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 7b3d9c5c73bb..6db106b5b9e9 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -22,6 +22,7 @@ config ARM_PTDUMP_DEBUGFS
>
> config DEBUG_WX
> bool "Warn on W+X mappings at boot"
> + depends on MMU
> select ARM_PTDUMP_CORE
> ---help---
> Generate a warning if any W+X mappings are found at boot.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-20 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-20 15:09 [PATCH] ARM: make CONFIG_DEBUG_WX depend on MMU Arnd Bergmann
2018-02-20 16:45 ` Laura Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome