From: Reinette Chatre <reinette.chatre@intel.com>
To: Ben Horgan <ben.horgan@arm.com>, <tony.luck@intel.com>,
<james.morse@arm.com>, <Dave.Martin@arm.com>,
<babu.moger@amd.com>, <bp@alien8.de>, <tglx@linutronix.de>,
<dave.hansen@linux.intel.com>
Cc: <x86@kernel.org>, <hpa@zytor.com>, <fustini@kernel.org>,
<fenghuay@nvidia.com>, <peternewman@google.com>,
<yu.c.chen@intel.com>, <linux-kernel@vger.kernel.org>,
<patches@lists.linux.dev>
Subject: Re: [PATCH 5/5] fs/resctrl: Drop unnecessary parameter from resctrl_io_alloc_parse_line()
Date: Tue, 8 Sep 2026 09:28:25 -0700 [thread overview]
Message-ID: <bee83a8b-3bc1-4eda-bc02-f5c5f226277f@intel.com> (raw)
In-Reply-To: <790b4d24-a9bf-4226-b929-1c4611cd8540@arm.com>
Hi Ben,
On 9/7/26 2:21 AM, Ben Horgan wrote:
> Hi Reinette,
>
> On 03/09/2026 17:57, Reinette Chatre wrote:
>> resctrl_io_alloc_parse_line() only has one caller that determines the
>> resource via resctrl_schema::res and then passes a pointer to the resource
>> as well as struct resctrl_schema.
>>
>> Only pass pointer to struct resctrl_schema. resctrl_io_alloc_parse_line()
>> can determine the resource itself.
>
> Nit: Without taking into account that a resource is going to support multiple controls in the future
> this change feels a little under justified. Perhaps any extra line in the commit message is warranted.
I agree. I did have such snippet in an earlier attempt and our internal AI review suggested
it be dropped since it references work that is not included in this series self.
I'll rework that snippet to see if I can find some middle ground.
>
> Regardless, this looks good to me.
>
> Reviewed-by: Ben Horgan <ben.horgan@arm.com>
Thank you very much for this and the other reviews.
Reinette
next prev parent reply other threads:[~2026-09-08 16:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 16:57 [PATCH 0/5] x86,fs/resctrl: Cleanups in preparation for multiple Reinette Chatre
2026-09-03 16:57 ` [PATCH 1/5] fs/resctrl: Drop support for different bandwidth delay mappings Reinette Chatre
2026-09-04 3:33 ` Chen Yu
2026-09-04 15:50 ` Reinette Chatre
2026-09-07 2:08 ` Chen, Yu C
2026-09-03 16:57 ` [PATCH 2/5] x86,fs/resctrl: Remove "arch_needs_linear" Reinette Chatre
2026-09-04 3:14 ` Chen Yu
2026-09-04 15:50 ` Reinette Chatre
2026-09-07 2:10 ` Chen, Yu C
2026-09-08 16:18 ` Reinette Chatre
2026-09-03 16:57 ` [PATCH 3/5] x86,fs/resctrl: Make MSR_IA32_L{2,3}_QOS_CFG scope architecture specific Reinette Chatre
2026-09-03 16:57 ` [PATCH 4/5] fs/resctrl: Drop unnecessary is_mba_linear() helper Reinette Chatre
2026-09-04 4:38 ` Chen Yu
2026-09-04 15:51 ` Reinette Chatre
2026-09-07 9:15 ` Ben Horgan
2026-09-03 16:57 ` [PATCH 5/5] fs/resctrl: Drop unnecessary parameter from resctrl_io_alloc_parse_line() Reinette Chatre
2026-09-07 9:21 ` Ben Horgan
2026-09-08 16:28 ` Reinette Chatre [this message]
2026-09-03 17:02 ` [PATCH 0/5] x86,fs/resctrl: Cleanups in preparation for multiple Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bee83a8b-3bc1-4eda-bc02-f5c5f226277f@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=ben.horgan@arm.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=fustini@kernel.org \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®