mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Max Staudt <max@enpas.org>
To: Roderick Colenbrander <thunderbird2k@gmail.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Roderick Colenbrander <roderick.colenbrander@sony.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] hid-playstation: DS4: Update rumble and lightbar together
Date: Mon, 22 Jul 2024 12:40:38 +0900	[thread overview]
Message-ID: <bf096319-c44d-4bbf-bbcb-374d3cce0ca7@enpas.org> (raw)
In-Reply-To: <5b42961b-8ca6-4245-b16c-d703255e5aea@enpas.org>

On second thought, maybe we can sidestep this discussion entirely by 
using a new Kconfig to have both states configurable.

Something like:

   CONFIG_HID_PLAYSTATION_V6_6_ANDROID_TEST_COMPAT

Improvements such as my patch would be turned off when this flag is 
enabled, and the driver behaviour reverted to the v6.6 LTS behaviour. So 
Android kernels would enable it, and everyone else (especially desktop 
distributions) can leave it off.

Then, once the Android test suite is fixed, the Kconfig can be removed. 
Looking at the Android release cadence in recent years, and the timeline 
of DS4 support in hid-playstation and in the v6.6 LTS kernel, I presume 
this would be in 1-2 years.

This way, upstream can continue improving the driver, without triggering 
Android test failures.


How does this sound?

Max


  reply	other threads:[~2024-07-22  3:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-16 16:30 Max Staudt
2024-06-17 23:01 ` Roderick Colenbrander
2024-06-20 19:26   ` Max Staudt
2024-07-08 16:07     ` Roderick Colenbrander
2024-07-10 15:35       ` Max Staudt
2024-07-17  0:26         ` Roderick Colenbrander
2024-07-21 14:33           ` Max Staudt
2024-07-22  3:40             ` Max Staudt [this message]
2024-07-22 16:49               ` Benjamin Tissoires
2024-07-22 19:30                 ` Max Staudt
2024-08-08 23:11                   ` Roderick Colenbrander
2024-08-11 13:22                     ` Max Staudt
2024-07-22 16:46             ` Benjamin Tissoires
2024-07-22 19:24               ` Max Staudt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf096319-c44d-4bbf-bbcb-374d3cce0ca7@enpas.org \
    --to=max@enpas.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roderick.colenbrander@sony.com \
    --cc=thunderbird2k@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®