From: Max Staudt <max@enpas.org>
To: Benjamin Tissoires <bentiss@kernel.org>
Cc: Roderick Colenbrander <thunderbird2k@gmail.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Roderick Colenbrander <roderick.colenbrander@sony.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] hid-playstation: DS4: Update rumble and lightbar together
Date: Tue, 23 Jul 2024 04:30:53 +0900 [thread overview]
Message-ID: <cde0bcf3-eb31-48ae-93a6-e630ba80a068@enpas.org> (raw)
In-Reply-To: <rktgvill7zgcggiir54ixh3ele4zeqatoxwshamebtvvcnz4z5@nmmh5wgwnqmf>
On 7/23/24 01:49, Benjamin Tissoires wrote:
> Is there anyway to detect that the device can not support the current
> behavior? And if so then dynamically switch to the new behaviour?
Sadly, no, otherwise I would have used that already :(
Also, the change that my patch makes is in the "dialect" of the wire
protocol. This seemingly changes zero in the original Sony device's
behaviour, both from what my tests have shown, and from what I gather
from Roderick's emails. HID traces on the web confirm that the PS4 may
output such or similar reports as well. Hence I don't understand why we
would want to make a distinction at all, if the driver can simply only
speak the "dialect" that works on most devices.
Max
next prev parent reply other threads:[~2024-07-22 19:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 16:30 Max Staudt
2024-06-17 23:01 ` Roderick Colenbrander
2024-06-20 19:26 ` Max Staudt
2024-07-08 16:07 ` Roderick Colenbrander
2024-07-10 15:35 ` Max Staudt
2024-07-17 0:26 ` Roderick Colenbrander
2024-07-21 14:33 ` Max Staudt
2024-07-22 3:40 ` Max Staudt
2024-07-22 16:49 ` Benjamin Tissoires
2024-07-22 19:30 ` Max Staudt [this message]
2024-08-08 23:11 ` Roderick Colenbrander
2024-08-11 13:22 ` Max Staudt
2024-07-22 16:46 ` Benjamin Tissoires
2024-07-22 19:24 ` Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cde0bcf3-eb31-48ae-93a6-e630ba80a068@enpas.org \
--to=max@enpas.org \
--cc=benjamin.tissoires@redhat.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roderick.colenbrander@sony.com \
--cc=thunderbird2k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®