From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de
Subject: Re: [RT PATCH 1/2] timers: wakeup all timer waiters
Date: Thu, 14 Jul 2016 20:37:42 +0200 [thread overview]
Message-ID: <bf4277f7-0da1-bbf6-4425-cfaeb74afab6@linutronix.de> (raw)
In-Reply-To: <20160714131945.67cc8ce5@gandalf.local.home>
On 07/14/2016 07:19 PM, Steven Rostedt wrote:
>> While doing so I noticed that we drop the base lock during timer
>> invocations and so it could be possible that we have two invocations
>> of del_timer_sync() on a timer on the same "base" (one after the
>> other). This is patch #1.
>>
>> After that I saw that we do the wake up under the base lock but there
>> is no reason for it. So here is patch #2.
>>
>> Patch #1 is something that could happen in theory and I did not run in
>> any problem.
>>
>
> OK, so patch 2 was just discovered by reviewing code?
both, not just patch 2.
>
> -- Steve
Sebastian
prev parent reply other threads:[~2016-07-14 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 16:05 Sebastian Andrzej Siewior
2016-07-14 16:05 ` [RT PATCH 2/2] timers: wakeup all timer waiters without holding the base lock Sebastian Andrzej Siewior
2016-07-14 16:09 ` Steven Rostedt
2016-07-14 17:19 ` Sebastian Andrzej Siewior
2016-07-14 17:21 ` Steven Rostedt
2016-07-14 16:13 ` [RT PATCH 1/2] timers: wakeup all timer waiters Steven Rostedt
2016-07-14 17:14 ` Sebastian Andrzej Siewior
2016-07-14 17:19 ` Steven Rostedt
2016-07-14 18:37 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf4277f7-0da1-bbf6-4425-cfaeb74afab6@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®