From: Paolo Bonzini <pbonzini@redhat.com>
To: "Sean Christopherson" <sean.j.christopherson@intel.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Add a WARN on TIF_NEED_FPU_LOAD in kvm_load_guest_fpu()
Date: Tue, 10 Dec 2019 11:29:00 +0100 [thread overview]
Message-ID: <bf494125-1de6-dc41-1438-0ee5f802c229@redhat.com> (raw)
In-Reply-To: <20191209200517.13382-1-sean.j.christopherson@intel.com>
On 09/12/19 21:05, Sean Christopherson wrote:
> + /*
> + * Reloading userspace's FPU is handled by kvm_arch_vcpu_load(), both
> + * for direct calls from userspace (via vcpu_load()) and if this task
> + * is preempted (via kvm_arch_sched_in()) between vcpu_load() and now.
via kvm_sched_in (not the arch_ function). Applied with that change.
Paolo
> + */
> + WARN_ON_ONCE(test_thread_flag(TIF_NEED_FPU_LOAD));
> +
prev parent reply other threads:[~2019-12-10 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 20:05 Sean Christopherson
2019-12-10 10:29 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf494125-1de6-dc41-1438-0ee5f802c229@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®