From: Xi Ruoyao <xry111@xry111.site>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v1 3/4] LoongArch: Use larch_insn_gen_break() for kprobes
Date: Wed, 12 Apr 2023 19:08:21 +0800 [thread overview]
Message-ID: <bf4bda7a88bd5f33bd3bdc7fc715bc24fa4add8f.camel@xry111.site> (raw)
In-Reply-To: <1681293901-24918-4-git-send-email-yangtiezhu@loongson.cn>
On Wed, 2023-04-12 at 18:05 +0800, Tiezhu Yang wrote:
> -static inline bool insns_not_supported(union loongarch_instruction insn)
> +static inline bool insns_not_supported(u32 code)
> {
> + union loongarch_instruction insn;
> +
> + insn.word = code;
> +
I remember Xuerui disliked this change. Maybe we can add
__attribute__ (__transparent_union__) [1] for union
loongarch_instruction instead?
[1]: https://gcc.gnu.org/onlinedocs/gcc/Common-Type-Attributes.html#index-transparent_005funion-type-attribute
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2023-04-12 11:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 10:04 [PATCH v1 0/4] Add uprobes support for LoongArch Tiezhu Yang
2023-04-12 10:04 ` [PATCH v1 1/4] LoongArch: Move three functions from kprobes.c to inst.h Tiezhu Yang
2023-04-12 10:39 ` Xi Ruoyao
2023-04-13 1:55 ` Tiezhu Yang
2023-04-12 10:04 ` [PATCH v1 2/4] LoongArch: Add larch_insn_gen_break() to generate break insns Tiezhu Yang
2023-04-12 10:05 ` [PATCH v1 3/4] LoongArch: Use larch_insn_gen_break() for kprobes Tiezhu Yang
2023-04-12 11:08 ` Xi Ruoyao [this message]
2023-04-13 1:58 ` Tiezhu Yang
2023-04-12 10:05 ` [PATCH v1 4/4] LoongArch: Add uprobes support Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf4bda7a88bd5f33bd3bdc7fc715bc24fa4add8f.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®