Re: [PATCH v9 2/2] scsi: ufs: core: Add support for static TX Equalization settings

[Can Guo <can.guo@oss.qualcomm.com>]

On 6/16/2026 4:04 PM, Peter Wang (王信友) wrote:
>
> On Mon, 2026-06-15 at 06:28 -0700, Can Guo wrote:
> > Parse board-specific static TX Equalization settings from Device Tree
> > for
> > each HS gear and store them in hba->tx_eq_params.
> > 
> > Parse txeq-preshoot-g[1-6] and txeq-deemphasis-g[1-6] as per-lane
> > tuples:
> > <Host_Lane0 Device_Lane0>, [<Host_Lane1 Device_Lane1>].
> > 
> > For HS-G6, parse optional tx-precode-enable-g6 using the same per-
> > lane
> > Host/Device tuple format. If provided, it must contain values for all
> > active lanes, and each value must be 0 or 1.
> > 
> > Introduce from_dt in struct ufshcd_tx_eq_params to track whether TX
> > EQ
> > values came from static Device Tree data.
> > 
> > When TX Equalization Training is used, static settings are not final:
> > - If valid settings are retrieved from
> > qTxEQGnSettings/wTxEQGnSettingsExt,
> >   those retrieved settings override static Device Tree settings.
> > - If retrieval is not available/valid, TX EQTR runs and trained
> > settings
> >   override static Device Tree settings.
> > 
> > No behavior changes for platforms that do not provide these
> > properties.
> > 
> > Signed-off-by: Can Guo <can.guo@oss.qualcomm.com>
> > ---
>
> Hi Can,
>
> I agree with Bart's comment.
> Regarding sashiko-bot's comment, will you have another patch to
> fix this pre-existing issue?
> I think force_tx_eqtr could potentially trigger this deadlock.
Yes, I pushed a separate fix to address the memory reclaim deadlock issue.

https://lore.kernel.org/all/20260616090654.421850-1-can.guo@oss.qualcomm.com/

Please help review.

Thanks,
Can Guo.
>
> Thanks.
> Peter
>
>
>
> ************* MEDIATEK Confidentiality Notice ********************
> The information contained in this e-mail message (including any
> attachments) may be confidential, proprietary, privileged, or otherwise
> exempt from disclosure under applicable laws. It is intended to be
> conveyed only to the designated recipient(s). Any use, dissemination,
> distribution, printing, retaining or copying of this e-mail (including its
> attachments) by unintended recipient(s) is strictly prohibited and may
> be unlawful. If you are not an intended recipient of this e-mail, or believe
> that you have received this e-mail in error, please notify the sender
> immediately (by replying to this e-mail), delete any and all copies of
> this e-mail (including any attachments) from your system, and do not
> disclose the content of this e-mail to any other person. Thank you!