* RE: [PATCH] clocksource: Return negative error code in h8300_8timer_init()
[not found] <7356d489-2320-2a75-0999-0b3f0f8ac373@web.de>
@ 2020-09-02 8:34 ` Tianxianting
0 siblings, 0 replies; only message in thread
From: Tianxianting @ 2020-09-02 8:34 UTC (permalink / raw)
To: Markus Elfring, uclinux-h8-devel
Cc: linux-kernel, kernel-janitors, Daniel Lezcano, Thomas Gleixner,
Yoshinori Sato
Hi Markus,
Thanks for your comments.
No real fix, as normally , we should return a negative code,
In function h8300_8timer_init(), it set ' ret = -EINVAL ', ' ret = ENXIO' , it should be align with a negative code
static int __init h8300_8timer_init(struct device_node *node)
{
ret = ENXIO; <<<
base = of_iomap(node, 0);
if (!base) {
pr_err("failed to map registers for clockevent\n");
goto free_clk;
}
ret = -EINVAL; <<<
irq = irq_of_parse_and_map(node, 0);
if (!irq) {
pr_err("failed to get irq for clockevent\n");
goto unmap_reg;
}
-----Original Message-----
From: Markus Elfring [mailto:Markus.Elfring@web.de]
Sent: Tuesday, September 01, 2020 10:46 PM
To: tianxianting (RD) <tian.xianting@h3c.com>; uclinux-h8-devel@lists.sourceforge.jp
Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner <tglx@linutronix.de>; Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH] clocksource: Return negative error code in h8300_8timer_init()
> A negative error code should be returned
* Can an other imperative wording become helpful for the change description?
* Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread