Re: drm/amdgpu: fix an amdgpu_irq_put() issue in gmc_v9_0_hw_fini()

["Limonciello, Mario" <mlimonci@amd.com>]

On 5/2/2023 11:51 AM, Hamza Mahfooz wrote:
> As made mention of, in commit 9128e6babf10 ("drm/amdgpu: fix
> amdgpu_irq_put call trace in gmc_v10_0_hw_fini") and commit c094b8923bdd
> ("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini"). It
> is meaningless to call amdgpu_irq_put() for gmc.ecc_irq. So, remove it
> from gmc_v9_0_hw_fini().
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2522
> Fixes: 3029c855d79f ("drm/amdgpu: Fix desktop freezed after gpu-reset")
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 290804a06e05..6ae5cee9b64b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -1999,7 +1999,6 @@ static int gmc_v9_0_hw_fini(void *handle)
>   	if (adev->mmhub.funcs->update_power_gating)
>   		adev->mmhub.funcs->update_power_gating(adev, false);
>   
> -	amdgpu_irq_put(adev, &adev->gmc.ecc_irq, 0);
>   	amdgpu_irq_put(adev, &adev->gmc.vm_fault, 0);
>   
>   	return 0;