* [PATCH] drm/amdgpu: fix an amdgpu_irq_put() issue in gmc_v9_0_hw_fini()
@ 2023-05-02 16:51 Hamza Mahfooz
2023-05-03 18:30 ` Limonciello, Mario
0 siblings, 1 reply; 2+ messages in thread
From: Hamza Mahfooz @ 2023-05-02 16:51 UTC (permalink / raw)
To: amd-gfx
Cc: Hamza Mahfooz, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Hawking Zhang, Felix Kuehling,
Stanley Yang, Le Ma, Mukul Joshi, Tao Zhou, Alan Liu, dri-devel,
linux-kernel
As made mention of, in commit 9128e6babf10 ("drm/amdgpu: fix
amdgpu_irq_put call trace in gmc_v10_0_hw_fini") and commit c094b8923bdd
("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini"). It
is meaningless to call amdgpu_irq_put() for gmc.ecc_irq. So, remove it
from gmc_v9_0_hw_fini().
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2522
Fixes: 3029c855d79f ("drm/amdgpu: Fix desktop freezed after gpu-reset")
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index 290804a06e05..6ae5cee9b64b 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
@@ -1999,7 +1999,6 @@ static int gmc_v9_0_hw_fini(void *handle)
if (adev->mmhub.funcs->update_power_gating)
adev->mmhub.funcs->update_power_gating(adev, false);
- amdgpu_irq_put(adev, &adev->gmc.ecc_irq, 0);
amdgpu_irq_put(adev, &adev->gmc.vm_fault, 0);
return 0;
--
2.40.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: drm/amdgpu: fix an amdgpu_irq_put() issue in gmc_v9_0_hw_fini()
2023-05-02 16:51 [PATCH] drm/amdgpu: fix an amdgpu_irq_put() issue in gmc_v9_0_hw_fini() Hamza Mahfooz
@ 2023-05-03 18:30 ` Limonciello, Mario
0 siblings, 0 replies; 2+ messages in thread
From: Limonciello, Mario @ 2023-05-03 18:30 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: Alan Liu, Mukul Joshi, Tao Zhou, Felix Kuehling, Pan, Xinhui,
linux-kernel, dri-devel, Le Ma, Stanley Yang, Daniel Vetter,
Alex Deucher, David Airlie, Christian König, Hawking Zhang
On 5/2/2023 11:51 AM, Hamza Mahfooz wrote:
> As made mention of, in commit 9128e6babf10 ("drm/amdgpu: fix
> amdgpu_irq_put call trace in gmc_v10_0_hw_fini") and commit c094b8923bdd
> ("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini"). It
> is meaningless to call amdgpu_irq_put() for gmc.ecc_irq. So, remove it
> from gmc_v9_0_hw_fini().
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2522
> Fixes: 3029c855d79f ("drm/amdgpu: Fix desktop freezed after gpu-reset")
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 290804a06e05..6ae5cee9b64b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -1999,7 +1999,6 @@ static int gmc_v9_0_hw_fini(void *handle)
> if (adev->mmhub.funcs->update_power_gating)
> adev->mmhub.funcs->update_power_gating(adev, false);
>
> - amdgpu_irq_put(adev, &adev->gmc.ecc_irq, 0);
> amdgpu_irq_put(adev, &adev->gmc.vm_fault, 0);
>
> return 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-03 18:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-02 16:51 [PATCH] drm/amdgpu: fix an amdgpu_irq_put() issue in gmc_v9_0_hw_fini() Hamza Mahfooz
2023-05-03 18:30 ` Limonciello, Mario
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®