mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] firmware_loader: Fix a NULL vs IS_ERR() check
@ 2023-05-16  8:12 Dan Carpenter
  2023-05-16  8:23 ` Cezary Rojewski
  2023-05-16 21:51 ` Luis Chamberlain
  0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2023-05-16  8:12 UTC (permalink / raw)
  To: Amadeusz Sławiński
  Cc: Luis Chamberlain, Russ Weight, Greg Kroah-Hartman,
	Rafael J. Wysocki, Cezary Rojewski, linux-kernel,
	kernel-janitors

The crypto_alloc_shash() function doesn't return NULL, it returns
error pointers.  Update the check accordingly.

Fixes: 02fe26f25325 ("firmware_loader: Add debug message with checksum for FW file")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/base/firmware_loader/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index 9d79d5ad9102..b58c42f1b1ce 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -812,7 +812,7 @@ static void fw_log_firmware_info(const struct firmware *fw, const char *name, st
 	char *outbuf;
 
 	alg = crypto_alloc_shash("sha256", 0, 0);
-	if (!alg)
+	if (IS_ERR(alg))
 		return;
 
 	sha256buf = kmalloc(SHA256_DIGEST_SIZE, GFP_KERNEL);
-- 
2.39.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] firmware_loader: Fix a NULL vs IS_ERR() check
  2023-05-16  8:12 [PATCH] firmware_loader: Fix a NULL vs IS_ERR() check Dan Carpenter
@ 2023-05-16  8:23 ` Cezary Rojewski
  2023-05-16 21:51 ` Luis Chamberlain
  1 sibling, 0 replies; 3+ messages in thread
From: Cezary Rojewski @ 2023-05-16  8:23 UTC (permalink / raw)
  To: Dan Carpenter, Amadeusz Sławiński
  Cc: Luis Chamberlain, Russ Weight, Greg Kroah-Hartman,
	Rafael J. Wysocki, linux-kernel, kernel-janitors

On 2023-05-16 10:12 AM, Dan Carpenter wrote:
> The crypto_alloc_shash() function doesn't return NULL, it returns
> error pointers.  Update the check accordingly.
> 
> Fixes: 02fe26f25325 ("firmware_loader: Add debug message with checksum for FW file")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>   drivers/base/firmware_loader/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
> index 9d79d5ad9102..b58c42f1b1ce 100644
> --- a/drivers/base/firmware_loader/main.c
> +++ b/drivers/base/firmware_loader/main.c
> @@ -812,7 +812,7 @@ static void fw_log_firmware_info(const struct firmware *fw, const char *name, st
>   	char *outbuf;
>   
>   	alg = crypto_alloc_shash("sha256", 0, 0);
> -	if (!alg)
> +	if (IS_ERR(alg))
>   		return;
>   
>   	sha256buf = kmalloc(SHA256_DIGEST_SIZE, GFP_KERNEL);

Thank you for the fix.

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] firmware_loader: Fix a NULL vs IS_ERR() check
  2023-05-16  8:12 [PATCH] firmware_loader: Fix a NULL vs IS_ERR() check Dan Carpenter
  2023-05-16  8:23 ` Cezary Rojewski
@ 2023-05-16 21:51 ` Luis Chamberlain
  1 sibling, 0 replies; 3+ messages in thread
From: Luis Chamberlain @ 2023-05-16 21:51 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Amadeusz Sławiński, Russ Weight, Greg Kroah-Hartman,
	Rafael J. Wysocki, Cezary Rojewski, linux-kernel,
	kernel-janitors

On Tue, May 16, 2023 at 11:12:51AM +0300, Dan Carpenter wrote:
> The crypto_alloc_shash() function doesn't return NULL, it returns
> error pointers.  Update the check accordingly.
> 
> Fixes: 02fe26f25325 ("firmware_loader: Add debug message with checksum for FW file")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Acked-by: Luis Chamberlain <mcgrof@kernel.org>

  Luis

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-16 21:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-16  8:12 [PATCH] firmware_loader: Fix a NULL vs IS_ERR() check Dan Carpenter
2023-05-16  8:23 ` Cezary Rojewski
2023-05-16 21:51 ` Luis Chamberlain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®