[PATCH RFC 0/2] pinctrl: qcom: eliza: Couple misc fixes

[PATCH RFC 0/2] pinctrl: qcom: eliza: Couple misc fixes

[Alexander Koskovich]

This series is just a couple misc fixes for stuff I saw when looking
at the same function name/same pin issue, but didn't want to put it
in that series.

Not 100% on the HDMI change here as my hardware doesn't support HDMI
but when I was reading some documentation for Eliza I noticed this,
would be greatly appreciated if this could be confirmed.

Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
---
Alexander Koskovich (2):
      pinctrl: qcom: eliza: Fix HDMI_RCV_DET function slot
      pinctrl: qcom: eliza: Fix QDSS trace clock/control pingroup names

 drivers/pinctrl/qcom/pinctrl-eliza.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
---
base-commit: 90700e10d2ad61c13a5117cfa5e08d9f2e497dcc
change-id: 20260423-misc-eliza-pinctrl-3a577f40763b

Best regards,
-- 
Alexander Koskovich <akoskovich@pm.me>

[PATCH RFC 1/2] pinctrl: qcom: eliza: Fix HDMI_RCV_DET function slot

[Alexander Koskovich]

The hdmi_rcv_det function was placed at alt function slot 2, but the
correct mux value for this function on GPIO 19 is slot 3. Move it
accordingly and leave slot 2 unassigned.

Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
---
 drivers/pinctrl/qcom/pinctrl-eliza.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-eliza.c b/drivers/pinctrl/qcom/pinctrl-eliza.c
index c1f756cbcdeb..b3413520a115 100644
--- a/drivers/pinctrl/qcom/pinctrl-eliza.c
+++ b/drivers/pinctrl/qcom/pinctrl-eliza.c
@@ -1305,7 +1305,7 @@ static const struct msm_pingroup eliza_groups[] = {
 	[16] = PINGROUP(16, qup2_se5, qup2_se2, mdp_vsync, mdp_vsync2_out, mdp_vsync3_out, _, _, _, _, _, _),
 	[17] = PINGROUP(17, qup2_se5, qup2_se2, mdp_vsync, mdp_vsync0_out, mdp_vsync1_out, _, _, _, _, _, _),
 	[18] = PINGROUP(18, qup2_se5, qup2_se2, hdmi_pixel_clk, _, qdss_cti, _, _, _, _, _, _),
-	[19] = PINGROUP(19, qup2_se5, hdmi_rcv_det, _, qdss_cti, _, _, _, _, _, _, _),
+	[19] = PINGROUP(19, qup2_se5, _, hdmi_rcv_det, qdss_cti, _, _, _, _, _, _, _),
 	[20] = PINGROUP(20, qup2_se6, _, _, _, _, _, _, _, _, _, _),
 	[21] = PINGROUP(21, qup2_se6, _, _, _, _, _, _, _, _, _, _),
 	[22] = PINGROUP(22, qup2_se6, _, _, _, _, _, _, _, _, _, _),

-- 
2.53.0

[PATCH RFC 2/2] pinctrl: qcom: eliza: Fix QDSS trace clock/control pingroup names

[Alexander Koskovich]

Fix a few typos for these in their respective pingroups, the groups
already exist they just weren't referenced.

Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
---
 drivers/pinctrl/qcom/pinctrl-eliza.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-eliza.c b/drivers/pinctrl/qcom/pinctrl-eliza.c
index b3413520a115..ba99b2a20e9e 100644
--- a/drivers/pinctrl/qcom/pinctrl-eliza.c
+++ b/drivers/pinctrl/qcom/pinctrl-eliza.c
@@ -1340,7 +1340,7 @@ static const struct msm_pingroup eliza_groups[] = {
 	[51] = PINGROUP(51, _, _, _, _, _, _, _, _, _, _, _),
 	[52] = PINGROUP(52, qup1_se2, pcie1_clk_req_n, qup1_se2, ddr_bist_complete, qdss_gpio_tracedata, _, vsense_trigger_mirnat, _, _, _, _),
 	[53] = PINGROUP(53, qup1_se2, qup1_se2, gcc_gp1, ddr_bist_stop, _, qdss_gpio_tracedata, _, _, _, _, _),
-	[54] = PINGROUP(54, qup1_se2, qup1_se6, qdss_gpio_tracedata, gnss_adc1, atest_usb, ddr_pxi0, _, _, _, _, _),
+	[54] = PINGROUP(54, qup1_se2, qup1_se6, qdss_gpio_traceclk, gnss_adc1, atest_usb, ddr_pxi0, _, _, _, _, _),
 	[55] = PINGROUP(55, qup1_se2, dp0_hot, qup1_se6, _, gnss_adc0, atest_usb, ddr_pxi0, _, _, _, _),
 	[56] = PINGROUP(56, usb0_hs, tsense_pwm1, tsense_pwm2, tsense_pwm3, tsense_pwm4, _, _, _, _, _, _),
 	[57] = PINGROUP(57, sd_write_protect, _, _, _, _, _, _, _, _, _, _),
@@ -1358,7 +1358,7 @@ static const struct msm_pingroup eliza_groups[] = {
 	[69] = PINGROUP(69, cam_mclk, audio_ext_mclk0, resout_gpio, prng_rosc1, _, _, _, _, _, _, _),
 	[70] = PINGROUP(70, cci_i2c_sda, tmess_prng2, _, phase_flag, atest_char, _, _, _, _, _, _),
 	[71] = PINGROUP(71, cci_i2c_scl, tmess_prng3, _, phase_flag, atest_char, _, _, _, _, _, _),
-	[72] = PINGROUP(72, cci_i2c_sda, tmess_prng1, qdss_gpio_tracedata, atest_char, _, _, _, _, _, _, _),
+	[72] = PINGROUP(72, cci_i2c_sda, tmess_prng1, qdss_gpio_tracectl, atest_char, _, _, _, _, _, _, _),
 	[73] = PINGROUP(73, cci_i2c_scl, tmess_prng0, qdss_cti, atest_char, _, _, _, _, _, _, _),
 	[74] = PINGROUP(74, cci_i2c_sda, prng_rosc3, qdss_cti, atest_char, _, _, _, _, _, _, _),
 	[75] = PINGROUP(75, cci_i2c_scl, _, phase_flag, _, _, _, _, _, _, _, _),
@@ -1430,10 +1430,10 @@ static const struct msm_pingroup eliza_groups[] = {
 	[141] = PINGROUP(141, _, _, _, _, _, _, _, _, _, _, egpio),
 	[142] = PINGROUP(142, _, _, _, _, _, _, _, _, _, _, egpio),
 	[143] = PINGROUP(143, _, _, _, _, _, _, _, _, _, _, egpio),
-	[144] = PINGROUP(144, _, qdss_gpio_tracedata, _, _, _, _, _, _, _, _, egpio),
+	[144] = PINGROUP(144, _, qdss_gpio_tracectl, _, _, _, _, _, _, _, _, egpio),
 	[145] = PINGROUP(145, qdss_gpio_tracedata, _, _, _, _, _, _, _, _, _, egpio),
 	[146] = PINGROUP(146, _, qdss_gpio_tracedata, _, _, _, _, _, _, _, _, egpio),
-	[147] = PINGROUP(147, ddr_bist_fail, _, qdss_gpio_tracedata, _, _, _, _, _, _, _, egpio),
+	[147] = PINGROUP(147, ddr_bist_fail, _, qdss_gpio_traceclk, _, _, _, _, _, _, _, egpio),
 	[148] = PINGROUP(148, _, _, _, _, _, _, _, _, _, _, egpio),
 	[149] = PINGROUP(149, _, _, _, _, _, _, _, _, _, _, egpio),
 	[150] = PINGROUP(150, _, _, _, _, _, _, _, _, _, _, egpio),

-- 
2.53.0

Re: [PATCH RFC 1/2] pinctrl: qcom: eliza: Fix HDMI_RCV_DET function slot

[Konrad Dybcio]

On 4/23/26 6:51 AM, Alexander Koskovich wrote:
> The hdmi_rcv_det function was placed at alt function slot 2, but the
> correct mux value for this function on GPIO 19 is slot 3. Move it
> accordingly and leave slot 2 unassigned.

No, 2 is the desired one per docs

0 -> GPIO
1 -> QUP2_SE5_L3
2 -> HDMI_RCV_DET

Konrad

Re: [PATCH RFC 2/2] pinctrl: qcom: eliza: Fix QDSS trace clock/control pingroup names

[Konrad Dybcio]

On 4/23/26 6:51 AM, Alexander Koskovich wrote:
> Fix a few typos for these in their respective pingroups, the groups
> already exist they just weren't referenced.
> 
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---

Fixes: 6f26989e15fb ("pinctrl: qcom: Add Eliza pinctrl driver")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH RFC 2/2] pinctrl: qcom: eliza: Fix QDSS trace clock/control pingroup names

[Linus Walleij]

On Thu, Apr 23, 2026 at 6:51 AM Alexander Koskovich <akoskovich@pm.me> wrote:

> Fix a few typos for these in their respective pingroups, the groups
> already exist they just weren't referenced.
>
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>

This patch 2/2 applied for fixes.

Yours,
Linus Walleij

Re: [PATCH RFC 1/2] pinctrl: qcom: eliza: Fix HDMI_RCV_DET function slot

[Alexander Koskovich]

On Thursday, April 23rd, 2026 at 7:08 PM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:

> On 4/23/26 6:51 AM, Alexander Koskovich wrote:
> > The hdmi_rcv_det function was placed at alt function slot 2, but the
> > correct mux value for this function on GPIO 19 is slot 3. Move it
> > accordingly and leave slot 2 unassigned.
> 
> No, 2 is the desired one per docs
> 
> 0 -> GPIO
> 1 -> QUP2_SE5_L3
> 2 -> HDMI_RCV_DET

Is it possible that CQ7790S is a special case? The pin assignment I have for it
here is:

0 -> GPIO
1 -> QUP2_SE5_L3
2 -> N/A
3 -> GP_PDM_MIRA[0]/HDMI_RCV_DET

> 
> Konrad
> 

Thanks,
Alex

>

Re: [PATCH RFC 1/2] pinctrl: qcom: eliza: Fix HDMI_RCV_DET function slot

[Konrad Dybcio]

On 5/28/26 7:24 PM, Alexander Koskovich wrote:
> On Thursday, April 23rd, 2026 at 7:08 PM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
> 
>> On 4/23/26 6:51 AM, Alexander Koskovich wrote:
>>> The hdmi_rcv_det function was placed at alt function slot 2, but the
>>> correct mux value for this function on GPIO 19 is slot 3. Move it
>>> accordingly and leave slot 2 unassigned.
>>
>> No, 2 is the desired one per docs
>>
>> 0 -> GPIO
>> 1 -> QUP2_SE5_L3
>> 2 -> HDMI_RCV_DET
> 
> Is it possible that CQ7790S is a special case? The pin assignment I have for it
> here is:
> 
> 0 -> GPIO
> 1 -> QUP2_SE5_L3
> 2 -> N/A
> 3 -> GP_PDM_MIRA[0]/HDMI_RCV_DET

I'll try to find an answer, even though I doubt it

Konrad

Re: [PATCH RFC 1/2] pinctrl: qcom: eliza: Fix HDMI_RCV_DET function slot

[Konrad Dybcio]

On 5/28/26 7:24 PM, Alexander Koskovich wrote:
> On Thursday, April 23rd, 2026 at 7:08 PM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
> 
>> On 4/23/26 6:51 AM, Alexander Koskovich wrote:
>>> The hdmi_rcv_det function was placed at alt function slot 2, but the
>>> correct mux value for this function on GPIO 19 is slot 3. Move it
>>> accordingly and leave slot 2 unassigned.
>>
>> No, 2 is the desired one per docs
>>
>> 0 -> GPIO
>> 1 -> QUP2_SE5_L3
>> 2 -> HDMI_RCV_DET
> 
> Is it possible that CQ7790S is a special case? The pin assignment I have for it
> here is:
> 
> 0 -> GPIO
> 1 -> QUP2_SE5_L3
> 2 -> N/A
> 3 -> GP_PDM_MIRA[0]/HDMI_RCV_DET

I was reassured that my source has the latest information

For reference, does your reference doc have any 80-xxxx-xx-like number?

Konrad

Re: [PATCH RFC 1/2] pinctrl: qcom: eliza: Fix HDMI_RCV_DET function slot

[Alexander Koskovich]

On Monday, June 8th, 2026 at 7:55 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:

> On 5/28/26 7:24 PM, Alexander Koskovich wrote:
> > On Thursday, April 23rd, 2026 at 7:08 PM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
> >
> >> On 4/23/26 6:51 AM, Alexander Koskovich wrote:
> >>> The hdmi_rcv_det function was placed at alt function slot 2, but the
> >>> correct mux value for this function on GPIO 19 is slot 3. Move it
> >>> accordingly and leave slot 2 unassigned.
> >>
> >> No, 2 is the desired one per docs
> >>
> >> 0 -> GPIO
> >> 1 -> QUP2_SE5_L3
> >> 2 -> HDMI_RCV_DET
> >
> > Is it possible that CQ7790S is a special case? The pin assignment I have for it
> > here is:
> >
> > 0 -> GPIO
> > 1 -> QUP2_SE5_L3
> > 2 -> N/A
> > 3 -> GP_PDM_MIRA[0]/HDMI_RCV_DET
> 
> I was reassured that my source has the latest information
> 
> For reference, does your reference doc have any 80-xxxx-xx-like number?

Yes, the document I am referencing is 80-97791-1A, though since you've double
checked likely just means this is is incorrect?

Thanks,
Alex

Re: [PATCH RFC 1/2] pinctrl: qcom: eliza: Fix HDMI_RCV_DET function slot

[Konrad Dybcio]

On 6/8/26 8:41 PM, Alexander Koskovich wrote:
> On Monday, June 8th, 2026 at 7:55 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
> 
>> On 5/28/26 7:24 PM, Alexander Koskovich wrote:
>>> On Thursday, April 23rd, 2026 at 7:08 PM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
>>>
>>>> On 4/23/26 6:51 AM, Alexander Koskovich wrote:
>>>>> The hdmi_rcv_det function was placed at alt function slot 2, but the
>>>>> correct mux value for this function on GPIO 19 is slot 3. Move it
>>>>> accordingly and leave slot 2 unassigned.
>>>>
>>>> No, 2 is the desired one per docs
>>>>
>>>> 0 -> GPIO
>>>> 1 -> QUP2_SE5_L3
>>>> 2 -> HDMI_RCV_DET
>>>
>>> Is it possible that CQ7790S is a special case? The pin assignment I have for it
>>> here is:
>>>
>>> 0 -> GPIO
>>> 1 -> QUP2_SE5_L3
>>> 2 -> N/A
>>> 3 -> GP_PDM_MIRA[0]/HDMI_RCV_DET
>>
>> I was reassured that my source has the latest information
>>
>> For reference, does your reference doc have any 80-xxxx-xx-like number?
> 
> Yes, the document I am referencing is 80-97791-1A, though since you've double
> checked likely just means this is is incorrect?

Yes, I got confirmation from 2 separate people

Konrad