From: Joe Perches <joe@perches.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Cc: Jacob Keller <jacob.e.keller@intel.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH] checkpatch: don't complain on _Static_assert and _Generic use
Date: Mon, 27 Nov 2023 16:46:51 -0800 [thread overview]
Message-ID: <bfe9cc37ea78bd7833d22e5859495929cc896fa3.camel@perches.com> (raw)
In-Reply-To: <20231127151847.52945-1-przemyslaw.kitszel@intel.com>
On Mon, 2023-11-27 at 16:18 +0100, Przemek Kitszel wrote:
> Improve CamelCase recognition logic to avoid reporting on _Static_assert()
> and _Generic() use.
>
> Other C keywords, such as _Bool, are intentionally omitted, as those
> should be rather avoided in new source code.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -5839,6 +5839,8 @@ sub process {
> #CamelCase
> if ($var !~ /^$Constant$/ &&
> $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
> +#Ignore C keywords
> + $var !~ /_Static_assert|_Generic/ &&
You'll need
$var != /^(?:_Static_assert|_Generic)$/ &&
to avoid words that contain either
> #Ignore some autogenerated defines and enum values
> $var !~ /^(?:[A-Z]+_){1,5}[A-Z]{1,3}[a-z]/ &&
> #Ignore Page<foo> variants
next prev parent reply other threads:[~2023-11-28 0:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 15:18 Przemek Kitszel
2023-11-28 0:46 ` Joe Perches [this message]
2023-11-28 10:25 ` Przemek Kitszel
2023-11-28 10:52 ` Joe Perches
2023-11-29 0:48 ` Joe Perches
2023-11-29 8:58 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfe9cc37ea78bd7833d22e5859495929cc896fa3.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®