[PATCH 1/2] MAINTAINERS: add include/linux/hugetlb_cgroup.h to HUGETLB SUBSYSTEM

[PATCH 1/2] MAINTAINERS: add include/linux/hugetlb_cgroup.h to HUGETLB SUBSYSTEM

[Enze Li]

include/linux/hugetlb_cgroup.h is the header file paired with
mm/hugetlb_cgroup.c, but it is not listed among the HUGETLB SUBSYSTEM
F: entries.  As a result get_maintainer.pl does not attribute the header
to the hugetlb maintainers explicitly.  Add the F: entry so the file is
covered.

Signed-off-by: Enze Li <lienze@kylinos.cn>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 596efa354ea2..6c210e90722f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12097,6 +12097,7 @@ F:	Documentation/mm/hugetlbfs_reserv.rst
 F:	Documentation/mm/vmemmap_dedup.rst
 F:	fs/hugetlbfs/
 F:	include/linux/hugetlb.h
+F:	include/linux/hugetlb_cgroup.h
 F:	include/linux/vmemmap-optimization.h
 F:	include/trace/events/hugetlbfs.h
 F:	mm/hugetlb.c
-- 
2.25.1

[PATCH 2/2] mm/hugetlb_cgroup: add trailing #endif comment for include guard

[Enze Li]

The final #endif that closes the _LINUX_HUGETLB_CGROUP_H include guard
is left without a comment.  Add the macro name to the comment for
consistency and easier navigation.

Signed-off-by: Enze Li <lienze@kylinos.cn>
---
 include/linux/hugetlb_cgroup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/hugetlb_cgroup.h b/include/linux/hugetlb_cgroup.h
index 16d72c8c71f6..b4e0958eabf3 100644
--- a/include/linux/hugetlb_cgroup.h
+++ b/include/linux/hugetlb_cgroup.h
@@ -268,4 +268,4 @@ static inline void hugetlb_cgroup_migrate(struct folio *old_folio,
 }
 
 #endif  /* CONFIG_CGROUP_HUGETLB */
-#endif
+#endif /* _LINUX_HUGETLB_CGROUP_H */
-- 
2.25.1

Re: [PATCH 1/2] MAINTAINERS: add include/linux/hugetlb_cgroup.h to HUGETLB SUBSYSTEM

[Muchun Song]

> On Oct 1, 2026, at 20:37, Enze Li <lienze@kylinos.cn> wrote:
> 
> include/linux/hugetlb_cgroup.h is the header file paired with
> mm/hugetlb_cgroup.c, but it is not listed among the HUGETLB SUBSYSTEM
> F: entries.  As a result get_maintainer.pl does not attribute the header
> to the hugetlb maintainers explicitly.  Add the F: entry so the file is
> covered.
> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>

Acked-by: Muchun Song <muchun.song@linux.dev>

Thanks

Re: [PATCH 1/2] MAINTAINERS: add include/linux/hugetlb_cgroup.h to HUGETLB SUBSYSTEM

[David Hildenbrand (Arm)]

On 10/1/26 14:37, Enze Li wrote:
> include/linux/hugetlb_cgroup.h is the header file paired with
> mm/hugetlb_cgroup.c, but it is not listed among the HUGETLB SUBSYSTEM
> F: entries.  As a result get_maintainer.pl does not attribute the header
> to the hugetlb maintainers explicitly.  Add the F: entry so the file is
> covered.
> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 596efa354ea2..6c210e90722f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12097,6 +12097,7 @@ F:	Documentation/mm/hugetlbfs_reserv.rst
>  F:	Documentation/mm/vmemmap_dedup.rst
>  F:	fs/hugetlbfs/
>  F:	include/linux/hugetlb.h
> +F:	include/linux/hugetlb_cgroup.h
>  F:	include/linux/vmemmap-optimization.h
>  F:	include/trace/events/hugetlbfs.h
>  F:	mm/hugetlb.c

Great, thanks!

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David

Re: [PATCH 2/2] mm/hugetlb_cgroup: add trailing #endif comment for include guard

[David Hildenbrand (Arm)]

On 10/1/26 14:37, Enze Li wrote:
> The final #endif that closes the _LINUX_HUGETLB_CGROUP_H include guard
> is left without a comment.  Add the macro name to the comment for
> consistency and easier navigation.
> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>
> ---
>  include/linux/hugetlb_cgroup.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/hugetlb_cgroup.h b/include/linux/hugetlb_cgroup.h
> index 16d72c8c71f6..b4e0958eabf3 100644
> --- a/include/linux/hugetlb_cgroup.h
> +++ b/include/linux/hugetlb_cgroup.h
> @@ -268,4 +268,4 @@ static inline void hugetlb_cgroup_migrate(struct folio *old_folio,
>  }
>  
>  #endif  /* CONFIG_CGROUP_HUGETLB */
> -#endif
> +#endif /* _LINUX_HUGETLB_CGROUP_H */

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David

Re: [PATCH 2/2] mm/hugetlb_cgroup: add trailing #endif comment for include guard

[Muchun Song]

> On Oct 1, 2026, at 20:37, Enze Li <lienze@kylinos.cn> wrote:
> 
> The final #endif that closes the _LINUX_HUGETLB_CGROUP_H include guard
> is left without a comment.  Add the macro name to the comment for
> consistency and easier navigation.
> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>

Acked-by: Muchun Song <muchun.song@linux.dev>

Re: [PATCH 1/2] MAINTAINERS: add include/linux/hugetlb_cgroup.h to HUGETLB SUBSYSTEM

[Joe Perches]

On Thu, 2026-10-01 at 20:37 +0800, Enze Li wrote:
> include/linux/hugetlb_cgroup.h is the header file paired with
> mm/hugetlb_cgroup.c, but it is not listed among the HUGETLB SUBSYSTEM
> F: entries.  As a result get_maintainer.pl does not attribute the header
> to the hugetlb maintainers explicitly.  Add the F: entry so the file is
> covered.

This misses another file: include/linux/hugetlb_inline.h

The current HUGETLB block is:

HUGETLB SUBSYSTEM
M:	Muchun Song <muchun.song@linux.dev>
M:	Oscar Salvador <osalvador@suse.de>
R:	David Hildenbrand <david@kernel.org>
L:	linux-mm@kvack.org
S:	Maintained
F:	Documentation/ABI/testing/sysfs-kernel-mm-hugepages
F:	Documentation/admin-guide/mm/hugetlbpage.rst
F:	Documentation/mm/hugetlbfs_reserv.rst
F:	Documentation/mm/vmemmap_dedup.rst
F:	fs/hugetlbfs/
F:	include/linux/hugetlb.h
F:	include/trace/events/hugetlbfs.h
F:	mm/hugetlb.c
F:	mm/hugetlb_cgroup.c
F:	mm/hugetlb_cma.c
F:	mm/hugetlb_cma.h
F:	mm/hugetlb_sysctl.c
F:	mm/hugetlb_sysfs.c
F:	mm/hugetlb_vmemmap.c
F:	mm/hugetlb_vmemmap.h
F:	tools/testing/selftests/cgroup/test_hugetlb_memcg.c

And your suggestion is:

> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -12097,6 +12097,7 @@ F:	Documentation/mm/hugetlbfs_reserv.rst
>  F:	Documentation/mm/vmemmap_dedup.rst
>  F:	fs/hugetlbfs/
>  F:	include/linux/hugetlb.h
> +F:	include/linux/hugetlb_cgroup.h

but:

$ git ls-files include/linux/hugetlb*
include/linux/hugetlb.h
include/linux/hugetlb_cgroup.h
include/linux/hugetlb_inline.h

so maybe:

F:	include/linux/hugetlb*

or maybe:

X:	arch/**/*hugetlb*
F:	**/*hugetlb*

and remove a lot of other entries

$ git ls-files -- '**/*hugetlb*'
Documentation/admin-guide/cgroup-v1/hugetlb.rst
Documentation/admin-guide/mm/hugetlbpage.rst
Documentation/arch/arm64/hugetlbpage.rst
Documentation/mm/hugetlbfs_reserv.rst
Documentation/translations/zh_CN/arch/arm64/hugetlbpage.rst
Documentation/translations/zh_CN/mm/hugetlbfs_reserv.rst
Documentation/translations/zh_TW/arch/arm64/hugetlbpage.rst
arch/arm/include/asm/hugetlb-3level.h
arch/arm/include/asm/hugetlb.h
arch/arm64/include/asm/hugetlb.h
arch/arm64/mm/hugetlbpage.c
arch/loongarch/include/asm/hugetlb.h
arch/loongarch/mm/hugetlbpage.c
arch/mips/include/asm/hugetlb.h
arch/mips/mm/hugetlbpage.c
arch/parisc/include/asm/hugetlb.h
arch/parisc/mm/hugetlbpage.c
arch/powerpc/include/asm/book3s/64/hugetlb.h
arch/powerpc/include/asm/hugetlb.h
arch/powerpc/include/asm/nohash/32/hugetlb-8xx.h
arch/powerpc/include/asm/nohash/hugetlb-e500.h
arch/powerpc/mm/book3s64/hugetlbpage.c
arch/powerpc/mm/book3s64/radix_hugetlbpage.c
arch/powerpc/mm/hugetlbpage.c
arch/powerpc/mm/nohash/e500_hugetlbpage.c
arch/riscv/include/asm/hugetlb.h
arch/riscv/mm/hugetlbpage.c
arch/s390/include/asm/hugetlb.h
arch/s390/mm/hugetlbpage.c
arch/sh/include/asm/hugetlb.h
arch/sh/mm/hugetlbpage.c
arch/sparc/include/asm/hugetlb.h
arch/sparc/mm/hugetlbpage.c
arch/x86/include/asm/hugetlb.h
arch/x86/mm/hugetlbpage.c
fs/hugetlbfs/Makefile
fs/hugetlbfs/inode.c
include/asm-generic/hugetlb.h
include/linux/hugetlb.h
include/linux/hugetlb_cgroup.h
include/linux/hugetlb_inline.h
include/trace/events/hugetlbfs.h
include/uapi/asm-generic/hugetlb_encode.h
mm/hugetlb.c
mm/hugetlb_cgroup.c
mm/hugetlb_cma.c
mm/hugetlb_cma.h
mm/hugetlb_internal.h
mm/hugetlb_sysctl.c
mm/hugetlb_sysfs.c
mm/hugetlb_vmemmap.c
mm/hugetlb_vmemmap.h
tools/include/asm-generic/hugetlb_encode.h
tools/testing/selftests/arm64/mte/check_hugetlb_options.c
tools/testing/selftests/cgroup/test_hugetlb_memcg.c
tools/testing/selftests/memfd/run_hugetlbfs_test.sh
tools/testing/selftests/mm/charge_reserved_hugetlb.sh
tools/testing/selftests/mm/hugetlb-madvise.c
tools/testing/selftests/mm/hugetlb-mmap.c
tools/testing/selftests/mm/hugetlb-mremap.c
tools/testing/selftests/mm/hugetlb-read-hwpoison.c
tools/testing/selftests/mm/hugetlb-shm.c
tools/testing/selftests/mm/hugetlb-soft-offline.c
tools/testing/selftests/mm/hugetlb_dio.c
tools/testing/selftests/mm/hugetlb_fault_after_madv.c
tools/testing/selftests/mm/hugetlb_madv_vs_map.c
tools/testing/selftests/mm/hugetlb_reparenting_test.sh
tools/testing/selftests/mm/ksft_hugetlb.sh
tools/testing/selftests/mm/write_hugetlb_memory.sh
tools/testing/selftests/mm/write_to_hugetlbfs.c
tools/testing/selftests/powerpc/mm/hugetlb_vs_thp_test.c

Re: [PATCH 2/2] mm/hugetlb_cgroup: add trailing #endif comment for include guard

[SJ Park]

On Thu,  1 Oct 2026 20:37:47 +0800 Enze Li <lienze@kylinos.cn> wrote:

> The final #endif that closes the _LINUX_HUGETLB_CGROUP_H include guard
> is left without a comment.  Add the macro name to the comment for
> consistency and easier navigation.

Makes sense to me.

> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>

Reviewed-by: SJ Park <sj@kernel.org>


Thanks,
SJ

[...]

Re: [PATCH 1/2] MAINTAINERS: add include/linux/hugetlb_cgroup.h to HUGETLB SUBSYSTEM

[David Hildenbrand (Arm)]

On 10/2/26 19:37, Joe Perches wrote:
> On Thu, 2026-10-01 at 20:37 +0800, Enze Li wrote:
>> include/linux/hugetlb_cgroup.h is the header file paired with
>> mm/hugetlb_cgroup.c, but it is not listed among the HUGETLB SUBSYSTEM
>> F: entries.  As a result get_maintainer.pl does not attribute the header
>> to the hugetlb maintainers explicitly.  Add the F: entry so the file is
>> covered.
> 
> This misses another file: include/linux/hugetlb_inline.h

Note that Lorenzo is currently removing that file in his VM_SPECIAL series. So
in mm-unstable it should already be gone.

-- 
Cheers,

David