* Re: [PATCH] arm64: dts: qcom: glymur: Fix gcc clock specifier for usb_mp_qmpphy nodes
2026-06-02 16:51 [PATCH] arm64: dts: qcom: glymur: Fix gcc clock specifier for usb_mp_qmpphy nodes Gopikrishna Garmidi
@ 2026-06-05 12:52 ` Pankaj Patil
2026-06-06 12:28 ` Dmitry Baryshkov
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Pankaj Patil @ 2026-06-05 12:52 UTC (permalink / raw)
To: Gopikrishna Garmidi, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Wesley Cheng, Abel Vesa,
Dmitry Baryshkov
Cc: Konrad Dybcio, Sibi Sankar, Rajendra Nayak, linux-arm-msm,
devicetree, linux-kernel
On 6/2/2026 10:21 PM, Gopikrishna Garmidi wrote:
> usb_mp_qmpphy0 and usb_mp_qmpphy1 have #clock-cells set to 0 so they take
> no specifier. Drop the erroneous QMP_USB43DP_USB3_PIPE_CLK argument.
>
> This fixes the following dtbs_check warning:
> clock-controller@100000 (qcom,glymur-gcc): clocks: [[59, 0], ..... [0]]
> is too long
> from schema $id: http://devicetree.org/schemas/clock/qcom,glymur-gcc.yaml
>
> Fixes: 4eee57dd4df9f ("arm64: dts: qcom: glymur: Add USB related nodes")
> Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/glymur.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> index 20b49af7298e..fd503e10e409 100644
> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> @@ -786,8 +786,8 @@ gcc: clock-controller@100000 {
> <&usb_0_qmpphy QMP_USB43DP_USB3_PIPE_CLK>,
> <&usb_1_qmpphy QMP_USB43DP_USB3_PIPE_CLK>,
> <&usb_2_qmpphy QMP_USB43DP_USB3_PIPE_CLK>,
> - <&usb_mp_qmpphy0 QMP_USB43DP_USB3_PIPE_CLK>,
> - <&usb_mp_qmpphy1 QMP_USB43DP_USB3_PIPE_CLK>,
> + <&usb_mp_qmpphy0>, /* USB3 UNI PHY pipe 0 */
> + <&usb_mp_qmpphy1>, /* USB3 UNI PHY pipe 1 */
> <0>, /* USB4 PHY 0 pcie pipe */
> <0>, /* USB4 PHY 0 Max pipe */
> <0>, /* USB4 PHY 1 pcie pipe */
>
> ---
> base-commit: 08484c504b55a98bd100527fbe10a3caf55ff3ff
> change-id: 20260602-glymur-fix-usb-mp-qmpphy-clock-specifier-6d5e671f173e
>
> Best regards,
Reviewed-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: glymur: Fix gcc clock specifier for usb_mp_qmpphy nodes
2026-06-02 16:51 [PATCH] arm64: dts: qcom: glymur: Fix gcc clock specifier for usb_mp_qmpphy nodes Gopikrishna Garmidi
2026-06-05 12:52 ` Pankaj Patil
@ 2026-06-06 12:28 ` Dmitry Baryshkov
2026-06-08 8:07 ` Konrad Dybcio
2026-07-07 3:21 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2026-06-06 12:28 UTC (permalink / raw)
To: Gopikrishna Garmidi
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Wesley Cheng, Abel Vesa, Pankaj Patil,
Konrad Dybcio, Sibi Sankar, Rajendra Nayak, linux-arm-msm,
devicetree, linux-kernel
On Tue, Jun 02, 2026 at 09:51:35AM -0700, Gopikrishna Garmidi wrote:
> usb_mp_qmpphy0 and usb_mp_qmpphy1 have #clock-cells set to 0 so they take
> no specifier. Drop the erroneous QMP_USB43DP_USB3_PIPE_CLK argument.
>
> This fixes the following dtbs_check warning:
> clock-controller@100000 (qcom,glymur-gcc): clocks: [[59, 0], ..... [0]]
> is too long
> from schema $id: http://devicetree.org/schemas/clock/qcom,glymur-gcc.yaml
>
> Fixes: 4eee57dd4df9f ("arm64: dts: qcom: glymur: Add USB related nodes")
> Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/glymur.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: glymur: Fix gcc clock specifier for usb_mp_qmpphy nodes
2026-06-02 16:51 [PATCH] arm64: dts: qcom: glymur: Fix gcc clock specifier for usb_mp_qmpphy nodes Gopikrishna Garmidi
2026-06-05 12:52 ` Pankaj Patil
2026-06-06 12:28 ` Dmitry Baryshkov
@ 2026-06-08 8:07 ` Konrad Dybcio
2026-07-07 3:21 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2026-06-08 8:07 UTC (permalink / raw)
To: Gopikrishna Garmidi, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Wesley Cheng, Abel Vesa,
Dmitry Baryshkov, Pankaj Patil
Cc: Sibi Sankar, Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel
On 6/2/26 6:51 PM, Gopikrishna Garmidi wrote:
> usb_mp_qmpphy0 and usb_mp_qmpphy1 have #clock-cells set to 0 so they take
> no specifier. Drop the erroneous QMP_USB43DP_USB3_PIPE_CLK argument.
>
> This fixes the following dtbs_check warning:
> clock-controller@100000 (qcom,glymur-gcc): clocks: [[59, 0], ..... [0]]
> is too long
> from schema $id: http://devicetree.org/schemas/clock/qcom,glymur-gcc.yaml
>
> Fixes: 4eee57dd4df9f ("arm64: dts: qcom: glymur: Add USB related nodes")
> Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: glymur: Fix gcc clock specifier for usb_mp_qmpphy nodes
2026-06-02 16:51 [PATCH] arm64: dts: qcom: glymur: Fix gcc clock specifier for usb_mp_qmpphy nodes Gopikrishna Garmidi
` (2 preceding siblings ...)
2026-06-08 8:07 ` Konrad Dybcio
@ 2026-07-07 3:21 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2026-07-07 3:21 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Wesley Cheng, Abel Vesa, Dmitry Baryshkov, Pankaj Patil,
Gopikrishna Garmidi
Cc: Konrad Dybcio, Sibi Sankar, Rajendra Nayak, linux-arm-msm,
devicetree, linux-kernel
On Tue, 02 Jun 2026 09:51:35 -0700, Gopikrishna Garmidi wrote:
> usb_mp_qmpphy0 and usb_mp_qmpphy1 have #clock-cells set to 0 so they take
> no specifier. Drop the erroneous QMP_USB43DP_USB3_PIPE_CLK argument.
>
> This fixes the following dtbs_check warning:
> clock-controller@100000 (qcom,glymur-gcc): clocks: [[59, 0], ..... [0]]
> is too long
> from schema $id: http://devicetree.org/schemas/clock/qcom,glymur-gcc.yaml
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: glymur: Fix gcc clock specifier for usb_mp_qmpphy nodes
commit: eca50d95b60cdcabb82a8e1b727fad2547e52f1d
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread