From: Can Guo <quic_cang@quicinc.com>
To: Bart Van Assche <bvanassche@acm.org>, <mani@kernel.org>,
<quic_nguyenb@quicinc.com>, <quic_nitirawa@quicinc.com>,
<martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, Bean Huo <beanhuo@micron.com>,
Lu Hongfei <luhongfei@vivo.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] scsi: ufs: ufs-sysfs: Introduce UFS power info sysfs nodes
Date: Tue, 31 Oct 2023 12:53:39 +0800 [thread overview]
Message-ID: <c035a67e-d0f2-f235-ea75-36cb31dc7e75@quicinc.com> (raw)
In-Reply-To: <de7e76f8-5ed6-4de0-8084-24e220deb4b3@acm.org>
Hi Bart,
On 9/18/2023 11:36 PM, Bart Van Assche wrote:
> On 9/10/23 22:59, Can Guo wrote:
>> Having UFS power info available in sysfs makes it easier to tell the
>> state
>> of the link during runtime considering we have a bounch of power saving
>> features and various combinations for backward compatiblity.
>
> bounch -> bunch
> compatiblity -> compatibility
>
> Additionally, please combine this patch with patch 5/6 into a single
> patch.
Sure
>
>> -What: /sys/bus/platform/drivers/ufshcd/*/monitor/write_req_latency_sum
>> -What: /sys/bus/platform/devices/*.ufs/monitor/write_req_latency_sum
>> -Date: January 2021
>
> Has the above information perhaps been removed by accident?
Yes, my bad, good catch.
>
>> +What: /sys/bus/platform/drivers/ufshcd/*/power_info/gear
>> +What: /sys/bus/platform/devices/*.ufs/power_info/gear
>> +Date: September 2023
>> Contact: Can Guo <quic_cang@quicinc.com>
>> -Description: This file shows the total latency (in micro seconds)
>> of write
>> - requests after monitor gets started.
>> +Description: This file shows the gear of UFS link.
>> +
>> + The file is read only.
>
> Please explain what "gear" means and also what the unit is of the
> numbers reported via this sysfs attribute.
Sure
>
>> +What: /sys/bus/platform/drivers/ufshcd/*/power_info/mode
>> +What: /sys/bus/platform/devices/*.ufs/power_info/mode
>> +Date: September 2023
>> +Contact: Can Guo <quic_cang@quicinc.com>
>> +Description: This file shows the power mode of UFS link.
>> +
>> + The file is read only.
>
> Please document the meaning of the numbers reported via this sysfs
> attribute.
Sure
>
>> +What: /sys/bus/platform/drivers/ufshcd/*/power_info/rate
>> +What: /sys/bus/platform/devices/*.ufs/power_info/rate
>> +Date: September 2023
>> +Contact: Can Guo <quic_cang@quicinc.com>
>> +Description: This file shows the high speed rate of UFS link.
>> +
>> + The file is read only.
>
> Please document the unit of the numbers reported via this sysfs
> attribute.
Sure
>
>> +What: /sys/bus/platform/drivers/ufshcd/*/power_info/dev_pm
>> +What: /sys/bus/platform/devices/*.ufs/power_info/dev_pm
>> +Date: September 2023
>> +Contact: Can Guo <quic_cang@quicinc.com>
>> +Description: This file shows the UFS device power mode, i.e., the
>> power mode
>> + set to UFS device via the Start Stop Unit command.
>
> Please document the meaning of the numbers reported through this sysfs
> attribute.
Sure
>
>> +What: /sys/bus/platform/drivers/ufshcd/*/power_info/link_state
>> +What: /sys/bus/platform/devices/*.ufs/power_info/link_state
>> +Date: September 2023
>> +Contact: Can Guo <quic_cang@quicinc.com>
>> +Description: This file shows the the state of the UFS link.
>
> Please document the meaning of the numbers reported through this sysfs
> attribute.
Sure
Thanks,
Can Guo.
>
> Thanks,
>
> Bart.
prev parent reply other threads:[~2023-10-31 4:53 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1694411968-14413-1-git-send-email-quic_cang@quicinc.com>
2023-09-11 5:59 ` [PATCH 1/6] scsi: ufs: ufs-qcom: Setup host power mode during init Can Guo
2023-09-14 12:40 ` Nitin Rawat
2023-09-19 10:36 ` Manivannan Sadhasivam
2023-10-31 13:09 ` Can Guo
2023-09-11 5:59 ` [PATCH 2/6] scsi: ufs: ufs-qcom: Add support for UFS device version detection Can Guo
2023-09-11 9:17 ` Konrad Dybcio
2023-09-11 9:42 ` Can Guo
2023-09-11 9:46 ` Konrad Dybcio
2023-09-11 10:02 ` Can Guo
2023-09-15 2:31 ` Dmitry Baryshkov
2023-09-19 12:08 ` Manivannan Sadhasivam
2023-09-19 22:27 ` Dmitry Baryshkov
2023-09-20 10:23 ` Manivannan Sadhasivam
2023-09-20 11:13 ` Dmitry Baryshkov
2023-09-20 11:51 ` Manivannan Sadhasivam
2023-10-18 12:47 ` Manivannan Sadhasivam
2023-10-26 19:31 ` Konrad Dybcio
2023-10-27 12:22 ` Manivannan Sadhasivam
2023-09-15 12:48 ` Konrad Dybcio
2023-10-18 14:02 ` Neil Armstrong
[not found] ` <059cc112-7fb6-4da4-bc25-4eede0252f0e@linaro.org>
2023-10-31 5:06 ` Can Guo
2023-10-31 9:30 ` neil.armstrong
2023-09-11 5:59 ` [PATCH 3/6] phy: qualcomm: phy-qcom-qmp-ufs: Add High Speed Gear 5 support for SM8550 Can Guo
2023-09-14 12:26 ` Nitin Rawat
2023-09-15 2:07 ` Can Guo
2023-09-19 12:10 ` Manivannan Sadhasivam
2023-09-11 5:59 ` [PATCH 4/6] phy: qualcomm: phy-qcom-qmp-ufs: Move data structs and setting tables to header Can Guo
2023-09-14 11:44 ` Nitin Rawat
2023-09-14 12:28 ` Dmitry Baryshkov
2023-09-19 12:15 ` Manivannan Sadhasivam
2023-09-19 22:30 ` Dmitry Baryshkov
2023-09-20 10:19 ` Manivannan Sadhasivam
2023-09-21 14:02 ` Bjorn Andersson
2023-09-22 18:23 ` Manivannan Sadhasivam
2023-09-21 13:58 ` Bjorn Andersson
2023-09-11 5:59 ` [PATCH 5/6] scsi: ufs: ufs-sysfs: Expose UFS power info Can Guo
2023-09-14 11:33 ` Nitin Rawat
2023-09-15 1:59 ` Can Guo
2023-09-19 12:16 ` Manivannan Sadhasivam
2023-10-31 8:08 ` Can Guo
2023-10-26 19:53 ` Bart Van Assche
2023-10-31 4:46 ` Can Guo
2023-09-11 5:59 ` [PATCH 6/6] scsi: ufs: ufs-sysfs: Introduce UFS power info sysfs nodes Can Guo
2023-09-14 11:35 ` Nitin Rawat
2023-09-15 2:00 ` Can Guo
2023-09-18 15:36 ` Bart Van Assche
2023-10-31 4:53 ` Can Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c035a67e-d0f2-f235-ea75-36cb31dc7e75@quicinc.com \
--to=quic_cang@quicinc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luhongfei@vivo.com \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®