From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Jie Gan <jie.gan@oss.qualcomm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
Mao Jinlong <jinlong.mao@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v10 4/8] coresight: etr: refactor the tmc_etr_get_catu_device function
Date: Mon, 26 Jan 2026 16:10:37 +0000 [thread overview]
Message-ID: <c046085f-82e8-4a77-93be-c2a8d59db97e@arm.com> (raw)
In-Reply-To: <20260122-enable-byte-cntr-for-ctcu-v10-4-22978e3c169f@oss.qualcomm.com>
On 22/01/2026 02:08, Jie Gan wrote:
> Refactor tmc_etr_get_catu_device to retrieve the helper device connected
> to the TMC ETR based on helper_subtype.
Please could you leave this as it is and add :
tmc_etr_get_ctcu_device() ?
It doesn't make much sense to refactor something that is a wrapper for
a generic function. Please avoid un-necessary abstraction
Suzuki
>
> Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
> ---
> drivers/hwtracing/coresight/coresight-catu.c | 3 ++-
> drivers/hwtracing/coresight/coresight-tmc-etr.c | 32 ++++++++++++++++---------
> drivers/hwtracing/coresight/coresight-tmc.h | 3 ++-
> 3 files changed, 25 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c
> index 69b36bae97ab..d3972619cc96 100644
> --- a/drivers/hwtracing/coresight/coresight-catu.c
> +++ b/drivers/hwtracing/coresight/coresight-catu.c
> @@ -334,7 +334,8 @@ static int catu_alloc_etr_buf(struct tmc_drvdata *tmc_drvdata,
> struct tmc_sg_table *catu_table;
> struct catu_etr_buf *catu_buf;
>
> - csdev = tmc_etr_get_catu_device(tmc_drvdata);
> + csdev = tmc_etr_get_helper_device(tmc_drvdata,
> + CORESIGHT_DEV_SUBTYPE_HELPER_CATU);
> if (!csdev)
> return -ENODEV;
> catu_buf = kzalloc(sizeof(*catu_buf), GFP_KERNEL);
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> index cbbb15648fb7..16a4562533d5 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> @@ -844,28 +844,37 @@ static const struct etr_buf_operations etr_sg_buf_ops = {
> };
>
> /*
> - * TMC ETR could be connected to a CATU device, which can provide address
> - * translation service. This is represented by the Output port of the TMC
> - * (ETR) connected to the input port of the CATU.
> + * TMC ETR could be connected to the helper device, which can provide address
> + * translation service(CATU) or data filter function(CTCU). This is represented
> + * by the Output port of the TMC (ETR) connected to the input port of the helper.
> *
> - * Returns : coresight_device ptr for the CATU device if a CATU is found.
> + * @drvdata : drvdata of the TMC device
> + * @subtype : helper_subtype of the helper device
> + *
> + * Returns : coresight_device ptr for the helper device if a helper is found.
> * : NULL otherwise.
> */
> struct coresight_device *
> -tmc_etr_get_catu_device(struct tmc_drvdata *drvdata)
> +tmc_etr_get_helper_device(struct tmc_drvdata *drvdata,
> + enum coresight_dev_subtype_helper subtype)
> {
> struct coresight_device *etr = drvdata->csdev;
> - union coresight_dev_subtype catu_subtype = {
> - .helper_subtype = CORESIGHT_DEV_SUBTYPE_HELPER_CATU
> + union coresight_dev_subtype helper_subtype = {
> + .helper_subtype = subtype
> };
>
> - if (!IS_ENABLED(CONFIG_CORESIGHT_CATU))
> +
> + if (subtype == CORESIGHT_DEV_SUBTYPE_HELPER_CATU &&
> + !IS_ENABLED(CONFIG_CORESIGHT_CATU))
> + return NULL;
> + else if (subtype == CORESIGHT_DEV_SUBTYPE_HELPER_CTCU &&
> + !IS_ENABLED(CONFIG_CORESIGHT_CTCU))
> return NULL;
>
> return coresight_find_output_type(etr->pdata, CORESIGHT_DEV_TYPE_HELPER,
> - catu_subtype);
> + helper_subtype);
> }
> -EXPORT_SYMBOL_GPL(tmc_etr_get_catu_device);
> +EXPORT_SYMBOL_GPL(tmc_etr_get_helper_device);
>
> static const struct etr_buf_operations *etr_buf_ops[] = {
> [ETR_MODE_FLAT] = &etr_flat_buf_ops,
> @@ -913,7 +922,8 @@ static void get_etr_buf_hw(struct device *dev, struct etr_buf_hw *buf_hw)
>
> buf_hw->has_iommu = iommu_get_domain_for_dev(dev->parent);
> buf_hw->has_etr_sg = tmc_etr_has_cap(drvdata, TMC_ETR_SG);
> - buf_hw->has_catu = !!tmc_etr_get_catu_device(drvdata);
> + buf_hw->has_catu = !!tmc_etr_get_helper_device(drvdata,
> + CORESIGHT_DEV_SUBTYPE_HELPER_CATU);
> buf_hw->has_resrv = tmc_has_reserved_buffer(drvdata);
> }
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h
> index c9a82ff6cd00..7690a70069da 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc.h
> +++ b/drivers/hwtracing/coresight/coresight-tmc.h
> @@ -471,7 +471,8 @@ static inline uint32_t find_crash_tracedata_crc(struct tmc_drvdata *drvdata,
> return crc32_le(0, (void *)drvdata->resrv_buf.vaddr, crc_size);
> }
>
> -struct coresight_device *tmc_etr_get_catu_device(struct tmc_drvdata *drvdata);
> +struct coresight_device *tmc_etr_get_helper_device(struct tmc_drvdata *drvdata,
> + enum coresight_dev_subtype_helper subtype);
>
> void tmc_etr_set_catu_ops(const struct etr_buf_operations *catu);
> void tmc_etr_remove_catu_ops(void);
>
next prev parent reply other threads:[~2026-01-26 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 2:08 [PATCH v10 0/8] coresight: ctcu: Enable byte-cntr function for TMC ETR Jie Gan
2026-01-22 2:08 ` [PATCH v10 1/8] coresight: core: Refactoring ctcu_get_active_port and make it generic Jie Gan
2026-01-22 10:00 ` Suzuki K Poulose
2026-01-23 1:27 ` Jie Gan
2026-01-22 2:08 ` [PATCH v10 2/8] coresight: tmc: add create/clean functions for etr_buf_list Jie Gan
2026-01-22 2:08 ` [PATCH v10 3/8] coresight: tmc: Introduce sysfs_read_ops to wrap sysfs read operations Jie Gan
2026-01-22 10:07 ` Suzuki K Poulose
2026-01-23 1:32 ` Jie Gan
2026-01-22 2:08 ` [PATCH v10 4/8] coresight: etr: refactor the tmc_etr_get_catu_device function Jie Gan
2026-01-26 16:10 ` Suzuki K Poulose [this message]
2026-01-27 1:00 ` Jie Gan
2026-01-22 2:08 ` [PATCH v10 5/8] dt-bindings: arm: add an interrupt property for Coresight CTCU Jie Gan
2026-01-26 17:22 ` Suzuki K Poulose
2026-01-27 0:59 ` Jie Gan
2026-01-22 2:08 ` [PATCH v10 6/8] coresight: ctcu: enable byte-cntr for TMC ETR devices Jie Gan
2026-01-22 2:08 ` [PATCH v10 7/8] coresight: tmc: integrate byte-cntr's read_ops with sysfs file_ops Jie Gan
2026-01-22 2:08 ` [PATCH v10 8/8] arm64: dts: qcom: lemans: add interrupts to CTCU device Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c046085f-82e8-4a77-93be-c2a8d59db97e@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=jie.gan@oss.qualcomm.com \
--cc=jinlong.mao@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=robh@kernel.org \
--cc=tingwei.zhang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®