* [PATCH v1 1/3] arm64: dts: qcom: talos-lyra-evk: enable audio support
2026-11-17 10:43 [PATCH v1 0/3] ASoC: qcom: Add talos-lyra-evk audio support Karthik S
@ 2026-11-17 10:43 ` Karthik S
2026-11-17 10:50 ` Krzysztof Kozlowski
2026-11-17 10:43 ` [PATCH v1 2/3] ASoC: qcom: sc8280xp: enable support for talos-lyra Karthik S
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Karthik S @ 2026-11-17 10:43 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Jaroslav Kysela, Takashi Iwai
Cc: Abel Vesa, linux-sound, linux-arm-msm, devicetree, linux-kernel,
Karthik S
enable playback and capture over max98091 codec interfaces
for talos-lyra-evk platform.
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
---
.../boot/dts/qcom/talos-lyra-evk-som.dtsi | 1 +
arch/arm64/boot/dts/qcom/talos-lyra-evk.dts | 271 +++++++++++++-----
2 files changed, 202 insertions(+), 70 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
index d254a32760df..7cc1ebec9903 100644
--- a/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
@@ -5,6 +5,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+#include <dt-bindings/sound/qcom,q6afe.h>
#include "talos.dtsi"
#include "pm8150.dtsi"
/ {
diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
index dffe64475ded..f3db271517b5 100644
--- a/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
+++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
@@ -7,109 +7,240 @@
#include "talos-lyra-evk-som.dtsi"
/ {
- model = "Qualcomm Technologies, Inc. QCS615 Talos Lyra EVK";
- compatible = "qcom,talos-lyra-evk", "qcom,qcs615", "qcom,sm6150";
- chassis-type = "embedded";
-
- dp0-connector {
- compatible = "dp-connector";
- label = "DP0";
- type = "full-size";
-
- port {
- dp0_connector_in: endpoint {
- remote-endpoint = <&mdss_dp0_out>;
- };
- };
- };
+ model = "Qualcomm Technologies, Inc. QCS615 Talos Lyra EVK";
+ compatible = "qcom,talos-lyra-evk", "qcom,qcs615", "qcom,sm6150";
+ chassis-type = "embedded";
+
+ dp0-connector {
+ compatible = "dp-connector";
+ label = "DP0";
+ type = "full-size";
+
+ port {
+ dp0_connector_in: endpoint {
+ remote-endpoint = <&mdss_dp0_out>;
+ };
+ };
+ };
+
+ sound {
+ compatible = "qcom,talos-lyra-sndcard";
+ model = "qcs615-snd-card";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&lpi_spkr_i2s_mclk_a>, <&lpi_i2s1_clk>,
+ <&lpi_i2s1_data>, <&lpi_i2s1_ws>;
+
+ sec-mi2s-playback-dai-link {
+ link-name = "Secondary MI2S Playback";
+
+ cpu {
+ sound-dai = <&q6apmbedai SECONDARY_MI2S_RX>;
+ };
+
+ codec {
+ sound-dai = <&max98091>;
+ };
+
+ platform {
+ sound-dai = <&q6apm>;
+ };
+ };
+
+ sec-mi2s-capture-dai-link {
+ link-name = "Secondary MI2S Capture";
+
+ cpu {
+ sound-dai = <&q6apmbedai SECONDARY_MI2S_TX>;
+ };
+
+ codec {
+ sound-dai = <&max98091>;
+ };
+
+ platform {
+ sound-dai = <&q6apm>;
+ };
+ };
+ };
};
&i2c5 {
- clock-frequency = <100000>;
-
- status = "okay";
-
- expander0: gpio@20 {
- compatible = "kinetic,kts1622", "ti,tcal6416";
- reg = <0x20>;
- #gpio-cells = <2>;
- gpio-controller;
- };
-
- expander1: gpio@21 {
- compatible = "kinetic,kts1622", "ti,tcal6416";
- reg = <0x21>;
- #gpio-cells = <2>;
- gpio-controller;
- };
-
- expander2: gpio@38 {
- compatible = "ti,tca9538";
- reg = <0x38>;
- #gpio-cells = <2>;
- gpio-controller;
- };
-
- expander3: gpio@3c {
- compatible = "ti,tca9538";
- reg = <0x3c>;
- #gpio-cells = <2>;
- gpio-controller;
- };
+ clock-frequency = <100000>;
+
+ status = "okay";
+
+ expander0: gpio@20 {
+ compatible = "kinetic,kts1622", "ti,tcal6416";
+ reg = <0x20>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ expander1: gpio@21 {
+ compatible = "kinetic,kts1622", "ti,tcal6416";
+ reg = <0x21>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ expander2: gpio@38 {
+ compatible = "ti,tca9538";
+ reg = <0x38>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ expander3: gpio@3c {
+ compatible = "ti,tca9538";
+ reg = <0x3c>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ max98091: max98091@10 {
+ compatible = "maxim,max98091";
+ reg = <0x10>;
+ #sound-dai-cells = <0>;
+ clock-names = "mclk";
+ clocks = <&q6prmcc LPASS_CLK_ID_SPEAKER_I2S_OSR LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
+ interrupt-parent = <&tlmm>;
+ interrupts = <119 IRQ_TYPE_NONE>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&int_codec>;
+ };
};
&mdss {
- status = "okay";
+ status = "okay";
};
&mdss_dp0 {
- pinctrl-0 = <&dp_hot_plug_det>;
- pinctrl-names = "default";
+ pinctrl-0 = <&dp_hot_plug_det>;
+ pinctrl-names = "default";
- status = "okay";
+ status = "okay";
};
&mdss_dp0_out {
- link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000>;
- remote-endpoint = <&dp0_connector_in>;
+ link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000>;
+ remote-endpoint = <&dp0_connector_in>;
};
&pon_pwrkey {
- status = "okay";
+ status = "okay";
};
&pon_resin {
- linux,code = <KEY_VOLUMEDOWN>;
+ linux,code = <KEY_VOLUMEDOWN>;
- status = "okay";
+ status = "okay";
+};
+
+&soc {
+ lpass_tlmm: pinctrl@62B40000 {
+ compatible = "qcom,qcs615-lpass-lpi-pinctrl";
+ reg = <0x0 0x62B40000 0x0 0x20000>,
+ <0x0 0x62B00000 0x0 0x10000>;
+
+ clocks = <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
+ clock-names = "core";
+
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-ranges = <&lpass_tlmm 0 0 32>;
+ };
+};
+
+&lpass_tlmm {
+ lpi_spkr_i2s_mclk_a: lpi-spkr-i2s-mclk-a-state {
+ pins = "gpio19";
+ function = "spkr_i2s_mclk_a";
+ drive-strength = <16>;
+ bias-disable;
+ output-high;
+ };
+
+ lpi_i2s1_clk: lpi-i2s1-clk-state {
+ pins = "gpio8";
+ function = "i2s1_clk";
+ drive-strength = <8>;
+ bias-disable;
+ output-high;
+ };
+
+ lpi_i2s1_clk_sleep: lpi-i2s1-clk-sleep-state {
+ pins = "gpio8";
+ function = "i2s1_clk";
+ drive-strength = <2>;
+ bias-pull-down;
+ input-enable;
+ };
+
+ lpi_i2s1_data: lpi-i2s1-data-state {
+ pins = "gpio10", "gpio11";
+ function = "i2s1_data";
+ drive-strength = <8>;
+ bias-disable;
+ output-high;
+ };
+
+ lpi_i2s1_data_sleep: lpi-i2s1-data-sleep-state {
+ pins = "gpio10", "gpio11";
+ function = "i2s1_data";
+ drive-strength = <2>;
+ bias-pull-down;
+ input-enable;
+ };
+
+ lpi_i2s1_ws: lpi-i2s1-ws-state {
+ pins = "gpio9";
+ function = "i2s1_ws";
+ drive-strength = <8>;
+ bias-disable;
+ output-high;
+ };
+
+ lpi_i2s1_ws_sleep: lpi-i2s1-ws-sleep-state {
+ pins = "gpio9";
+ function = "i2s1_ws";
+ drive-strength = <2>;
+ bias-pull-down;
+ input-enable;
+ };
};
&spi6 {
- status = "okay";
+ status = "okay";
- tpm@0 {
- compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
- reg = <0>;
- spi-max-frequency = <20000000>;
- };
+ tpm@0 {
+ compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
+ reg = <0>;
+ spi-max-frequency = <20000000>;
+ };
};
&tlmm {
- dp_hot_plug_det: dp-hot-plug-det-state {
- pins = "gpio104";
- function = "dp_hot";
- bias-disable;
- };
+ int_codec: gpio-irq-state {
+ pins = "gpio119";
+ function = "gpio";
+ };
+
+ dp_hot_plug_det: dp-hot-plug-det-state {
+ pins = "gpio104";
+ function = "dp_hot";
+ bias-disable;
+ };
};
&usb_1 {
- dr_mode = "peripheral";
+ dr_mode = "peripheral";
- status = "okay";
+ status = "okay";
};
&usb_2 {
- dr_mode = "host";
+ dr_mode = "host";
- status = "okay";
+ status = "okay";
};
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1 1/3] arm64: dts: qcom: talos-lyra-evk: enable audio support
2026-11-17 10:43 ` [PATCH v1 1/3] arm64: dts: qcom: talos-lyra-evk: enable " Karthik S
@ 2026-11-17 10:50 ` Krzysztof Kozlowski
2026-11-17 11:01 ` Karthik S
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-17 10:50 UTC (permalink / raw)
To: Karthik S, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Jaroslav Kysela, Takashi Iwai
Cc: Abel Vesa, linux-sound, linux-arm-msm, devicetree, linux-kernel
On 17/11/2026 11:43, Karthik S wrote:
> enable playback and capture over max98091 codec interfaces
> for talos-lyra-evk platform.
>
> Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
> ---
> .../boot/dts/qcom/talos-lyra-evk-som.dtsi | 1 +
> arch/arm64/boot/dts/qcom/talos-lyra-evk.dts | 271 +++++++++++++-----
Please order your patches as documented in submitting patches or just
look how people do it.
> 2 files changed, 202 insertions(+), 70 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
> index d254a32760df..7cc1ebec9903 100644
> --- a/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
> @@ -5,6 +5,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +#include <dt-bindings/sound/qcom,q6afe.h>
> #include "talos.dtsi"
> #include "pm8150.dtsi"
> / {
> diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
> index dffe64475ded..f3db271517b5 100644
> --- a/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
> @@ -7,109 +7,240 @@
> #include "talos-lyra-evk-som.dtsi"
>
> / {
> - model = "Qualcomm Technologies, Inc. QCS615 Talos Lyra EVK";
> - compatible = "qcom,talos-lyra-evk", "qcom,qcs615", "qcom,sm6150";
> - chassis-type = "embedded";
What is happening here?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1 1/3] arm64: dts: qcom: talos-lyra-evk: enable audio support
2026-11-17 10:50 ` Krzysztof Kozlowski
@ 2026-11-17 11:01 ` Karthik S
0 siblings, 0 replies; 9+ messages in thread
From: Karthik S @ 2026-11-17 11:01 UTC (permalink / raw)
To: Krzysztof Kozlowski, Srinivas Kandagatla, Liam Girdwood,
Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Jaroslav Kysela, Takashi Iwai
Cc: Abel Vesa, linux-sound, linux-arm-msm, devicetree, linux-kernel
On 11/17/2026 4:20 PM, Krzysztof Kozlowski wrote:
> What is happening here?
hi krszyztof,
git send-email seems to have picked the wrong patchsets, i will resend
V1, sorry for the confusion
Thanks and regards,
karthik
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v1 2/3] ASoC: qcom: sc8280xp: enable support for talos-lyra
2026-11-17 10:43 [PATCH v1 0/3] ASoC: qcom: Add talos-lyra-evk audio support Karthik S
2026-11-17 10:43 ` [PATCH v1 1/3] arm64: dts: qcom: talos-lyra-evk: enable " Karthik S
@ 2026-11-17 10:43 ` Karthik S
2026-11-17 10:43 ` [PATCH v1 3/3] dt-bindings: sound: qcom,sm8250: add talos-lyra-sndcard compatible Karthik S
2026-11-17 10:50 ` [PATCH v1 0/3] ASoC: qcom: Add talos-lyra-evk audio support Krzysztof Kozlowski
3 siblings, 0 replies; 9+ messages in thread
From: Karthik S @ 2026-11-17 10:43 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Jaroslav Kysela, Takashi Iwai
Cc: Abel Vesa, linux-sound, linux-arm-msm, devicetree, linux-kernel,
Karthik S
Add the necessary board widgets, kcontrols and DAPM routes
for max98091 codec support. Enable required DAI format, sysclk
and other required configs.
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
---
sound/soc/qcom/sc8280xp.c | 32 +++++++++++++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
index e136407c56bf..dd503dddc230 100644
--- a/sound/soc/qcom/sc8280xp.c
+++ b/sound/soc/qcom/sc8280xp.c
@@ -44,8 +44,9 @@ static struct snd_soc_dapm_widget sc8280xp_dapm_widgets[] = {
static const struct snd_kcontrol_new max98090_controls[] = {
SOC_DAPM_PIN_SWITCH("Headset Mic12"),
- SOC_DAPM_PIN_SWITCH("Headphone"),
+ SOC_DAPM_PIN_SWITCH("Headset Mic34"),
SOC_DAPM_PIN_SWITCH("Headset Mic56"),
+ SOC_DAPM_PIN_SWITCH("Headphone"),
SOC_DAPM_PIN_SWITCH("Speaker"),
SOC_DAPM_PIN_SWITCH("Receiver"),
SOC_DAPM_PIN_SWITCH("Int Mic"),
@@ -56,12 +57,28 @@ static const struct snd_soc_dapm_widget max98090_dapm_widgets[] = {
SND_SOC_DAPM_MIC("Mic Jack", NULL),
SND_SOC_DAPM_HP("Headphone", NULL),
SND_SOC_DAPM_MIC("Headset Mic12", NULL),
+ SND_SOC_DAPM_MIC("Headset Mic34", NULL),
SND_SOC_DAPM_MIC("Headset Mic56", NULL),
SND_SOC_DAPM_MIC("Int Mic", NULL),
SND_SOC_DAPM_SPK("Receiver", NULL),
SND_SOC_DAPM_SPK("Speaker", NULL),
};
+static const struct snd_soc_dapm_route talos_lyra_dapm_routes[] = {
+ {"IN12", NULL, "Headset Mic12"},
+ {"Headset Mic12", NULL, "MICBIAS"},
+ {"IN34", NULL, "Headset Mic34"},
+ {"Headset Mic34", NULL, "MICBIAS"},
+ {"IN56", NULL, "Headset Mic56"},
+ {"Headset Mic56", NULL, "MICBIAS"},
+ {"Headphone", NULL, "HPL"},
+ {"Headphone", NULL, "HPR"},
+ {"Receiver", NULL, "RCVL"},
+ {"Receiver", NULL, "RCVR"},
+ {"Speaker", NULL, "SPKL"},
+ {"Speaker", NULL, "SPKR"},
+};
+
enum sc8280xp_jack_setup {
SC8280XP_JACK_SETUP_NONE,
SC8280XP_JACK_SETUP_CODEC,
@@ -624,6 +641,18 @@ static const struct qcom_snd_soc_common qcs615_priv_data = {
.codec_sysclk_set = true,
};
+static const struct qcom_snd_soc_common talos_lyra_priv_data = {
+ .driver_name = "qcs615",
+ .dapm_widgets = max98090_dapm_widgets,
+ .num_dapm_widgets = ARRAY_SIZE(max98090_dapm_widgets),
+ .dapm_routes = talos_lyra_dapm_routes,
+ .num_dapm_routes = ARRAY_SIZE(talos_lyra_dapm_routes),
+ .controls = max98090_controls,
+ .num_controls = ARRAY_SIZE(max98090_controls),
+ .codec_dai_fmt = SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_BC_FC,
+ .codec_sysclk_set = true,
+};
+
static const struct qcom_snd_soc_common qcm6490_priv_data = {
.driver_name = "qcm6490",
.dapm_widgets = sc8280xp_dapm_widgets,
@@ -750,6 +779,7 @@ static const struct of_device_id snd_sc8280xp_dt_match[] = {
{ .compatible = "qcom,sm8550-sndcard", .data = &sm8550_priv_data },
{ .compatible = "qcom,sm8650-sndcard", .data = &sm8650_priv_data },
{ .compatible = "qcom,sm8750-sndcard", .data = &sm8750_priv_data },
+ { .compatible = "qcom,talos-lyra-sndcard", .data = &talos_lyra_priv_data },
{}
};
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v1 3/3] dt-bindings: sound: qcom,sm8250: add talos-lyra-sndcard compatible
2026-11-17 10:43 [PATCH v1 0/3] ASoC: qcom: Add talos-lyra-evk audio support Karthik S
2026-11-17 10:43 ` [PATCH v1 1/3] arm64: dts: qcom: talos-lyra-evk: enable " Karthik S
2026-11-17 10:43 ` [PATCH v1 2/3] ASoC: qcom: sc8280xp: enable support for talos-lyra Karthik S
@ 2026-11-17 10:43 ` Karthik S
2026-11-17 10:50 ` [PATCH v1 0/3] ASoC: qcom: Add talos-lyra-evk audio support Krzysztof Kozlowski
3 siblings, 0 replies; 9+ messages in thread
From: Karthik S @ 2026-11-17 10:43 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Jaroslav Kysela, Takashi Iwai
Cc: Abel Vesa, linux-sound, linux-arm-msm, devicetree, linux-kernel,
Karthik S
Add the qcom,talos-lyra-sndcard compatible string to the
qcom,sm8250 sound bindings.
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
---
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
index e2e3fc99e6d9..40b68b72f8f4 100644
--- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
@@ -55,6 +55,7 @@ properties:
- qcom,sdm845-sndcard
- qcom,sm8250-sndcard
- qcom,sm8450-sndcard
+ - qcom,talos-lyra-sndcard
- qcom,x1e80100-sndcard
- thundercomm,qcs6490-rubikpi3-sndcard
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1 0/3] ASoC: qcom: Add talos-lyra-evk audio support
2026-11-17 10:43 [PATCH v1 0/3] ASoC: qcom: Add talos-lyra-evk audio support Karthik S
` (2 preceding siblings ...)
2026-11-17 10:43 ` [PATCH v1 3/3] dt-bindings: sound: qcom,sm8250: add talos-lyra-sndcard compatible Karthik S
@ 2026-11-17 10:50 ` Krzysztof Kozlowski
3 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-17 10:50 UTC (permalink / raw)
To: Karthik S, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Jaroslav Kysela, Takashi Iwai
Cc: Abel Vesa, linux-sound, linux-arm-msm, devicetree, linux-kernel
On 17/11/2026 11:43, Karthik S wrote:
> Dependencies:
> - https://lore.kernel.org/all/20261027-talos-lyra-evk-v2-v3-2-658fd5a7ec99@oss.qualcomm.com/
> talos-lyra-evk board support (precon)
> - https://lore.kernel.org/all/20261117075100.272535-1-karthik.s@oss.qualcomm.com/#t
> pinctrl: qcom: add QCS615 LPASS LPI pinctrl driver
>
No, stop. How did you solve the complains/problems that such patches
have unnecessary too many dependencies?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread